molecule-ai/molecule-core
51
0
Fork 2
Code Issues 164 Pull Requests 155 Actions 13 Packages Projects Releases Wiki Activity

fix: handle ignored http.NewRequest errors in production code #1919

Merged
agent-dev-a merged 1 commits from fix/http-newrequest-ignored-errors into main 2026-05-26 16:45:19 +00:00
Conversation 2 Commits 1 Files Changed 2
+16 -4
2 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
workspace-server/internal/handlers/github_token.go
+4 -1
View File
@@ -155,7 +155,10 @@ func generateAppInstallationToken() (string, time.Time, error) {
if err != nil {
return "", time.Time{}, fmt.Errorf("sign JWT: %w", err)
}
req, _ := http.NewRequest("POST", fmt.Sprintf("https://api.github.com/app/installations/%d/access_tokens", installID), nil)
req, err := http.NewRequest("POST", fmt.Sprintf("https://api.github.com/app/installations/%d/access_tokens", installID), nil)
if err != nil {
return "", time.Time{}, fmt.Errorf("build request: %w", err)
}
req.Header.Set("Authorization", "Bearer "+signed)
req.Header.Set("Accept", "application/vnd.github+json")
client := &http.Client{Timeout: 30 * time.Second}
workspace-server/internal/provisioner/cp_provisioner.go
+12 -3
View File
@@ -398,7 +398,10 @@ func (p *CPProvisioner) Stop(ctx context.Context, workspaceID string) error {
return ErrNoBackend
}
url := fmt.Sprintf("%s/cp/workspaces/%s?instance_id=%s", p.baseURL, workspaceID, instanceID)
req, _ := http.NewRequestWithContext(ctx, "DELETE", url, nil)
req, err := http.NewRequestWithContext(ctx, "DELETE", url, nil)
if err != nil {
return fmt.Errorf("cp provisioner: stop: build request: %w", err)
}
p.provisionAuthHeaders(req)
resp, err := p.httpClient.Do(req)
if err != nil {
@@ -513,7 +516,10 @@ func (p *CPProvisioner) IsRunning(ctx context.Context, workspaceID string) (bool
return false, ErrNoBackend
}
url := fmt.Sprintf("%s/cp/workspaces/%s/status?instance_id=%s", p.baseURL, workspaceID, instanceID)
req, _ := http.NewRequestWithContext(ctx, "GET", url, nil)
req, err := http.NewRequestWithContext(ctx, "GET", url, nil)
if err != nil {
return true, fmt.Errorf("cp provisioner: status: build request: %w", err)
}
p.provisionAuthHeaders(req)
resp, err := p.httpClient.Do(req)
if err != nil {
@@ -547,7 +553,10 @@ func (p *CPProvisioner) IsRunning(ctx context.Context, workspaceID string) (bool
// to render to the user.
func (p *CPProvisioner) GetConsoleOutput(ctx context.Context, workspaceID string) (string, error) {
url := fmt.Sprintf("%s/cp/admin/workspaces/%s/console", p.baseURL, workspaceID)
req, _ := http.NewRequestWithContext(ctx, "GET", url, nil)
req, err := http.NewRequestWithContext(ctx, "GET", url, nil)
if err != nil {
return "", fmt.Errorf("cp provisioner: console: build request: %w", err)
}
p.adminAuthHeaders(req)
resp, err := p.httpClient.Do(req)
if err != nil {