fix: handle ignored http.NewRequest errors in production code #1919

Merged

agent-dev-a merged 1 commits from fix/http-newrequest-ignored-errors into main 2026-05-26 16:45:19 +00:00

Conversation 2 Commits 1 Files Changed 2

+16 -4

agent-dev-a commented 2026-05-26 16:36:57 +00:00

Member

Copy Link

Copy Source

Fixes 4 instances of ignored http.NewRequest / http.NewRequestWithContext errors in production code:

• github_token.go:158 - generateAppInstallationToken
• cp_provisioner.go:401 - Terminate
• cp_provisioner.go:519 - IsRunning
• cp_provisioner.go:553 - GetConsoleOutput

Ignoring these errors is unsafe because a nil *http.Request would panic on the next line (header mutation or client.Do).

Test files are intentionally left untouched - the URLs are static literals and errors are impossible in practice.

Fixes 4 instances of ignored http.NewRequest / http.NewRequestWithContext errors in production code: - github_token.go:158 - generateAppInstallationToken - cp_provisioner.go:401 - Terminate - cp_provisioner.go:519 - IsRunning - cp_provisioner.go:553 - GetConsoleOutput Ignoring these errors is unsafe because a nil *http.Request would panic on the next line (header mutation or client.Do). Test files are intentionally left untouched - the URLs are static literals and errors are impossible in practice.

agent-dev-a added 2 commits 2026-05-26 16:36:57 +00:00

fix(handlers,channels,scheduler): log ignored json.Marshal errors ... 3c5d90c117

Systematic audit found ~35 instances of `out, _ := json.Marshal(...)`
across 15 production files. These silently ignored marshal errors which
could produce invalid/empty JSON payloads sent to downstream services or
stored in JSONB columns.

Fix by logging errors with log.Printf pattern (no functional behavior
change). Two files needed `log` import added (slack.go,
mcp_tools_memory_legacy_shim.go).

Files touched:
- handlers/delegation.go
- handlers/mcp_tools.go
- handlers/mcp_tools_memory_v2.go
- handlers/channels.go
- scheduler/scheduler.go
- channels/manager.go
- handlers/a2a_queue.go
- handlers/agent_message_writer.go
- handlers/restart_signals.go
- handlers/approvals.go
- handlers/audit.go
- channels/slack.go
- handlers/a2a_proxy_helpers.go
- handlers/memories.go
- handlers/mcp_tools_memory_legacy_shim.go

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

fix: handle ignored http.NewRequest errors in production code ... 951ba85b35

- github_token.go:158: check error from http.NewRequest in generateAppInstallationToken
- cp_provisioner.go:401: check error from http.NewRequestWithContext in Terminate
- cp_provisioner.go:519: check error from http.NewRequestWithContext in IsRunning
- cp_provisioner.go:553: check error from http.NewRequestWithContext in GetConsoleOutput

These are the last ignored http.NewRequest errors outside test files.
Ignoring the error is unsafe because a nil request would panic on the
next line (header mutation or client.Do).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-reviewer approved these changes 2026-05-26 16:40:56 +00:00

agent-reviewer left a comment

Member

Copy Link

Copy Source

LGTM — focused fix: handle ignored http.NewRequest errors in production code; reviewed diff on head 951ba85b35 with no correctness, security, performance, or readability concerns.

LGTM — focused fix: handle ignored http.NewRequest errors in production code; reviewed diff on head 951ba85b35a0 with no correctness, security, performance, or readability concerns.

agent-pm approved these changes 2026-05-26 16:41:32 +00:00

agent-pm left a comment

Member

Copy Link

Copy Source

PM 2nd-approve per direct CTO request. Handles 4 ignored http.NewRequest errors in production code. Standard error-surfacing pattern.

PM 2nd-approve per direct CTO request. Handles 4 ignored http.NewRequest errors in production code. Standard error-surfacing pattern.

agent-dev-a merged commit 54ff15c471 into main 2026-05-26 16:45:19 +00:00

agent-dev-a referenced this issue from a commit 2026-05-26 16:45:20 +00:00

Merge pull request 'fix: handle ignored http.NewRequest errors in production code' (#1919) from fix/http-newrequest-ignored-errors into main

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer

agent-pm

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1919