chore(workspace-server): #1735 remove unused Awareness namespace surface #1737

Merged

hongming merged 3 commits from chore/issue-1735-remove-awareness-backend into main 2026-05-24 04:13:22 +00:00

Conversation 15 Commits 3 Files Changed 20

+113 -166

3 Commits

Author	SHA1	Message	Date
hongming	d7f61f97c8	review(env): #1735 drop AWARENESS_URL from .env.example ... #1737 review finding (agent-reviewer 2026-05-23 against fe59d8d). The backend removal dropped the env injection in internal/provisioner/provisioner.go and the workspaces.awareness_namespace column, but .env.example still documented AWARENESS_URL as "injected into workspace containers along with a deterministic AWARENESS_NAMESPACE derived from workspace ID" — false post-#1737. Operators copying .env.example would set the var, see no effect, and file false-bug reports. Already addressed in this PR's history: - docs/api-reference.md row + docs/api-protocol/platform-api.md line patched in commit 013c8cfe (same PR). - Broader narrative docs sweep in #1758 (separate PR). Refs: #1735, #1737 review finding. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-23 19:26:58 -07:00
hongming	013c8cfe58	review(docs): #1735 patch API spec lines describing awareness_namespace ... #1737 deletes the awareness_namespace column from `workspaces` and the provisioner env injection that backed it. Two API-spec lines still describe the field as if it were live, which would mislead any external integrator reading the docs against a post-#1737 backend: - docs/api-reference.md:106 listed `awareness_namespace` as a column on the `workspaces` row. - docs/api-protocol/platform-api.md:93 claimed workspace creation "assigns an awareness_namespace on the workspace row" and the namespace is "later injected into the provisioned runtime". Both are factually wrong post-#1737. Patched. The broader docs sweep (~30 more references across `docs/architecture/memory.md`, `docs/agent-runtime/*`, READMEs, superpowers plans, etc.) is tracked in #1753 as a docs-only follow-up — those are narrative / handbook copy, not contract. Refs: #1735 (RFC), #1737 (the backend removal PR this rebases on), #1753 (docs sweep follow-up), review-finding C3 (API doc contradiction). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-23 16:57:14 -07:00
hongming	d20147300b	chore(workspace-server): #1735 remove unused Awareness namespace surface ... Drop the entire `Awareness namespace` memory-routing plumbing. The feature was wired through migrations, models, the provisioner, and several handlers but was never enabled in any environment — the 2026-05-23 sweep against the Railway controlplane (project molecule-platform, prod env 59227671-…, staging env 639539ec-…) found zero `AWARENESS_*` env vars set, and the operator-host bootstrap files (`/etc/molecule-bootstrap/all-credentials.env`, `secrets.env`, `agent-secrets.env`) likewise had no awareness entries. The provisioner already only injected the env vars when both URL and namespace were non-empty (so workspace containers also never received them). Scope: - Drop `workspaces.awareness_namespace` column via new forward migration `20260523130000_drop_workspaces_awareness_namespace.up.sql` (mirrors the recent `drop_runtime_image_pins` shape; paired down migration restores migration 010 verbatim). - Drop `Workspace.AwarenessNamespace` from the model. - Drop `WorkspaceConfig.AwarenessURL` + `AwarenessNamespace` and the conditional env injection in `internal/provisioner/provisioner.go`. - Drop `workspaceAwarenessNamespace` + `loadAwarenessNamespace`, rename the one-line helper to `workspaceMemoryNamespace` (still produces the canonical `workspace:<id>` string matching the v2 namespace resolver at `internal/memory/namespace/resolver.go:186`). - `seedInitialMemories` drops its `awarenessNamespace` parameter and computes the namespace inline — the parameter was always `workspace:<workspaceID>` at every call site, so the value is a pure function of the workspace id. - Update three INSERT call sites (`workspace.go`, `org_import.go`) and the org-import root-memory seed in `org.go`. - Trim `awareness_namespace` from the create-handler response payload. - Remove ~22 awareness-specific test assertions and SQL-mock arg placeholders across `handlers_test.go`, `handlers_additional_test.go`, `workspace_test.go`, `workspace_provision_test.go`, `workspace_compute_test.go`, `workspace_budget_test.go`, `workspace_create_name_integration_test.go`, and `provisioner_test.go`. The `agent_memories.namespace` column (added by migration 017) is unaffected — seedInitialMemories continues to write `workspace:<id>` into it, just computed inline now. Canvas-side cleanup (the `<iframe>` block in `MemoryTab.tsx` reading `NEXT_PUBLIC_AWARENESS_URL`) is deliberately deferred — it overlaps with the rewrite landing in #1734 and goes in after that to avoid the merge conflict. Verification: - `go vet ./...` clean. - `go test -short -count=1 ./...` green (~30 packages). - Migration round-trip verified on a throwaway `postgres:16-alpine` container: up drops the column, down restores it to the same `text` type as migration 010. Refs: #1735 (this issue), #1733 (memory SSOT consolidation), #1734 (canvas Memory tab bug). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-23 16:55:10 -07:00