chore(workspace-server): #1735 remove unused Awareness namespace surface #1737

Merged

hongming merged 3 commits from chore/issue-1735-remove-awareness-backend into main 2026-05-24 04:13:22 +00:00

Conversation 15 Commits 3 Files Changed 20

+113 -166

hongming commented 2026-05-23 20:21:22 +00:00

Owner

Copy Link

Copy Source

Closes #1735.

Phase 1 — Investigation

Awareness namespaces were a memory-routing surface (AWARENESS_URL + AWARENESS_NAMESPACE env vars on the workspace container) that was plumbed across the platform but never wired in any environment:

Surface	Verified state
Railway controlplane prod env (59227671-8459-4d68-8f64-2fb868d3c0d8)	No AWARENESS_* keys (0 / 70 vars).
Railway controlplane staging env (639539ec-f84b-44c9-b90f-2a57dccb736c)	No AWARENESS_* keys (0 / 69 vars).
Operator-host bootstrap files (/etc/molecule-bootstrap/{all-credentials.env,secrets.env,agent-secrets.env}, /opt/iam/)	No matches.
internal/provisioner/provisioner.go:709 (pre-change)	Injected the vars only when both URL + namespace were non-empty — workspace containers never received them.

Verified 2026-05-23 via the Railway GraphQL API.

The column workspaces.awareness_namespace (migration 010) was populated for every row, but only ever held the canonical workspace:<id> string — the same value the v2 namespace resolver derives on its own at internal/memory/namespace/resolver.go:186. Removing the column changes no agent-visible namespace.

Phase 2 — Design

Single PR. Backend-only — the canvas <iframe> block in MemoryTab.tsx is handled separately in PR #1749 (which closes #1734) by deleting the dead component entirely. No canvas surface change in this PR.

Migration shape mirrors 20260520120000_drop_runtime_image_pins — forward ALTER TABLE ... DROP COLUMN IF EXISTS, down ALTER TABLE ... ADD COLUMN IF NOT EXISTS TEXT matching migration 010 verbatim.

The one helper that survives — renamed from workspaceAwarenessNamespace to workspaceMemoryNamespace — centralises the workspace:<id> string formation used by seedInitialMemories. Same value, accurate name.

Phase 3 — Implementation

• Drop workspaces.awareness_namespace (new forward + down migration).
• Drop Workspace.AwarenessNamespace from the model.
• Drop WorkspaceConfig.AwarenessURL / AwarenessNamespace + the conditional env injection in the provisioner.
• Drop loadAwarenessNamespace (DB lookup now redundant), rename workspaceAwarenessNamespace → workspaceMemoryNamespace.
• seedInitialMemories drops its awarenessNamespace parameter — at every call site the value was workspace:<workspaceID>, a pure function of the workspace id.
• Three INSERT call sites trimmed (workspace.go, org_import.go); org-import root-memory seed in org.go updated.
• awareness_namespace removed from the create-handler JSON response.
• ~22 awareness-specific test assertions and sqlmock arg placeholders removed across handlers_test.go, handlers_additional_test.go, workspace_test.go, workspace_provision_test.go, workspace_compute_test.go, workspace_budget_test.go, workspace_create_name_integration_test.go, and provisioner_test.go.

agent_memories.namespace (migration 017) is unaffected — seedInitialMemories continues to write workspace:<id> into it, just computed inline now.

Phase 3 — Stage gates

Stage A — Local platform boot / build / tests

• go vet ./... clean.
• go test -short -count=1 ./... green (30 packages, ~75 s).
• Migration round-trip on a throwaway postgres:16-alpine:
  • up dropped the column;
  • down restored it as text matching migration 010;
  • schema bit-identical before and after the cycle.

Stage B — Staging tenant probe

• N/A pre-merge: feature was already dark in staging. Post-merge, the existing staging deploy lane will exercise the new migration on its real schema.

Stage C — Real-task runtime smoke

• N/A: no behavioural change (the env vars were already absent from every workspace container).

Docs follow-up

The broader docs sweep (~30 "awareness namespace" mentions across architecture docs, runtime config docs, READMEs, superpowers plans, and one postmortem) is tracked in #1753 as a docs-only follow-up. The two API-spec lines (docs/api-reference.md row 106 for the workspaces table description, and docs/api-protocol/platform-api.md line 93 claiming workspace creation assigns an awareness namespace) are patched in this PR because they describe an API contract and would mislead external integrators post-merge.

Risks

• External SDK consumers: ProvisioningPayload.AwarenessNamespace was removed; a quick grep of ~/molecule-core/ shows no other repo in the workspace consumes it, but a reviewer with broader visibility (CP, molecule-sdk-python) should confirm before merge.
• Existing rows: every workspaces.awareness_namespace value is the derivable workspace:<id> string — no information is lost by dropping the column.

Sequencing

This PR is part of the memory SSOT cleanup tracked in #1733. Order:

1. This PR (#1735, backend awareness removal — independent).
2. #1733 PR-A — v2 cutover (architectural decision still open in the RFC).
3. #1734 — Memory tab points at v2 (resolved by PR #1749 — deletes the dead MemoryTab.tsx).

Tier

area:memory tier:medium-risk — schema change, no behavioural change.

🤖 Generated with Claude Code

---

SOP Checklist (RFC #351)

1. Comprehensive testing performed

• go vet ./... clean post-rebase.
• go test -short -count=1 ./... green across all 30+ packages.
• Migration round-trip verified on a throwaway postgres:16-alpine container — up drops the column, down restores it to the same text type as migration 010.

2. Local-postgres E2E run

Verified via Docker postgres:16-alpine:

• Up migration (ALTER TABLE workspaces DROP COLUMN IF EXISTS awareness_namespace) succeeded.
• Down migration restored the column.
• Schema bit-shape identical pre/post the cycle (column type + nullability match migration 010).
• go test -short -count=1 ./internal/handlers/... ./internal/provisioner/... green against the post-drop schema.

3. Staging-smoke verified or pending

Scheduled post-merge. The deletion is dark on every existing tenant (AWARENESS_* env vars confirmed unset on Railway controlplane prod + staging via GraphQL audit 2026-05-23). Stage B is a workspace-create + workspace-restart smoke against staging after merge to confirm no INSERT references the dropped column path.

4. Root-cause not symptom

Root cause: an entire memory-routing surface (env-var-controlled awareness namespaces) was plumbed across the model layer, provisioner, handlers, tests, and docs but never wired in any environment. The symptom — "extra config to maintain, dead code in code review, stale docs" — is downstream of the root cause "the feature was never used." This PR removes the cause rather than working around the symptoms.

5. Five-Axis review walked

Yes. Hostile Five-Axis review dispatched (see PR comments). External agent-reviewer posted REQUEST_CHANGES against fe59d8d flagging stale docs in .env.example and the API spec files — all three addressed in subsequent commits (013c8cfe API docs, d7f61f97 .env.example).

6. No backwards-compat shim / dead code added

Net deletion: +113/−163 LOC. Down migration restores the dropped column as a no-op safety net for revert. No shim, no compat layer — the feature was never live so there's no live caller to compatibilize.

7. Memory/saved-feedback consulted

• feedback_no_single_source_of_truth — drives the removal: an inactive secondary backend is itself drift.
• reference_merge_gate_model_changed_2026_05_18 — drives the 2-non-author approval expectation post-rebase (force-pushes dismissed prior approvals).
• feedback_per_agent_gitea_identity_default — approving agents must post under their own Gitea persona, not the founder PAT.

Closes #1735. ## Phase 1 — Investigation Awareness namespaces were a memory-routing surface (`AWARENESS_URL` + `AWARENESS_NAMESPACE` env vars on the workspace container) that was plumbed across the platform but **never wired in any environment**: | Surface | Verified state | |---|---| | Railway `controlplane` prod env (`59227671-8459-4d68-8f64-2fb868d3c0d8`) | No `AWARENESS_*` keys (0 / 70 vars). | | Railway `controlplane` staging env (`639539ec-f84b-44c9-b90f-2a57dccb736c`) | No `AWARENESS_*` keys (0 / 69 vars). | | Operator-host bootstrap files (`/etc/molecule-bootstrap/{all-credentials.env,secrets.env,agent-secrets.env}`, `/opt/iam/`) | No matches. | | `internal/provisioner/provisioner.go:709` (pre-change) | Injected the vars only when **both** URL + namespace were non-empty — workspace containers never received them. | Verified 2026-05-23 via the Railway GraphQL API. The column `workspaces.awareness_namespace` (migration 010) was populated for every row, but only ever held the canonical `workspace:<id>` string — the same value the v2 namespace resolver derives on its own at `internal/memory/namespace/resolver.go:186`. Removing the column changes no agent-visible namespace. ## Phase 2 — Design Single PR. Backend-only — the canvas `<iframe>` block in `MemoryTab.tsx` is handled separately in PR #1749 (which closes #1734) by deleting the dead component entirely. No canvas surface change in this PR. Migration shape mirrors `20260520120000_drop_runtime_image_pins` — forward `ALTER TABLE ... DROP COLUMN IF EXISTS`, down `ALTER TABLE ... ADD COLUMN IF NOT EXISTS TEXT` matching migration 010 verbatim. The one helper that survives — renamed from `workspaceAwarenessNamespace` to `workspaceMemoryNamespace` — centralises the `workspace:<id>` string formation used by `seedInitialMemories`. Same value, accurate name. ## Phase 3 — Implementation - Drop `workspaces.awareness_namespace` (new forward + down migration). - Drop `Workspace.AwarenessNamespace` from the model. - Drop `WorkspaceConfig.AwarenessURL` / `AwarenessNamespace` + the conditional env injection in the provisioner. - Drop `loadAwarenessNamespace` (DB lookup now redundant), rename `workspaceAwarenessNamespace` → `workspaceMemoryNamespace`. - `seedInitialMemories` drops its `awarenessNamespace` parameter — at every call site the value was `workspace:<workspaceID>`, a pure function of the workspace id. - Three INSERT call sites trimmed (`workspace.go`, `org_import.go`); org-import root-memory seed in `org.go` updated. - `awareness_namespace` removed from the create-handler JSON response. - ~22 awareness-specific test assertions and sqlmock arg placeholders removed across `handlers_test.go`, `handlers_additional_test.go`, `workspace_test.go`, `workspace_provision_test.go`, `workspace_compute_test.go`, `workspace_budget_test.go`, `workspace_create_name_integration_test.go`, and `provisioner_test.go`. `agent_memories.namespace` (migration 017) is **unaffected** — `seedInitialMemories` continues to write `workspace:<id>` into it, just computed inline now. ## Phase 3 — Stage gates **Stage A — Local platform boot / build / tests** - `go vet ./...` clean. - `go test -short -count=1 ./...` green (30 packages, ~75 s). - Migration round-trip on a throwaway `postgres:16-alpine`: - up dropped the column; - down restored it as `text` matching migration 010; - schema bit-identical before and after the cycle. **Stage B — Staging tenant probe** - N/A pre-merge: feature was already dark in staging. Post-merge, the existing staging deploy lane will exercise the new migration on its real schema. **Stage C — Real-task runtime smoke** - N/A: no behavioural change (the env vars were already absent from every workspace container). ## Docs follow-up The broader docs sweep (~30 "awareness namespace" mentions across architecture docs, runtime config docs, READMEs, superpowers plans, and one postmortem) is tracked in **#1753** as a docs-only follow-up. The two API-spec lines (`docs/api-reference.md` row 106 for the `workspaces` table description, and `docs/api-protocol/platform-api.md` line 93 claiming workspace creation assigns an awareness namespace) are patched in this PR because they describe an API contract and would mislead external integrators post-merge. ## Risks - **External SDK consumers**: `ProvisioningPayload.AwarenessNamespace` was removed; a quick grep of `~/molecule-core/` shows no other repo in the workspace consumes it, but a reviewer with broader visibility (CP, molecule-sdk-python) should confirm before merge. - **Existing rows**: every `workspaces.awareness_namespace` value is the derivable `workspace:<id>` string — no information is lost by dropping the column. ## Sequencing This PR is part of the memory SSOT cleanup tracked in #1733. Order: 1. **This PR** (#1735, backend awareness removal — independent). 2. #1733 PR-A — v2 cutover (architectural decision still open in the RFC). 3. #1734 — Memory tab points at v2 (resolved by PR #1749 — deletes the dead `MemoryTab.tsx`). ## Tier `area:memory` `tier:medium-risk` — schema change, no behavioural change. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- ## SOP Checklist (RFC #351) ### 1. Comprehensive testing performed - `go vet ./...` clean post-rebase. - `go test -short -count=1 ./...` green across all 30+ packages. - Migration round-trip verified on a throwaway `postgres:16-alpine` container — up drops the column, down restores it to the same `text` type as migration 010. ### 2. Local-postgres E2E run Verified via Docker `postgres:16-alpine`: - Up migration (`ALTER TABLE workspaces DROP COLUMN IF EXISTS awareness_namespace`) succeeded. - Down migration restored the column. - Schema bit-shape identical pre/post the cycle (column type + nullability match migration 010). - `go test -short -count=1 ./internal/handlers/... ./internal/provisioner/...` green against the post-drop schema. ### 3. Staging-smoke verified or pending Scheduled post-merge. The deletion is dark on every existing tenant (`AWARENESS_*` env vars confirmed unset on Railway controlplane prod + staging via GraphQL audit 2026-05-23). Stage B is a workspace-create + workspace-restart smoke against staging after merge to confirm no INSERT references the dropped column path. ### 4. Root-cause not symptom Root cause: an entire memory-routing surface (env-var-controlled awareness namespaces) was plumbed across the model layer, provisioner, handlers, tests, and docs but never wired in any environment. The symptom — "extra config to maintain, dead code in code review, stale docs" — is downstream of the root cause "the feature was never used." This PR removes the cause rather than working around the symptoms. ### 5. Five-Axis review walked Yes. Hostile Five-Axis review dispatched (see PR comments). External `agent-reviewer` posted REQUEST_CHANGES against `fe59d8d` flagging stale docs in `.env.example` and the API spec files — all three addressed in subsequent commits (`013c8cfe` API docs, `d7f61f97` .env.example). ### 6. No backwards-compat shim / dead code added Net deletion: **+113/−163 LOC**. Down migration restores the dropped column as a no-op safety net for revert. No shim, no compat layer — the feature was never live so there's no live caller to compatibilize. ### 7. Memory/saved-feedback consulted - `feedback_no_single_source_of_truth` — drives the removal: an inactive secondary backend is itself drift. - `reference_merge_gate_model_changed_2026_05_18` — drives the 2-non-author approval expectation post-rebase (force-pushes dismissed prior approvals). - `feedback_per_agent_gitea_identity_default` — approving agents must post under their own Gitea persona, not the founder PAT.

hongming added 1 commit 2026-05-23 20:21:24 +00:00

chore(workspace-server): #1735 remove unused Awareness namespace surface ... fe59d8d097

Drop the entire `Awareness namespace` memory-routing plumbing. The
feature was wired through migrations, models, the provisioner, and
several handlers but was never enabled in any environment — the
2026-05-23 sweep against the Railway controlplane (project
molecule-platform, prod env 59227671-…, staging env 639539ec-…) found
zero `AWARENESS_*` env vars set, and the operator-host bootstrap files
(`/etc/molecule-bootstrap/all-credentials.env`, `secrets.env`,
`agent-secrets.env`) likewise had no awareness entries. The provisioner
already only injected the env vars when both URL and namespace were
non-empty (so workspace containers also never received them).

Scope:
- Drop `workspaces.awareness_namespace` column via new forward migration
  `20260523130000_drop_workspaces_awareness_namespace.up.sql` (mirrors
  the recent `drop_runtime_image_pins` shape; paired down migration
  restores migration 010 verbatim).
- Drop `Workspace.AwarenessNamespace` from the model.
- Drop `WorkspaceConfig.AwarenessURL` + `AwarenessNamespace` and the
  conditional env injection in `internal/provisioner/provisioner.go`.
- Drop `workspaceAwarenessNamespace` + `loadAwarenessNamespace`, rename
  the one-line helper to `workspaceMemoryNamespace` (still produces the
  canonical `workspace:<id>` string matching the v2 namespace resolver
  at `internal/memory/namespace/resolver.go:186`).
- `seedInitialMemories` drops its `awarenessNamespace` parameter and
  computes the namespace inline — the parameter was always
  `workspace:<workspaceID>` at every call site, so the value is a pure
  function of the workspace id.
- Update three INSERT call sites (`workspace.go`, `org_import.go`) and
  the org-import root-memory seed in `org.go`.
- Trim `awareness_namespace` from the create-handler response payload.
- Remove ~22 awareness-specific test assertions and SQL-mock arg
  placeholders across `handlers_test.go`, `handlers_additional_test.go`,
  `workspace_test.go`, `workspace_provision_test.go`,
  `workspace_compute_test.go`, `workspace_budget_test.go`,
  `workspace_create_name_integration_test.go`, and
  `provisioner_test.go`.

The `agent_memories.namespace` column (added by migration 017) is
unaffected — seedInitialMemories continues to write `workspace:<id>`
into it, just computed inline now.

Canvas-side cleanup (the `<iframe>` block in `MemoryTab.tsx` reading
`NEXT_PUBLIC_AWARENESS_URL`) is deliberately deferred — it overlaps
with the rewrite landing in #1734 and goes in after that to avoid the
merge conflict.

Verification:
- `go vet ./...` clean.
- `go test -short -count=1 ./...` green (~30 packages).
- Migration round-trip verified on a throwaway `postgres:16-alpine`
  container: up drops the column, down restores it to the same
  `text` type as migration 010.

Refs: #1735 (this issue), #1733 (memory SSOT consolidation), #1734
(canvas Memory tab bug).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

hongming added the tier:medium label 2026-05-23 20:21:41 +00:00

agent-reviewer requested changes 2026-05-23 20:31:26 +00:00

Dismissed

agent-reviewer left a comment

Member

Copy Link

Copy Source

5-axis review on fe59d8d:

Correctness: REQUEST_CHANGES. The backend/schema cleanup removes WorkspaceConfig.AwarenessURL, WorkspaceConfig.AwarenessNamespace, container env injection, the workspaces.awareness_namespace column, and the create-handler awareness_namespace response. However the repo still documents and exposes the removed surface in tracked files: .env.example still says AWARENESS_URL is injected with a deterministic AWARENESS_NAMESPACE; docs/api-protocol/platform-api.md says workspace creation assigns awareness_namespace and later injects it into the runtime; docs/api-reference.md still lists workspaces.awareness_namespace; and runtime docs still describe AWARENESS_URL/AWARENESS_NAMESPACE routing. After this PR those instructions are false and will lead operators/SDK consumers to configure env vars or expect response/schema fields that no longer do anything. Please update or explicitly mark these docs as legacy/deferred in this PR, at least for .env.example and the API/protocol docs that describe the removed backend contract.

Robustness: The migration shape and idempotent DROP/ADD COLUMN IF EXISTS are reasonable; memory seeding still computes workspace:<id>.
Security: No new secret/auth surface found; removing dead env injection reduces stale config exposure.
Performance: No meaningful runtime performance risk.
Readability: The code rename to workspaceMemoryNamespace improves intent, but leaving stale documentation makes the final contract unclear.

5-axis review on fe59d8d: Correctness: REQUEST_CHANGES. The backend/schema cleanup removes `WorkspaceConfig.AwarenessURL`, `WorkspaceConfig.AwarenessNamespace`, container env injection, the `workspaces.awareness_namespace` column, and the create-handler `awareness_namespace` response. However the repo still documents and exposes the removed surface in tracked files: `.env.example` still says `AWARENESS_URL` is injected with a deterministic `AWARENESS_NAMESPACE`; `docs/api-protocol/platform-api.md` says workspace creation assigns `awareness_namespace` and later injects it into the runtime; `docs/api-reference.md` still lists `workspaces.awareness_namespace`; and runtime docs still describe `AWARENESS_URL`/`AWARENESS_NAMESPACE` routing. After this PR those instructions are false and will lead operators/SDK consumers to configure env vars or expect response/schema fields that no longer do anything. Please update or explicitly mark these docs as legacy/deferred in this PR, at least for `.env.example` and the API/protocol docs that describe the removed backend contract. Robustness: The migration shape and idempotent `DROP/ADD COLUMN IF EXISTS` are reasonable; memory seeding still computes `workspace:<id>`. Security: No new secret/auth surface found; removing dead env injection reduces stale config exposure. Performance: No meaningful runtime performance risk. Readability: The code rename to `workspaceMemoryNamespace` improves intent, but leaving stale documentation makes the final contract unclear.

hongming referenced this pull request 2026-05-23 20:53:39 +00:00

RFC: Memory SSOT consolidation — v2 plugin only, freeze v1, drop K/V #1733

hongming referenced this pull request 2026-05-23 21:11:17 +00:00

RFC: Memory SSOT consolidation — v2 plugin only, freeze v1, drop K/V #1733

hongming referenced this pull request 2026-05-23 23:56:28 +00:00

Docs sweep: remove awareness namespace references after #1735 backend removal #1753

app-fe force-pushed chore/issue-1735-remove-awareness-backend from fe59d8d097 to 013c8cfe58 2026-05-23 23:57:23 +00:00 Compare

app-fe referenced this issue from a commit 2026-05-23 23:57:24 +00:00

review(docs): #1735 patch API spec lines describing awareness_namespace

hongming commented 2026-05-24 00:38:41 +00:00

Author

Owner

Copy Link

Copy Source

Post-rebase Stage A re-confirmation (#1737 review-finding process gap):

$ cd ~/molecule-core/workspace-server
$ go vet ./...
(clean — no output)
$ go test -short -count=1 ./...
(all packages pass; zero FAIL / --- FAIL lines)

Verified on 013c8cfe (post-rebase HEAD). Mergeable=True per Gitea API. Awareness symbol grep on the branch returns zero hits in any .go file. Cross-repo grep against ~/Documents/GitHub/molecule-controlplane/ returns zero awareness_namespace / AwarenessNamespace hits.

Post-rebase Stage A re-confirmation (#1737 review-finding process gap): ``` $ cd ~/molecule-core/workspace-server $ go vet ./... (clean — no output) $ go test -short -count=1 ./... (all packages pass; zero FAIL / --- FAIL lines) ``` Verified on `013c8cfe` (post-rebase HEAD). Mergeable=True per Gitea API. Awareness symbol grep on the branch returns zero hits in any `.go` file. Cross-repo grep against `~/Documents/GitHub/molecule-controlplane/` returns zero `awareness_namespace` / `AwarenessNamespace` hits.

app-fe referenced this issue from a commit 2026-05-24 01:11:52 +00:00

docs: #1753 sweep awareness namespace mentions across narrative docs

hongming referenced this pull request 2026-05-24 01:12:24 +00:00

docs: #1753 sweep awareness namespace mentions across narrative docs #1758

app-fe referenced this issue from a commit 2026-05-24 01:26:38 +00:00

feat(memory): #1755 route seedInitialMemories through v2 plugin

hongming referenced this pull request 2026-05-24 01:27:23 +00:00

feat(memory): #1755 route seedInitialMemories through v2 plugin #1759

hongming referenced this pull request 2026-05-24 01:28:44 +00:00

Rename Go module: github.com/Molecule-AI/molecule-monorepo/platform → git.moleculesai.app/molecule-ai/molecule-core/workspace-server #1760

hongming reviewed 2026-05-24 02:23:11 +00:00

hongming left a comment

Author

Owner

Copy Link

Copy Source

Reviewed the diff and targeted tests; no blocking findings.

Reviewed the diff and targeted tests; no blocking findings.

app-fe referenced this issue from a commit 2026-05-24 02:27:02 +00:00

review(env): #1735 drop AWARENESS_URL from .env.example

app-fe added 1 commit 2026-05-24 02:27:02 +00:00

review(env): #1735 drop AWARENESS_URL from .env.example ... d7f61f97c8

#1737 review finding (agent-reviewer 2026-05-23 against fe59d8d).
The backend removal dropped the env injection in
internal/provisioner/provisioner.go and the workspaces.awareness_namespace
column, but .env.example still documented AWARENESS_URL as "injected
into workspace containers along with a deterministic
AWARENESS_NAMESPACE derived from workspace ID" — false post-#1737.
Operators copying .env.example would set the var, see no effect, and
file false-bug reports.

Already addressed in this PR's history:
- docs/api-reference.md row + docs/api-protocol/platform-api.md line
  patched in commit 013c8cfe (same PR).
- Broader narrative docs sweep in #1758 (separate PR).

Refs: #1735, #1737 review finding.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

hongming commented 2026-05-24 02:31:26 +00:00

Author

Owner

Copy Link

Copy Source

@agent-reviewer — addressed the REQUEST_CHANGES findings against fe59d8d:

1. API spec docs (docs/api-reference.md, docs/api-protocol/platform-api.md) — patched in commit 013c8cfe (this same PR, post-rebase).
2. .env.example AWARENESS_URL — patched in commit d7f61f97 just now (this same PR). The stale block describing AWARENESS injection is removed.
3. Runtime narrative docs (docs/agent-runtime/*.md, docs/architecture/memory.md, READMEs, etc.) — tracked + handled in PR #1758 (separate to keep this backend PR small). #1758 is open and ready for review.

SOP-6 checklist now filled in the PR body. Current HEAD d7f61f97.

@agent-reviewer — addressed the REQUEST_CHANGES findings against `fe59d8d`: 1. **API spec docs** (`docs/api-reference.md`, `docs/api-protocol/platform-api.md`) — patched in commit `013c8cfe` (this same PR, post-rebase). 2. **`.env.example` AWARENESS_URL** — patched in commit `d7f61f97` just now (this same PR). The stale block describing AWARENESS injection is removed. 3. **Runtime narrative docs** (`docs/agent-runtime/*.md`, `docs/architecture/memory.md`, READMEs, etc.) — tracked + handled in PR #1758 (separate to keep this backend PR small). #1758 is open and ready for review. SOP-6 checklist now filled in the PR body. Current HEAD `d7f61f97`.

devops-engineer approved these changes 2026-05-24 02:40:14 +00:00

devops-engineer left a comment

Member

Copy Link

Copy Source

Approving on CTO-bypass per 2026-05-24 directive. Re-reviewing on current HEAD after the post-review fix push that dismissed prior approvals via dismiss_stale_approvals=true. Findings from the dispatched Five-Axis review + external agent-reviewer review were both addressed; SOP checklist is filled in the body.

Approving on CTO-bypass per 2026-05-24 directive. Re-reviewing on current HEAD after the post-review fix push that dismissed prior approvals via dismiss_stale_approvals=true. Findings from the dispatched Five-Axis review + external agent-reviewer review were both addressed; SOP checklist is filled in the body.

core-devops approved these changes 2026-05-24 02:40:16 +00:00

core-devops left a comment

Member

Copy Link

Copy Source

Approving on CTO-bypass per 2026-05-24 directive. Re-reviewing on current HEAD after the post-review fix push that dismissed prior approvals via dismiss_stale_approvals=true. Findings from the dispatched Five-Axis review + external agent-reviewer review were both addressed; SOP checklist is filled in the body.

Approving on CTO-bypass per 2026-05-24 directive. Re-reviewing on current HEAD after the post-review fix push that dismissed prior approvals via dismiss_stale_approvals=true. Findings from the dispatched Five-Axis review + external agent-reviewer review were both addressed; SOP checklist is filled in the body.

devops-engineer commented 2026-05-24 02:40:16 +00:00

Member

Copy Link

Copy Source

/sop-ack comprehensive-testing

/sop-ack comprehensive-testing

core-devops commented 2026-05-24 02:40:17 +00:00

Member

Copy Link

Copy Source

/sop-ack local-postgres-e2e

/sop-ack local-postgres-e2e

core-devops commented 2026-05-24 02:40:19 +00:00

Member

Copy Link

Copy Source

/sop-ack staging-smoke

/sop-ack staging-smoke

cp-be commented 2026-05-24 02:40:20 +00:00

Member

Copy Link

Copy Source

/sop-ack root-cause

/sop-ack root-cause

core-security commented 2026-05-24 02:40:21 +00:00

Member

Copy Link

Copy Source

/sop-ack five-axis-review

/sop-ack five-axis-review

documentation-specialist commented 2026-05-24 02:40:22 +00:00

Member

Copy Link

Copy Source

/sop-ack no-backwards-compat

/sop-ack no-backwards-compat

devops-engineer commented 2026-05-24 02:40:23 +00:00

Member

Copy Link

Copy Source

/sop-ack memory-consulted

/sop-ack memory-consulted

devops-engineer commented 2026-05-24 02:44:15 +00:00

Member

Copy Link

Copy Source

/sop-n/a qa-review pure-backend or pure-docs change with no qa surface — exercised via Go unit tests in handlers + memory packages (this PR's diff is Go-internal or docs-only, no UX flows changed)

/sop-n/a qa-review pure-backend or pure-docs change with no qa surface — exercised via Go unit tests in handlers + memory packages (this PR's diff is Go-internal or docs-only, no UX flows changed)

core-security commented 2026-05-24 02:44:15 +00:00

Member

Copy Link

Copy Source

/sop-n/a security-review backend-only refactor with redaction parity preserved (SAFE-T1201 redactSecrets still called pre-commit on every path); no new auth/secret surface introduced. Mutation-tested in the Five-Axis re-review.

/sop-n/a security-review backend-only refactor with redaction parity preserved (SAFE-T1201 redactSecrets still called pre-commit on every path); no new auth/secret surface introduced. Mutation-tested in the Five-Axis re-review.

hongming dismissed agent-reviewer's review 2026-05-24 02:45:45 +00:00

Reason:

Findings from this review have been addressed in subsequent commits (#1737: env.example patched in d7f61f97; #1747: OFFSEC fix in c2b6e8b + SOP checklist filled). Dismissing per CTO-bypass 2026-05-24 to unblock merge.

hongming merged commit d594190653 into main 2026-05-24 04:13:22 +00:00

hongming referenced this issue from a commit 2026-05-24 04:13:24 +00:00

chore(workspace-server): #1735 remove unused Awareness namespace surface (#1737)

app-fe referenced this issue from a commit 2026-05-24 04:14:34 +00:00

feat(memory): #1755 route seedInitialMemories through v2 plugin

hongming referenced this pull request 2026-05-24 05:25:51 +00:00

ci(workflow): all-required umbrella deadlocks the runner pool — move to ci-meta #1779

hongming referenced this pull request 2026-05-24 05:25:51 +00:00

docs/infra: document or auto-handle the compensating-status pattern for stale CI umbrellas #1780

app-fe referenced this issue from a commit 2026-05-24 05:33:33 +00:00

docs(runbooks): document compensating-status recovery for stale CI umbrellas (#1780)

hongming referenced this pull request 2026-05-24 05:34:07 +00:00

docs(runbooks): #1780 compensating-status recovery for stale CI umbrellas #1782

Sign in to join this conversation.

Reviewers

No Reviewers

devops-engineer

core-devops

Labels

Clear labels

area/ci

CI/CD pipeline issues

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

No Label tier:medium

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

8 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1737