molecule-ai/molecule-core
51
0
Fork 2
Code Issues 165 Pull Requests 155 Actions 9 Packages Projects Releases Wiki Activity

fix(channels): log json.Unmarshal errors in List and Webhook handlers #1120

Closed
infra-sre wants to merge 1 commits from sre/channels-unmarshal-errors into main
pull from: sre/channels-unmarshal-errors
merge into: molecule-ai:main
Conversation 1 Commits 1 Files Changed 1
+16 -4
infra-sre commented 2026-05-15 03:47:35 +00:00
Member
Copy Link
Copy Source

Summary

Fixes issue #1108 — silent data loss when DB JSONB contains corrupt data.

Changes:

  • handler (lines 70, 89): check after on config and allowed_users. Log error and fall back to zero values (/) instead of returning to client.
  • handler (lines 499, 500): same fix. Falls back to empty map/slice so still runs (logging any decryption errors) rather than silently skipping webhook routing.

Root cause

returns an error when DB JSONB data is corrupt (e.g., partial write, encoding mismatch). The zero-value result was silently returned, causing / in the List response and validation silently failing in webhook handler.

Test plan

  • Build passes (Go compilation check)
  • CI: Platform (Go) passes
  • CI: Handlers Postgres Integration passes (local Postgres integration test)
  • Review: channels team review

🤖 Generated with Claude Code

## Summary Fixes **issue #1108** — silent data loss when DB JSONB contains corrupt data. **Changes:** - handler (lines 70, 89): check after on config and allowed_users. Log error and fall back to zero values (/) instead of returning to client. - handler (lines 499, 500): same fix. Falls back to empty map/slice so still runs (logging any decryption errors) rather than silently skipping webhook routing. ## Root cause returns an error when DB JSONB data is corrupt (e.g., partial write, encoding mismatch). The zero-value result was silently returned, causing / in the List response and validation silently failing in webhook handler. ## Test plan - [x] Build passes (Go compilation check) - [ ] CI: Platform (Go) passes - [ ] CI: Handlers Postgres Integration passes (local Postgres integration test) - [ ] Review: channels team review 🤖 Generated with [Claude Code](https://claude.com/claude-code)
infra-sre added 1 commit 2026-05-15 03:47:46 +00:00
fix(channels): log json.Unmarshal errors in List and Webhook handlers
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 31s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 24s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 41s
Details
CI / Detect changes (pull_request) Successful in 1m20s
Details
Harness Replays / detect-changes (pull_request) Successful in 26s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 33s
Details
qa-review / approved (pull_request) Successful in 28s
Details
security-review / approved (pull_request) Successful in 27s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m38s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 1m42s
Details
gate-check-v3 / gate-check (pull_request) Successful in 1m4s
Details
sop-checklist / all-items-acked (pull_request) Successful in 37s
Details
sop-tier-check / tier-check (pull_request) Successful in 36s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m34s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m57s
Details
Harness Replays / Harness Replays (pull_request) Successful in 14s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 20s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 27s
Details
CI / Python Lint & Test (pull_request) Successful in 8m5s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 6m14s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 6m48s
Details
CI / Canvas (Next.js) (pull_request) Successful in 17m27s
Details
CI / Canvas Deploy Reminder (pull_request) Successful in 8s
Details
CI / Platform (Go) (pull_request) Successful in 18m40s
Details
CI / all-required (pull_request) Successful in 18m33s
Details
d1651fd101 
Fixes issue #1108 — silent data loss when DB JSONB contains corrupt data.

List handler: if json.Unmarshal fails on channel config or
allowed_users, log the error and fall back to zero values instead
of returning null to the client.

Webhook handler: same fix. Falls back to empty map/slice so the
DecryptSensitiveFields call still runs (logging any decryption
errors) rather than silently skipping webhook processing.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
infra-sre added the merge-queuetier:low labels 2026-05-15 03:49:19 +00:00
infra-sre commented 2026-05-15 03:51:02 +00:00
Author
Member
Copy Link
Copy Source

Closing in favor of PR #1109 which covers the same fix plus rows.Err() checks and unit tests (more complete).

Closing in favor of PR #1109 which covers the same fix plus `rows.Err()` checks and unit tests (more complete).
infra-sre closed this pull request 2026-05-15 03:51:22 +00:00
All checks were successful
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 31s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 24s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 41s
Details
CI / Detect changes (pull_request) Successful in 1m20s
Details
Harness Replays / detect-changes (pull_request) Successful in 26s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 33s
Details
qa-review / approved (pull_request) Successful in 28s
Details
security-review / approved (pull_request) Successful in 27s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m38s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 1m42s
Details
gate-check-v3 / gate-check (pull_request) Successful in 1m4s
Details
sop-checklist / all-items-acked (pull_request) Successful in 37s
Details
sop-tier-check / tier-check (pull_request) Successful in 36s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m34s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m57s
Details
Harness Replays / Harness Replays (pull_request) Successful in 14s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 20s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 27s
Details
CI / Python Lint & Test (pull_request) Successful in 8m5s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 6m14s
Required
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 6m48s
Required
Details
CI / Canvas (Next.js) (pull_request) Successful in 17m27s
Details
CI / Canvas Deploy Reminder (pull_request) Successful in 8s
Details
CI / Platform (Go) (pull_request) Successful in 18m40s
Details
CI / all-required (pull_request) Successful in 18m33s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label merge-queue tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1120
Delete Branch "sre/channels-unmarshal-errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?