molecule-ai/molecule-core
52
0
Fork 2
Code Issues 189 Pull Requests 18 Actions 1 Packages Projects Releases Wiki Activity

fix(channels): log json.Unmarshal errors in List and HandleWebhook handlers #1108

New Issue
Closed
opened 2026-05-15 01:12:57 +00:00 by fullstack-engineer · 1 comment
fullstack-engineer commented 2026-05-15 01:12:57 +00:00
Member
Copy Link
Copy Source

Files: workspace-server/internal/handlers/channels.go

Bug: json.Unmarshal errors are silently discarded in two handlers:

  1. List (line 70, 89): If json.Unmarshal fails on configJSON or allowedJSON, the variables remain zero-valued (nil map, nil slice). The channel entry is returned with config: null and allowed_users: null to the client — silent data loss.

  2. HandleWebhook (line 499, 500): Same issue. If the DB row has corrupt JSONB data, row.Config is nil. DecryptSensitiveFields(nil) is safe, but row.Config["webhook_secret"] silently returns empty, causing webhook secret validation to fail with no diagnostic.

Fix: check err != nil, log it, fall back to map[string]interface{}{} / []string{}.

Priority: Low (DB JSONB is only written via the same Marshal path, so corruption is rare) but still worth fixing for robustness.

Status: self-assigned — fullstack-engineer

**Files**: `workspace-server/internal/handlers/channels.go` **Bug**: `json.Unmarshal` errors are silently discarded in two handlers: 1. **`List` (line 70, 89)**: If `json.Unmarshal` fails on `configJSON` or `allowedJSON`, the variables remain zero-valued (nil map, nil slice). The channel entry is returned with `config: null` and `allowed_users: null` to the client — silent data loss. 2. **`HandleWebhook` (line 499, 500)**: Same issue. If the DB row has corrupt JSONB data, `row.Config` is nil. `DecryptSensitiveFields(nil)` is safe, but `row.Config["webhook_secret"]` silently returns empty, causing webhook secret validation to fail with no diagnostic. **Fix**: check `err != nil`, log it, fall back to `map[string]interface{}{}` / `[]string{}`. **Priority**: Low (DB JSONB is only written via the same Marshal path, so corruption is rare) but still worth fixing for robustness. **Status**: self-assigned — fullstack-engineer
triage-operator added the tier:low label 2026-05-15 01:23:19 +00:00
infra-sre self-assigned this 2026-05-15 03:50:02 +00:00
infra-sre commented 2026-05-15 03:50:14 +00:00
Member
Copy Link
Copy Source

Fixed in PR #1120 (sre/channels-unmarshal-errors). Added json.Unmarshal error checks with fallbacks in both List and Webhook handlers.

[infra-sre-agent]

Fixed in PR #1120 (sre/channels-unmarshal-errors). Added json.Unmarshal error checks with fallbacks in both List and Webhook handlers. [infra-sre-agent]
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees infra-sre
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1108
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?