molecule-ai/molecule-core
41
0
Fork 2
Code Issues 66 Pull Requests 45 Actions 361 Packages Projects Releases Wiki Activity

fix(handlers): add rows.Err() checks after secrets scan loops (closes #1016) #1021

Merged
devops-engineer merged 1 commits from fix/1016-secrets-rows-err-checks into staging 2026-05-14 15:40:35 +00:00
Conversation 15 Commits 1 Files Changed 1 +18
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
workspace-server/internal/handlers/secrets.go
View File

@ -63,6 +63,9 @@ func (h *SecretsHandler) List(c *gin.Context) {
"updated_at": updatedAt,
})
}
if err := rows.Err(); err != nil {
log.Printf("List workspace secrets iteration error: %v", err)
}
// 2. Global secrets not overridden at workspace level
globalRows, err := db.DB.QueryContext(ctx,
@ -91,6 +94,9 @@ func (h *SecretsHandler) List(c *gin.Context) {
"updated_at": updatedAt,
})
}
if err := globalRows.Err(); err != nil {
log.Printf("List global secrets iteration error: %v", err)
}
c.JSON(http.StatusOK, secrets)
}
@ -174,6 +180,9 @@ func (h *SecretsHandler) Values(c *gin.Context) {
out[k] = string(decrypted)
}
}
if err := globalRows.Err(); err != nil {
log.Printf("secrets.Values: global rows iteration error: %v", err)
}
}
wsRows, wErr := db.DB.QueryContext(ctx,
@ -195,6 +204,9 @@ func (h *SecretsHandler) Values(c *gin.Context) {
out[k] = string(decrypted) // workspace override wins over global
}
}
if err := wsRows.Err(); err != nil {
log.Printf("secrets.Values: workspace rows iteration error: %v", err)
}
}
if len(failedKeys) > 0 {
@ -324,6 +336,9 @@ func (h *SecretsHandler) ListGlobal(c *gin.Context) {
"scope": "global",
})
}
if err := rows.Err(); err != nil {
log.Printf("ListGlobal iteration error: %v", err)
}
c.JSON(http.StatusOK, secrets)
}
@ -400,6 +415,9 @@ func (h *SecretsHandler) restartAllAffectedByGlobalKey(key string) {
ids = append(ids, id)
}
}
if err := rows.Err(); err != nil {
log.Printf("restartAllAffectedByGlobalKey: iteration error: %v", err)
}
if len(ids) == 0 {
return
}