molecule-ai/molecule-core

fix(handlers): add rows.Err() checks after secrets scan loops (closes #1016) #1021

Merged

devops-engineer merged 1 commits from fix/1016-secrets-rows-err-checks into staging

2026-05-14 15:40:35 +00:00

Author	SHA1	Message	Date
Molecule AI Fullstack Engineer	858af52d6f	fix(handlers): add rows.Err() checks after secrets scan loops (closes #1016 ) Some checks failed Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s Details Harness Replays / detect-changes (pull_request) Successful in 9s Details Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 8s Details E2E API Smoke Test / detect-changes (pull_request) Successful in 19s Details CI / Detect changes (pull_request) Successful in 19s Details gate-check-v3 / gate-check (pull_request) Successful in 13s Details qa-review / approved (pull_request) Successful in 12s Details Handlers Postgres Integration / detect-changes (pull_request) Successful in 23s Details Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 22s Details security-review / approved (pull_request) Successful in 10s Details sop-tier-check / tier-check (pull_request) Successful in 14s Details lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m6s Details Harness Replays / Harness Replays (pull_request) Successful in 12s Details CI / Canvas (Next.js) (pull_request) Successful in 15s Details CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s Details CI / Python Lint & Test (pull_request) Successful in 8s Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 11s Details E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m2s Details CI / Canvas Deploy Reminder (pull_request) Successful in 5s Details CI / Platform (Go) (pull_request) Failing after 4m27s Details Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 4m10s Details CI / all-required (pull_request) Successful in 6s Details sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review Details sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 5/7 — missing: root-cause, no-backwards-compat — body-unfilled: comprehensive-testing, local-postgres-e2e, staging-sm Details audit-force-merge / audit (pull_request) Successful in 24s Details Regression from audit #109: rows.Err() checks were removed from four functions between commits `3a30b073` and `b25b4fb6`. Without these checks, a mid-stream query error (e.g. connection loss during row iteration) is silently ignored and partial results are returned as success. Added rows.Err() checks after every for rows.Next() loop: - List: workspace secrets loop + global secrets loop - Values: global secrets loop + workspace secrets loop - ListGlobal: single loop - restartAllAffectedByGlobalKey: affected workspaces loop Each check logs the iteration error and continues (non-fatal, matching the existing log.Printf pattern used elsewhere in the file). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 14:12:35 +00:00