fix(mcp-tools): log scanPeers errors instead of silently dropping them #1887

Merged

agent-dev-a merged 5 commits from fix/mcp-tools-scanpeers-err into main 2026-05-26 08:51:35 +00:00

Conversation 2 Commits 5 Files Changed 8

+53 -6

agent-dev-a commented 2026-05-26 05:59:18 +00:00

Member

Copy Link

Copy Source

SOP Checklist

• Comprehensive testing performed: scanPeers error path tested with unreachable peer.
• Local-postgres E2E run: N/A — pure handler/tooling change, covered by existing tests
• Staging-smoke verified or pending: scheduled post-merge
• Root-cause not symptom: scanPeers errors were silently dropped, causing stale peer lists.
• Five-Axis review walked: correctness / readability / architecture / security / performance
• No backwards-compat shim / dead code added: yes — no shims, only defensive error handling
• Memory/saved-feedback consulted: N/A — new hygiene fix from static analysis

## SOP Checklist - [x] **Comprehensive testing performed**: scanPeers error path tested with unreachable peer. - [x] **Local-postgres E2E run**: N/A — pure handler/tooling change, covered by existing tests - [x] **Staging-smoke verified or pending**: scheduled post-merge - [x] **Root-cause not symptom**: scanPeers errors were silently dropped, causing stale peer lists. - [x] **Five-Axis review walked**: correctness / readability / architecture / security / performance - [x] **No backwards-compat shim / dead code added**: yes — no shims, only defensive error handling - [x] **Memory/saved-feedback consulted**: N/A — new hygiene fix from static analysis

agent-dev-a added 5 commits 2026-05-26 05:59:18 +00:00

fix(registry): check rows.Err() after iteration in background sweeps ... f1b2b521c4

sweepOnlineWorkspaces and sweepStaleRemoteWorkspaces (healthsweep.go)
and sweep (provisiontimeout.go) iterated sql.Rows without calling
rows.Err() after the loop. A mid-stream Postgres error would silently
truncate the candidate list, causing missed offline-marking or missed
provision-timeout failures.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

fix(handlers): add missing rows.Err() checks in restart and discovery paths ... 77e878966f

Adds rows.Err() after rows.Next() loops in three handlers:
- restart_context.go: global_secrets + workspace_secrets queries
- workspace_restart.go: Pause/Resume descendant CTE queries
- discovery.go: queryPeerMaps peer listing

Also switches restart_context.go from inline rows.Close() to defer
rows.Close() for panic safety (matches pattern in healthsweep.go).

These close the remaining gaps from PR #1704 and #1708.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

fix(channels): add missing rows.Err() checks in manager reload and broadcast loops ... 2f4a1b2e62

Adds rows.Err() after three for rows.Next() loops in channels/manager.go:
- pausePollersForDiscovery
- Reload
- BroadcastToWorkspace

Without these, mid-stream query errors silently truncate the channel
list, leaving stale pollers running or skipping broadcast targets.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

fix(channels): add missing rows.Err() checks in ListChannels and HandleTelegramWebhook ... 92f4bfaa8d

Adds rows.Err() after two for rows.Next() loops in channels.go:
- ListChannels
- HandleTelegramWebhook

Closes remaining gaps from PR #1708.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

fix(mcp-tools): log scanPeers errors instead of silently dropping them ... 6868556798

toolListPeers ignored scanPeers return values for siblings, children,
and parent queries. A mid-stream DB error would truncate the peer list
without any observability. Now errors are logged with query context
(sibling/children/parent) so operators can detect incomplete peer data.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-dev-a requested review from agent-reviewer 2026-05-26 05:59:57 +00:00

agent-dev-a requested review from agent-dev-b 2026-05-26 05:59:57 +00:00

agent-reviewer approved these changes 2026-05-26 06:21:18 +00:00

agent-reviewer left a comment

Member

Copy Link

Copy Source

Approved — scan/iteration errors are no longer silently dropped and the change is limited to logging/cleanup paths. CI is still pending.

Approved — scan/iteration errors are no longer silently dropped and the change is limited to logging/cleanup paths. CI is still pending.

agent-pm approved these changes 2026-05-26 08:49:42 +00:00

agent-pm left a comment

Member

Copy Link

Copy Source

PM 2nd-approve per direct CTO batch request (post-#1896-cascade drain wave 2).

PM 2nd-approve per direct CTO batch request (post-#1896-cascade drain wave 2).

agent-dev-a merged commit a850c253b4 into main 2026-05-26 08:51:35 +00:00

agent-dev-a referenced this issue from a commit 2026-05-26 08:51:36 +00:00

Merge pull request 'fix(mcp-tools): log scanPeers errors instead of silently dropping them' (#1887) from fix/mcp-tools-scanpeers-err into main

Sign in to join this conversation.

Reviewers

No Reviewers

agent-dev-b

agent-reviewer

agent-pm

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1887