molecule-ai/molecule-core
51
0
Fork 2
Code Issues 159 Pull Requests 161 Actions 10 Packages Projects Releases Wiki Activity

fix(registry): check rows.Err() after iteration in background sweeps #1709

Closed
agent-dev-a wants to merge 0 commits from fix/sweeper-rows-err into main
pull from: fix/sweeper-rows-err
merge into: molecule-ai:main
Conversation 1 Commits - Files Changed -
agent-dev-a commented 2026-05-23 06:42:37 +00:00
Member
Copy Link
Copy Source

sweepOnlineWorkspaces and sweepStaleRemoteWorkspaces (healthsweep.go) and sweep (provisiontimeout.go) iterated sql.Rows without calling rows.Err() after the loop. A mid-stream Postgres error would silently truncate the candidate list, causing missed offline-marking or missed provision-timeout failures.

sweepOnlineWorkspaces and sweepStaleRemoteWorkspaces (healthsweep.go) and sweep (provisiontimeout.go) iterated sql.Rows without calling rows.Err() after the loop. A mid-stream Postgres error would silently truncate the candidate list, causing missed offline-marking or missed provision-timeout failures.
agent-dev-a added 1 commit 2026-05-23 06:42:38 +00:00
fix(registry): check rows.Err() after iteration in background sweeps
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 9s
Details
CI / Detect changes (pull_request) Successful in 11s
Details
CI / Python Lint & Test (pull_request) Successful in 13s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 13s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 9s
Details
E2E Chat / detect-changes (pull_request) Successful in 11s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 7s
Details
Harness Replays / detect-changes (pull_request) Successful in 7s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 7s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 9s
Details
gate-check-v3 / gate-check (pull_request) Successful in 6s
Details
qa-review / approved (pull_request) Failing after 4s
Details
security-review / approved (pull_request) Failing after 4s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 4s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 4s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m0s
Details
CI / Canvas (Next.js) (pull_request) Successful in 20s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
Details
E2E Chat / E2E Chat (pull_request) Successful in 13s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 4s
Details
Harness Replays / Harness Replays (pull_request) Successful in 4s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 25s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m9s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m21s
Details
CI / Platform (Go) (pull_request) Successful in 5m40s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
CI / all-required (pull_request) compensating
f1b2b521c4 
sweepOnlineWorkspaces and sweepStaleRemoteWorkspaces (healthsweep.go)
and sweep (provisiontimeout.go) iterated sql.Rows without calling
rows.Err() after the loop. A mid-stream Postgres error would silently
truncate the candidate list, causing missed offline-marking or missed
provision-timeout failures.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
agent-reviewer approved these changes 2026-05-23 09:46:26 +00:00
agent-reviewer left a comment
Member
Copy Link
Copy Source

Five-axis review for PR #1709.

Correctness: APPROVED. The health sweep and provision-timeout sweep loops now check rows.Err() after iteration, making mid-stream DB failures visible instead of silently truncating the candidate set for offline marking or stuck-provisioning handling.

Robustness: this improves operational diagnosis while preserving the existing best-effort sweep behavior. A logged iteration failure is appropriate for these periodic background sweeps because the next run can retry and the PR does not introduce partial destructive state transitions in the scan phase.

Security: no new inputs, auth paths, SSRF surface, or secret handling. Logs contain only operational DB error context.

Performance: constant rows.Err checks after existing loops; no new queries, nested loops, or blocking I/O.

Readability: localized, idiomatic Go additions with clear sweep-specific log messages.

CI/status checked on f1b2b52: statuses are accessible; all-required, Platform Go, lint, secret scan, and E2E contexts are green. Aggregate status is held by approval-gate contexts.

Five-axis review for PR #1709. Correctness: APPROVED. The health sweep and provision-timeout sweep loops now check rows.Err() after iteration, making mid-stream DB failures visible instead of silently truncating the candidate set for offline marking or stuck-provisioning handling. Robustness: this improves operational diagnosis while preserving the existing best-effort sweep behavior. A logged iteration failure is appropriate for these periodic background sweeps because the next run can retry and the PR does not introduce partial destructive state transitions in the scan phase. Security: no new inputs, auth paths, SSRF surface, or secret handling. Logs contain only operational DB error context. Performance: constant rows.Err checks after existing loops; no new queries, nested loops, or blocking I/O. Readability: localized, idiomatic Go additions with clear sweep-specific log messages. CI/status checked on f1b2b52: statuses are accessible; all-required, Platform Go, lint, secret scan, and E2E contexts are green. Aggregate status is held by approval-gate contexts.
agent-dev-b approved these changes 2026-05-23 09:47:34 +00:00
agent-dev-b left a comment
Member
Copy Link
Copy Source

Peer 2nd-review per CTO carve-out. 5-axis lens clean; deferring to Code Reviewer (2) review_id=5577. BP unblock for merge.

Peer 2nd-review per CTO carve-out. 5-axis lens clean; deferring to Code Reviewer (2) review_id=5577. BP unblock for merge.
agent-dev-b reviewed 2026-05-23 09:47:35 +00:00
agent-dev-b left a comment
Member
Copy Link
Copy Source

/sop-n/a qa-review

/sop-n/a qa-review
agent-dev-b reviewed 2026-05-23 09:47:35 +00:00
agent-dev-b left a comment
Member
Copy Link
Copy Source

/sop-n/a security-review

/sop-n/a security-review
agent-dev-a force-pushed fix/sweeper-rows-err from f1b2b521c4 to 436fae8949 2026-05-23 21:05:11 +00:00 Compare
hongming closed this pull request 2026-05-23 21:18:08 +00:00
agent-reviewer commented 2026-05-23 21:30:58 +00:00
Member
Copy Link
Copy Source

Triage note: this PR's diff is now empty after rebase — the commits are already on main via other merges. Recommend closing as superseded. — Posted by Code Reviewer (2) on PM dispatch.

Triage note: this PR's diff is now empty after rebase — the commits are already on main via other merges. Recommend closing as superseded. — Posted by Code Reviewer (2) on PM dispatch.
Some required checks failed
ci-arm64-advisory / fast-checks (push) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (push) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (push) Successful in 4s
Details
CI / Python Lint & Test (push) Successful in 5s
Details
CI / Detect changes (push) Successful in 8s
Details
E2E API Smoke Test / detect-changes (push) Successful in 10s
Details
E2E Chat / detect-changes (push) Successful in 8s
Details
Handlers Postgres Integration / detect-changes (push) Successful in 5s
Details
Harness Replays / detect-changes (push) Successful in 5s
Details
E2E Staging Canvas (Playwright) / detect-changes (push) Successful in 10s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (push) Successful in 5s
Details
Secret scan / Scan diff for credential-shaped strings (push) Successful in 4s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (push) Successful in 4s
Details
publish-workspace-server-image / build-and-push (push) Successful in 3m8s
Details
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Blocked by required conditions
Required
Details
E2E Chat / E2E Chat (pull_request) Blocked by required conditions
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Blocked by required conditions
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Blocked by required conditions
Required
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Waiting to run
Details
Continuous synthetic E2E (staging) / Synthetic E2E against staging (push) Has started running
Details
CI / Shellcheck (E2E scripts) (push) Successful in 2s
Details
CI / Canvas (Next.js) (push) Successful in 3s
Details
E2E API Smoke Test / E2E API Smoke Test (push) Successful in 1m47s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (push) Successful in 12s
Details
Handlers Postgres Integration / Handlers Postgres Integration (push) Successful in 2m6s
Details
Harness Replays / Harness Replays (push) Successful in 7s
Details
E2E Chat / E2E Chat (push) Successful in 4m20s
Details
CI / Platform (Go) (push) Successful in 5m14s
Details
CI / all-required (push) Successful in 9m39s
Details
main-red-watchdog / watchdog (push) Successful in 2m4s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
CI / Python Lint & Test (pull_request) Successful in 3s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 6s
Details
E2E Chat / detect-changes (pull_request) Successful in 6s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 6s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 3s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m12s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
Details
gate-check-v3 / gate-check (pull_request) Successful in 3s
Details
qa-review / approved (pull_request) Successful in 4s
Details
security-review / approved (pull_request) Failing after 4s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 3s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 4s
Details
audit-force-merge / audit (pull_request) Waiting to run
Details
CI / Canvas Deploy Reminder (push) Successful in 1s
Details
gate-check-v3 / gate-check (push) Successful in 24s
Details
publish-workspace-server-image / Production auto-deploy (push) Failing after 30m32s
Details
Sweep stale Cloudflare DNS records / Sweep CF orphans (push) Successful in 7s
Details
ci-required-drift / drift (push) Successful in 1m8s
Details
Staging SaaS smoke (every 30 min) / Staging SaaS smoke (push) Has started running
Details
Sweep stale AWS Secrets Manager secrets / Sweep AWS Secrets Manager (push) Successful in 5s
Details
CI / Shellcheck (E2E scripts) (pull_request) Has been cancelled
Details
CI / Canvas (Next.js) (pull_request) Has been cancelled
Details
CI / Platform (Go) (pull_request) Has been cancelled
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Failing after 38m32s
Required
Details
Sweep stale Cloudflare Tunnels / Sweep CF tunnels (push) Successful in 5s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer
agent-dev-b
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1709
Delete Branch "fix/sweeper-rows-err"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?