5677 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Molecule AI Core-BE	205be877b8	fix(handlers/test): resolve go vet errors — WSMessage fields, unused vars ... - hub_test.go: replace non-existent Type/Content fields with correct WSMessage.Event field throughout - bundle_helpers_test.go: remove unused want variable in TestSplitLines_TrailingNewline and TestSplitLines_SingleCharNoNewline Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 09:36:36 +00:00
Molecule AI Core-BE	616a94fdc3	ci: retrigger gate-check-v3 for core-devops approval	2026-05-13 09:06:08 +00:00
Molecule AI Core-BE	a132861920	ci: retrigger gate-check-v3 for core-devops approval	2026-05-13 09:06:08 +00:00
Molecule AI Core-BE	86b2935755	[core-be-agent] fix hub_test.go: unbuffered channel hang + pointer identity ... Root cause of CI hang (CI / Platform (Go) failing after 2m11s): 1. TestBroadcast_DropsOnClosedChannel: created an UNBUFFERED channel (make(chan []byte) with no buffer). When Broadcast calls safeSend on this channel, the send blocks indefinitely because nothing is reading from it. go test hangs forever waiting for the test to complete. Fix: use make(chan []byte, 1) buffered channel, fill and close it so safeSend hits the default case (returns false) without blocking. 2. Pointer identity: Broadcast tests used anonymous struct literals in h.clients map assignments, but Go map keys store copies of structs. The range iteration returns a pointer to the stored COPY, not the original literal — so the pointers differ. This matters for tests that might assert pointer identity or pass the client to other functions. Fix: use named client variables so the map key and Broadcast's range both refer to the same *Client pointer. Applied to all Broadcast tests defensively. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 09:06:08 +00:00
Molecule AI Core-BE	7ebdbe102c	[core-be-agent] fix type mismatch: return sqlmock.Sqlmock (interface), not *sqlmock.Sqlmock ... sqlmock.New() returns (Sqlmock, error) where Sqlmock is the interface type, not a pointer. setupTestDB correctly returns sqlmock.Sqlmock (interface), but setupWorkspaceCrudTest and setupInstructionsTestDB incorrectly declared *sqlmock.Sqlmock (pointer to interface). In Go, *Interface is a distinct type from Interface — this would be a compile error. Root cause: copy-paste from setupWorkspaceCrudTest where the original author assumed *sqlmock.Sqlmock was the correct type. Fix: change both setup functions to return sqlmock.Sqlmock (interface) to match what sqlmock.New() actually returns. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 09:06:08 +00:00
Molecule AI Core-BE	446ef9c467	[core-be-agent] fix vet warnings: unused variables in hub_test and bundle_helpers_test ... Per QA review of PR #794: 1. hub_test.go TestNewHub_WithAccessChecker: `called` was set but never read (unused variable → go vet failure). Added assertion that checks `called` is true after verifying the access checker was invoked. 2. bundle_helpers_test.go TestSplitLines_Empty: `want` was declared as []string{""} but only len(want) was used — the actual content was never compared. Fixed to assert len(got)==1 && got[0]=="", which validates the correct split behavior for an empty string. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 09:06:08 +00:00
Molecule AI Core-BE	2e261e1b91	[core-be-agent] fix tests: routing engine + setupInstructionsTest ... Two compounding test bugs were causing CI failures in the Platform (Go) job: 1. workspace_crud_test.go: 9 Update tests still registered routes on a separate r2 := gin.New() but called r.ServeHTTP() on the original engine from setupWorkspaceCrudTest. This sent requests to r (which had no PATCH route) → 404 instead of the expected validation error. Fixed: use r consistently for both route registration and serving. 2. instructions_test.go: setupInstructionsTest() called setupTestDB() (which sets global db.DB = mockDB and returns a gin engine with it) then DISCARDED that engine and created a fresh gin.New(). Every test then created ANOTHER fresh gin.New() for route registration. So the route registration and r.ServeHTTP() happened on two completely different gin engines — requests never reached the handler at all. Fixed: introduce setupInstructionsTestDB() that returns the gin engine from setupTestDB, update all tests to use it, and drop the redundant gin.New() calls. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 09:06:08 +00:00
Molecule AI Core-BE	31e75cd9e6	[core-be-agent] fix tests: routing r2→r for delete/resolve, CascadeDelete WithArgs ... - workspace_crud_test.go: TestDelete_* tests registered routes on r2 but called r.ServeHTTP, causing unmocked DB calls. TestUpdate_WorkspaceNotFound same. TestCascadeDelete_DescendantQueryError had WithArgs(wsID) but the actual QueryContext call passes zero args (workspace ID is embedded in query string). - instructions_test.go: TestInstructionsDelete_* and TestInstructionsResolve_* had same r/r2 routing mismatch.	2026-05-13 09:06:08 +00:00
Molecule AI Core-BE	cbd5d08101	[core-be-agent] bundle: add bundle_helpers_test.go — 17 cases for pure helpers ... Tests: - splitLines: basic, trailing newline, empty, single char - extractDescription: plain text, after frontmatter, skips comments, only comments, empty, frontmatter-only - nilIfEmpty: empty→nil, non-empty→same - buildBundleConfigFiles: system prompt, config.yaml prompts, skill files, combined, empty bundle - findConfigDir: exact name match, fallback to first, no dirs→"", unreadable dir→"" No go binary in container — validated by CI.	2026-05-13 09:06:08 +00:00
Molecule AI Core-BE	9ce9931f86	[core-be-agent] fix tests: CascadeDelete mock call, instructions r2→r cleanup ... - workspace_crud_test.go: TestCascadeDelete_DescendantQueryError was setting a mock expectation but never calling CascadeDelete — sqlmock would report "expected query not executed" at test end. Now calls CascadeDelete directly with a minimal handler (nil deps are fine since the error path returns before StopWorkspace/RemoveVolume are reached). - instructions_test.go: All Create/Update tests declared r2:=gin.New() then called r2.ServeHTTP while the setup's r engine sat unused. Unified to use r consistently (the r2 declarations were already renamed to r in the prior edit pass). Also removed dead code in TestInstructionsCreate_HappyPath (r.POST routed to h.List on an unused engine).	2026-05-13 09:06:08 +00:00
Molecule AI Core-BE	379f41814a	[core-be-agent] ... ws: add hub_test.go — 13 cases for NewHub, safeSend, Broadcast, Close Covers: - NewHub: nil checker, access checker wiring - safeSend: open, closed, and full channel paths - Broadcast: canvas always-receives, workspace CanCommunicate gating, drops on closed/full, empty hub, multi-client, canvas-ignores-checker - Close: disconnects all, idempotent, closes done channel No go binary in container — validated by CI.	2026-05-13 09:06:08 +00:00
Molecule AI Core-BE	848b2d96ca	test(handlers): add org_layout_test.go — 16 cases for childSlot/sizeOfSubtree/childSlotInGrid ... Pure layout helper functions that compute canvas node positions and subtree bounding boxes. Covers leaf/branch/deep-nesting subtree sizes, uniform and variable sibling grid layouts, empty-siblings edge case, overflow index. Closes test coverage gap on org.go canvas layout helpers. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 09:06:08 +00:00
Molecule AI Core-BE	c09a5000b2	test(handlers): add workspace_crud_test.go — 20 cases for State/Update/Delete ... Covers State (legacy, auth-required, not found, soft-deleted, query error), Update (invalid UUID/body/not found, field length limits, newline/YAML-char rejection, workspace_dir validation), Delete (invalid UUID, children confirmation gate, query error), validateWorkspaceID, validateWorkspaceFields, validateWorkspaceDir helpers. Closes test coverage gap on workspace_crud.go. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 09:06:08 +00:00
Molecule AI Core-BE	14739a19c7	test(handlers): add instructions_test.go — 17 cases for InstructionsHandler ... Covers List (workspace scope, global-only, query error), Create (happy path, missing required, invalid scope, workspace without target, content/title too long, insert error), Update (happy path, partial, content/title too long, not found, update error), Delete (happy path, not found, delete error), Resolve (no instructions, global only, global+workspace, query error, missing workspace ID), and scanInstructions helper (empty rows, scan error). Fixes gap: instructions.go had zero unit test coverage. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 09:06:08 +00:00
devops-engineer	01ca22eedd	Merge pull request 'fix(ci): add labeled/unlabeled to sop-checklist-gate triggers (mc#817)' (#818) from fix/sop-gate-labeled-trigger into main	2026-05-13 08:50:36 +00:00
devops-engineer	4d63795470	Merge pull request 'fix(ci/main): sync audit-force-merge REQUIRED_CHECKS with branch protection' (#812) from sre/main-drift-fix into main	2026-05-13 08:49:29 +00:00
Molecule AI Infra-SRE	0b5ac695b1	fix(ci/main): sync audit-force-merge REQUIRED_CHECKS with branch protection ... mc#805 drift: REQUIRED_CHECKS listed Secret scan + sop-tier-check (neither enforced on main) while missing the enforced sop-checklist. Correct main branch protection requires: - CI / all-required (pull_request) - sop-checklist / all-items-acked (pull_request) Also trims verbose comments and moves permissions: into the job block to mirror sop-tier-check.yml structure. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 08:41:45 +00:00
core-devops	8e1d12e563	fix(ci): add labeled/unlabeled to sop-checklist-gate pull_request_target types ... Closes mc#817. The gate was not re-running when a tier label was added after initial PR open, leaving a stale failure status. Adding labeled/unlabeled triggers a fresh evaluation whenever tier label changes, eliminating need for manual compensating statuses.	2026-05-13 08:41:40 +00:00
devops-engineer	3db93d3d44	Merge pull request '[core-be-agent] test(handlers/bundle): add bundle_test.go — 5 cases + fix nil broadcaster panic' (#801) from feat/workspace-dispatchers-test-coverage into main	2026-05-13 08:29:41 +00:00
devops-engineer	f547ff99a2	Merge PR #813: bound Playwright browser install ... Merge via devops-engineer after SOP, QA, security, and manual workflow-only CI validation passed.	2026-05-13 08:22:14 +00:00
hongming-codex-laptop	eafb5b4ac0	fix(ci): bound Playwright browser install	2026-05-13 01:10:34 -07:00
devops-engineer	871f8f52b5	Merge pull request 'fix(lint): resolve 64 pre-existing golangci-lint violations in workspace-server' (#803) from fix/golangci-lint-preexisting-violations into main	2026-05-13 07:55:29 +00:00
devops-engineer	e2d49a56e7	Merge pull request 'fix(ci): remove || true guards from jq pipelines in audit-force-merge.sh' (#792) from ci/audit-force-merge-silent-fail-fix into main	2026-05-13 07:47:42 +00:00
devops-engineer	463afaf7d9	Merge PR #811: harden Cloudflare sweep and disable AWS janitor schedule ... Merge via devops-engineer after SOP, QA, and security gates passed.	2026-05-13 07:47:02 +00:00
devops-engineer	f06a8e76fc	Merge pull request 'fix(platform): install docker-cli-buildx in workspace-server image (mc#765 follow-up)' (#796) from fix/workspace-server-docker-cli-buildx-mc765-followup into main	2026-05-13 07:42:04 +00:00
hongming-codex-laptop	334b748492	fix(ci): harden Cloudflare sweep API errors	2026-05-13 00:35:15 -07:00
devops-engineer	cf473aac69	Merge pull request 'ci: hard-fail unfilled SOP checklist body' (#797) from fix/sop-checklist-body-hard-gate into main	2026-05-13 07:22:39 +00:00
Molecule AI Core-DevOps	a8f2c46c87	fix(ci): remove || true guards from jq pipelines in audit-force-merge.sh ... Silent-failure regression from 8c343e3a. The || true guards on jq pipelines masked parse errors and allowed empty strings to propagate into the force-merge audit event (e.g. missing title, merge_sha, or merged_by). With set -euo pipefail already in place, jq failures now propagate as hard errors — the correct behavior. Use jq's // operator for graceful defaults instead: MERGE_SHA=$(jq -r '.merge_commit_sha // empty') # exits 5 on missing field MERGED_BY=$(jq -r '.merged_by.login // "unknown"') # exits 5 on missing field Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 07:08:30 +00:00
hongming-codex-laptop	c2e462ca26	fix(lint): resolve 64 pre-existing golangci-lint violations in workspace-server ... Fixes all ineffassign (7), staticcheck (31), and unused (26) violations reported by golangci-lint in workspace-server/ so the linter gate is clean. Key changes by linter: - ineffassign: remove 7 variables assigned then immediately overwritten - QF1001 (De Morgan): rewrite 4 negated compound conditions - QF1006 (loop lift): 2 for{if break} → for !cond{} - QF1008 (embedded field): drop .Resources. from hostCfg/hc selectors (provisioner + tests) - QF1012 (Fprintf): 3 sb.WriteString(fmt.Sprintf) → fmt.Fprintf - S1009 (nil+len): remove redundant nil check before len() - S1016 (type conv): 2 struct-literal copies → direct type conversion - S1017 (TrimPrefix): 2 if+HasPrefix/slice → strings.TrimPrefix - S1023 (redundant return): remove 2 trailing returns in middleware - SA1012 (nil context): nil → context.TODO() in resolver_test - SA1019 (deprecated): ImageInspectWithRaw → ImageInspect; RetryAfter direct field - SA5011 (nil deref): t.Error → t.Fatal before dereference in client_test - ST1005 (error string): lowercase 3 error strings starting with proper nouns - ST1013 (HTTP constant): 405 literal → http.StatusMethodNotAllowed - unused: delete 26 unused consts/types/funcs/fields across 12 files All three checks pass after this commit: go build ./... → success go vet ./... → success golangci-lint run --timeout 3m ./... → 0 issues Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-12 23:47:36 -07:00
devops-engineer	3df44d9fb1	Merge PR #809: surface E2E diagnose detail ... Merge diagnostic hardening after CI and SOP gates passed.	2026-05-13 06:46:48 +00:00
hongming-codex-laptop	6656e60e5e	fix(e2e): surface terminal diagnose detail	2026-05-12 23:43:03 -07:00
devops-engineer	2c8582937c	Merge PR #793: fix CI golangci-lint root failure ... Merge protected core CI root fix after required CI and SOP gates passed.	2026-05-13 06:14:42 +00:00
hongming-codex-laptop	ad7acd30db	fix(platform): clear golangci-lint findings	2026-05-12 22:53:22 -07:00
hongming-codex-laptop	f9261212bd	fix(sop-checklist): post success (not pending) for tier:low PRs ... tier:low PRs are low-risk changes that do not require peer acks. Posting 'pending' instead of 'success' caused a deadlock when sop-checklist/all-items-acked is a BP required context — pending does not satisfy the merge gate. Change: mode=soft → state always "success", description prefix changes from "[soft-fail]" to "[info tier:low]" for clarity. Fixes internal#376 (all molecule-core/main merges blocked).	2026-05-12 22:42:46 -07:00
Molecule AI Core-BE	0d74b1fa79	[core-be-agent] fix(bundle_test): TestBundleImport_ValidJSON nil broadcaster panic ... TestBundleImport_ValidJSON passed nil broadcaster to BundleHandler. bundle.Import calls broadcaster.RecordAndBroadcast unconditionally → panic when broadcaster is nil. Fix: add setupTestDB + newTestBroadcaster + 4 ExpectExec mocks covering the INSERT workspaces / UPDATE runtime / INSERT schedules / INSERT workspace_secrets calls. Recursive sub-workspace imports are not triggered (bundle has no SubWorkspaces), and prov is nil so the provision goroutine + markFailed are not reached. Also caught: the original test never called setupTestDB, so db.DB was uninitialized (nil) and the first INSERT would have panicked with "nil pointer" before reaching the broadcaster panic.	2026-05-13 05:37:43 +00:00
Molecule AI Core-BE	da3015c72e	test(handlers/bundle): add bundle_test.go — 5 cases covering Import + Export error paths ... Covers: - BundleHandler.Import: invalid JSON (7 sub-cases) → 400 - BundleHandler.Import: valid JSON → 201 - BundleHandler.Export: workspace not found (ErrNoRows) → 404 - BundleHandler.Export: DB query error → 404 Branch: feat/workspace-dispatchers-test-coverage Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-13 05:15:28 +00:00
hongming-codex-laptop	089980790f	ci: hard-fail unfilled SOP checklist body	2026-05-12 22:15:26 -07:00
hongming-pc2	1c17f0ff73	fix(platform): install docker-cli-buildx in workspace-server image (mc#765 follow-up) ... mc#765 added `docker-cli` to the workspace-server Alpine runtime, but the Alpine package is just the CLI binary — it does NOT include the buildx plugin. Modern Docker (26.x in this image) defaults BuildKit=on, so `docker build` immediately fails with: local-build: pre-flight OK (docker=/usr/bin/docker) Provisioner: workspace start failed for <id>: local-build mode: ensure image for runtime "claude-code": local-build: docker build molecule-local/workspace-template-claude-code:<sha>: exit status 1: ERROR: BuildKit is enabled but the buildx component is missing or broken. Caught immediately after the mc#765 platform-image deploy + recreate during the sdk-lead (360d42e4-8356-441c-80cf-16fcd5d5ce03) + CP-QA (ec6cf05b-2637-4b3c-b561-b33914849aa2) recovery POST /restart calls. Pre-flight passed (docker CLI present, confirmed by the line above), but the actual `docker build` aborted on buildx-missing. The fix mirrors mc#765's shape: add the matching Alpine package (`docker-cli-buildx`, in community/, verified 0.14.0-r3 on alpine:3.20) to the apk add line in workspace-server/Dockerfile. Diff is +1 word in the apk-add line and a comment block extension that explains the BuildKit/buildx requirement. Related: mc#765 (parent fix), Task #194 / Issue #63 (local-build path).	2026-05-12 22:14:46 -07:00
Molecule AI Core-DevOps	df9df5d328	fix(ci): remove invalid YAML double-quote wrapping on golangci-lint run ... The run value '"/Users/hongming/go/bin/golangci-lint" run ...' is invalid YAML: the parser treats the double-quoted portion as the complete scalar, leaving ' run --timeout 3m ./...' as unexpected trailing content. Use a plain scalar so the shell expands $(go env GOPATH) correctly.	2026-05-12 22:11:09 -07:00
hongming-codex-laptop	dc7907a446	fix(ci): install golangci-lint in platform job	2026-05-12 21:42:03 -07:00
hongming	738e54593c	Merge pull request 'fix(platform): install docker-cli in workspace-server image — unblocks RegistryModeLocal' (#765) from infra/dockerfile-add-docker-cli-for-local-build into main	2026-05-13 04:39:13 +00:00
hongming	b331747f1c	Merge pull request 'fix(ci): fail loud on platform Go vet and lint' (#781) from harden/platform-go-lint-fail-loud into main	2026-05-13 04:31:51 +00:00
hongming	03e7a2d8a5	Merge pull request 'test(handlers): drain preflight restart goroutine' (#780) from fix/core-main-red-race-20260512 into main	2026-05-13 04:30:05 +00:00
hongming	f3b01ceefb	Merge pull request 'test curl status capture workflow lint' (#764) from chore/curl-status-lint-script into main	2026-05-13 04:29:41 +00:00
hongming-codex-laptop (Molecule AI agent)	eee83dfb94	fix(ci): fail loud on platform Go vet and lint	2026-05-12 21:14:03 -07:00
hongming-codex-laptop	381c710f8a	test(handlers): drain preflight restart goroutine	2026-05-12 21:07:40 -07:00
hongming	06af0bbeb3	Merge pull request 'test(handlers/a2a_proxy_helpers): add a2a_proxy_helpers_test.go — 20 cases for pure helpers' (#700) from feat/a2a-proxy-helpers-test-coverage into main	2026-05-13 04:05:47 +00:00
Molecule AI Core-Security	40edbd3aae	Merge main into feat/a2a-proxy-helpers-test-coverage	2026-05-12 20:43:27 -07:00
hongming	ddba57e3f6	Merge pull request 'test(handlers/socket): add socket_test.go — 6 cases for Phase 30.1/30.2 auth gate' (#699) from feat/socket-handler-test-coverage into main	2026-05-13 03:43:05 +00:00
Molecule AI Core-Security	e5069012fb	Merge commit '806bbb464ee0df5f2537815ad9509aa28b51dbae' into mm2-700	2026-05-12 20:19:30 -07:00