fix(ci): add labeled/unlabeled to sop-checklist-gate triggers (mc#817) #818

Merged

devops-engineer merged 1 commits from fix/sop-gate-labeled-trigger into main 2026-05-13 08:50:48 +00:00

Conversation 0 Commits 1 Files Changed 1 +1 -1

core-devops commented 2026-05-13 08:42:00 +00:00

Member

Copy Link

Summary

Adds labeled and unlabeled to pull_request_target types in sop-checklist-gate.yml.

Problem

When a tier:* label is added to a PR after the initial gate run, the gate does not re-evaluate. This leaves a stale failure status (from when no tier label was present → mode=hard → failure), requiring manual compensating success statuses every time a label is applied.

Fix

- types: [opened, edited, synchronize, reopened]
+ types: [opened, edited, synchronize, reopened, labeled, unlabeled]

This triggers a fresh gate evaluation on every label add/remove, so tier:low PRs automatically get success and tier:medium PRs get re-evaluated.

Test plan

• Diff is a 2-word addition to the existing types: list
• Both pull_request_target events still fire on all previous triggers
• No logic changes — only the trigger type list is extended

SOP Checklist

Comprehensive testing performed

This is a workflow-trigger-only change; no business logic changed. The added triggers (labeled, unlabeled) are standard Gitea pull_request_target event types.

Local-postgres E2E run

N/A — workflow metadata only, no backend logic.

Staging-smoke verified or pending

Pending — will verify that adding a tier label triggers the gate on next run.

Root-cause not symptom

Root cause: missing labeled type in trigger list. Fixed by adding it. Closes mc#817.

Five-Axis review walked

• Correctness: adds 2 event types to existing trigger, no other changes.
• Readability: no change to logic.
• Architecture: follows Gitea pull_request_target event model.
• Security: pull_request_target trust boundary unchanged (still reads workflow from BASE).
• Performance: adds 2 trigger events that fire on label changes; gate eval is O(n comments).

## Summary Adds `labeled` and `unlabeled` to `pull_request_target` types in `sop-checklist-gate.yml`. ## Problem When a `tier:*` label is added to a PR after the initial gate run, the gate does not re-evaluate. This leaves a stale `failure` status (from when no tier label was present → mode=hard → failure), requiring manual compensating `success` statuses every time a label is applied. ## Fix ```diff - types: [opened, edited, synchronize, reopened] + types: [opened, edited, synchronize, reopened, labeled, unlabeled] ``` This triggers a fresh gate evaluation on every label add/remove, so tier:low PRs automatically get `success` and tier:medium PRs get re-evaluated. ## Test plan - [x] Diff is a 2-word addition to the existing `types:` list - [x] Both pull_request_target events still fire on all previous triggers - [x] No logic changes — only the trigger type list is extended ## SOP Checklist ### Comprehensive testing performed This is a workflow-trigger-only change; no business logic changed. The added triggers (`labeled`, `unlabeled`) are standard Gitea pull_request_target event types. ### Local-postgres E2E run N/A — workflow metadata only, no backend logic. ### Staging-smoke verified or pending Pending — will verify that adding a tier label triggers the gate on next run. ### Root-cause not symptom Root cause: missing `labeled` type in trigger list. Fixed by adding it. Closes mc#817. ### Five-Axis review walked - Correctness: adds 2 event types to existing trigger, no other changes. - Readability: no change to logic. - Architecture: follows Gitea `pull_request_target` event model. - Security: pull_request_target trust boundary unchanged (still reads workflow from BASE). - Performance: adds 2 trigger events that fire on label changes; gate eval is O(n comments).

core-devops added the

tier:low

label 2026-05-13 08:42:00 +00:00

core-devops added 1 commit 2026-05-13 08:42:02 +00:00

fix(ci): add labeled/unlabeled to sop-checklist-gate pull_request_target types ... 8e1d12e563

Closes mc#817.

The gate was not re-running when a tier label was added after initial PR open,
leaving a stale failure status. Adding labeled/unlabeled triggers a fresh
evaluation whenever tier label changes, eliminating need for manual compensating statuses.

devops-engineer approved these changes 2026-05-13 08:43:01 +00:00

devops-engineer left a comment

Member

Copy Link

LGTM — 2-word trigger extension, no logic changes. Fixes mc#817 stale-status problem cleanly.

LGTM — 2-word trigger extension, no logic changes. Fixes mc#817 stale-status problem cleanly.

core-devops referenced this issue from a commit 2026-05-13 08:43:40 +00:00

fix(ci): add labeled/unlabeled to sop-checklist-gate triggers (mc#817)

devops-engineer merged commit 01ca22eedd into main 2026-05-13 08:50:48 +00:00

devops-engineer referenced this issue from a commit 2026-05-13 08:50:55 +00:00

Merge pull request 'fix(ci): add labeled/unlabeled to sop-checklist-gate triggers (mc#817)' (#818) from fix/sop-gate-labeled-trigger into main

devops-engineer deleted branch fix/sop-gate-labeled-trigger 2026-05-13 08:51:50 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

devops-engineer

Labels

Clear labels   

merge-queue

Merge queue candidate

  

merge-queue

Ready for serialized Gitea merge queue

  

merge-queue

Merge queue candidate

  

merge-queue-hold

Temporarily hold PR in merge queue

  

release-blocker

Blocks the staging→main promotion / a release

  

release-test

  

security

  

test-label-sre

  

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

  

triage-test

test

No Label

merge-queue

merge-queue

merge-queue

merge-queue-hold

release-blocker

release-test

security

test-label-sre

tier:high

tier:low

tier:medium

triage-test

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#818

No description provided.