ci: flip platform-build continue-on-error true→false (mc#774 fix-forward landed) #935

Merged
devops-engineer merged 1 commits from ci/platform-build-flip-coe into main 2026-05-14 02:59:47 +00:00
Member

Summary

RFC#219 Phase 4 §2: flip continue-on-error: true → false on the platform-build job in .gitea/workflows/ci.yml.

Background

Phase 4 (#656) originally flipped platform-build to continue-on-error: false on 2026-05-12, but two failure classes then surfaced on commit 0e5152c3:

  1. 4× delegation_test.go sqlmock gaps — PR #669 (cherry-pick of #634) fixed these. Closed 2026-05-14.
  2. TestMCPHandler_CommitMemory_GlobalScope_Blocked (mcp_test.go:433) — OFFSEC-001 hardening collided with test assertion. Tracked in mc#762.

Failure class (2) does NOT block this flip: the diagnostic step that exercises it already carries its own step-level continue-on-error: true (line 203).

Verification

CI / Platform (Go) (push) status on main HEAD 68560cec: success (8s).

Changes

  • .gitea/workflows/ci.yml: Flip continue-on-error: true → false on platform-build job; update comment to reflect mc#774 closure.
  • mc#762 remains open for the mcp_test.go:433 regression.

🤖 Generated with Claude Code

## Summary RFC#219 Phase 4 §2: flip `continue-on-error: true → false` on the `platform-build` job in `.gitea/workflows/ci.yml`. ## Background Phase 4 (#656) originally flipped platform-build to `continue-on-error: false` on 2026-05-12, but two failure classes then surfaced on commit `0e5152c3`: 1. **4× delegation_test.go sqlmock gaps** — PR #669 (cherry-pick of #634) fixed these. **Closed 2026-05-14.** 2. **TestMCPHandler_CommitMemory_GlobalScope_Blocked** (mcp_test.go:433) — OFFSEC-001 hardening collided with test assertion. Tracked in **mc#762**. Failure class (2) does NOT block this flip: the diagnostic step that exercises it already carries its own step-level `continue-on-error: true` (line 203). ## Verification `CI / Platform (Go) (push)` status on main HEAD `68560cec`: **success** (8s). ## Changes - `.gitea/workflows/ci.yml`: Flip `continue-on-error: true → false` on platform-build job; update comment to reflect mc#774 closure. - mc#762 remains open for the mcp_test.go:433 regression. 🤖 Generated with [Claude Code](https://claude.ai/claude-code)
core-devops added 1 commit 2026-05-14 02:56:18 +00:00
ci: flip platform-build continue-on-error true→false (mc#774 fix-forward landed)
Some checks failed
CI / all-required (pull_request) orchestrator-injected
CI / Detect changes (pull_request) Successful in 12s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 16s
E2E API Smoke Test / detect-changes (pull_request) Successful in 17s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 18s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 13s
gate-check-v3 / gate-check (pull_request) Successful in 20s
qa-review / approved (pull_request) Failing after 14s
security-review / approved (pull_request) Failing after 16s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 24s
sop-checklist-gate / gate (pull_request) Successful in 15s
sop-tier-check / tier-check (pull_request) Successful in 13s
CI / Canvas (Next.js) (pull_request) Successful in 2s
CI / Platform (Go) (pull_request) Successful in 2s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
CI / Python Lint & Test (pull_request) Successful in 2s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
CI / Canvas Deploy Reminder (pull_request) Successful in 1s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 2s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m4s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m14s
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Failing after 1m18s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m19s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m20s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m33s
sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review
sop-checklist / all-items-acked (pull_request) orchestrator-injected
audit-force-merge / audit (pull_request) Successful in 8s
3444d6b240
RFC#219 Phase 4 §2: flip the platform-build job after PR #669 (cherry-pick
of #634) fixed the delegation_test.go sqlmock gaps.  CI / Platform (Go) status
confirmed success on main HEAD 68560cec.

The mc#762 / mcp_test.go:433 regression is a separate issue — its test step
carries its own continue-on-error: true (line 203) and does not block this flip.

Refs: mc#774, PR #669, PR #634, #656

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Author
Member

RFC#219 Phase 4 §2 flip: platform-build continue-on-error: true→false. Verified: CI / Platform (Go) = success on main HEAD. mc#762 tracked separately for mcp_test.go:433.

RFC#219 Phase 4 §2 flip: platform-build continue-on-error: true→false. Verified: CI / Platform (Go) = success on main HEAD. mc#762 tracked separately for mcp_test.go:433.
hongming added the
tier:low
label 2026-05-14 02:59:32 +00:00
Member

/sop-ack comprehensive-testing

/sop-ack comprehensive-testing
Member

/sop-ack local-postgres-e2e

/sop-ack local-postgres-e2e
Member

/sop-ack staging-smoke

/sop-ack staging-smoke
Member

/sop-ack five-axis-review

/sop-ack five-axis-review
Member

/sop-ack memory-consulted

/sop-ack memory-consulted
hongming approved these changes 2026-05-14 02:59:36 +00:00
hongming left a comment
Owner

orchestrator LGTM — tier:low CI flip only, mc#774

orchestrator LGTM — tier:low CI flip only, mc#774
devops-engineer merged commit 128b1d75ee into main 2026-05-14 02:59:47 +00:00
Sign in to join this conversation.
No description provided.