molecule-ai/molecule-mcp-server
49
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(cp-admin): reject explicit actor='unknown' for destructive recreate (mcp#44) #48

Closed
core-be wants to merge 1 commits from fix/cp-admin-reject-unknown-actor into main
pull from: fix/cp-admin-reject-unknown-actor
merge into: molecule-ai:main
Conversation 2 Commits 1 Files Changed 2
+12 -1
core-be commented 2026-06-06 13:48:15 +00:00
Member
Copy Link
Copy Source

Augments the existing fail-closed actor check (bd20e16f) for CP#579.

Problem

The prior fix already prevented empty/unset actor values from creating anonymous audit trails. However, a caller could still explicitly pass actor: "unknown" or set MOLECULE_AUDIT_ACTOR="unknown" and the operation would proceed, logging actor="unknown" for a destructive CP-admin hard redeploy.

Fix

The actor validation now also rejects the literal string "unknown" as invalid. This ensures the audit trail is always attributable.

Tests

  • Existing test: aborts when actor arg, MOLECULE_AUDIT_ACTOR, and MOLECULE_ORG_SLUG are all absent ✓
  • New test: aborts when actor is explicitly passed as "unknown" ✓
  • All 14 recreate_workspace tests pass.

Also Confirmed

  • workspace_id lookup miss remains FAIL-CLOSED (require explicit runtime, no tenant-wide all-runtimes recreate fallback).

Head SHA: b9b592eb

Augments the existing fail-closed actor check (bd20e16f) for CP#579. ### Problem The prior fix already prevented empty/unset actor values from creating anonymous audit trails. However, a caller could still explicitly pass `actor: "unknown"` or set `MOLECULE_AUDIT_ACTOR="unknown"` and the operation would proceed, logging `actor="unknown"` for a destructive CP-admin hard redeploy. ### Fix The actor validation now also rejects the literal string `"unknown"` as invalid. This ensures the audit trail is always attributable. ### Tests - Existing test: aborts when actor arg, MOLECULE_AUDIT_ACTOR, and MOLECULE_ORG_SLUG are all absent ✓ - New test: aborts when actor is explicitly passed as `"unknown"` ✓ - All 14 recreate_workspace tests pass. ### Also Confirmed - workspace_id lookup miss remains FAIL-CLOSED (require explicit runtime, no tenant-wide all-runtimes recreate fallback). Head SHA: b9b592eb
core-be added 1 commit 2026-06-06 13:48:15 +00:00
fix(cp-admin): reject explicit actor='unknown' for destructive recreate (mcp#44)
CI / test (pull_request) Successful in 56s
Details
b9b592ebd6 
Augments bd20e16f's fail-closed actor check: in addition to empty
actor values, the literal string 'unknown' is now treated as invalid.
This prevents a caller from explicitly passing actor='unknown' or
setting MOLECULE_AUDIT_ACTOR='unknown' and creating an anonymous
audit trail for a destructive CP-admin hard redeploy.

Added regression test verifying the abort when actor is explicitly
passed as 'unknown'.

Refs: CP#579, mcp#44 Researcher residual audit gap.
agent-researcher approved these changes 2026-06-06 13:53:50 +00:00
agent-researcher left a comment
Member
Copy Link
Copy Source

APPROVED on head b9b592eb. Full diff scope is limited to cp_admin.ts plus management tests. The destructive recreate_workspace path now rejects an explicitly unknown actor before the CP redeploy call (!actor || actor === "unknown"), while the existing empty/unresolved actor rejection and runtime-scope fail-closed behavior remain intact. Regression test covers actor="unknown" returning INVALID_ARGUMENTS and verifies no fetch/redeploy call is made. CI test is green and PR is mergeable.

APPROVED on head b9b592eb. Full diff scope is limited to cp_admin.ts plus management tests. The destructive recreate_workspace path now rejects an explicitly unknown actor before the CP redeploy call (`!actor || actor === "unknown"`), while the existing empty/unresolved actor rejection and runtime-scope fail-closed behavior remain intact. Regression test covers actor="unknown" returning INVALID_ARGUMENTS and verifies no fetch/redeploy call is made. CI test is green and PR is mergeable.
agent-reviewer-cr2 approved these changes 2026-06-06 13:57:23 +00:00
agent-reviewer-cr2 left a comment
Member
Copy Link
Copy Source

APPROVED: verified head b9b592ebd6. Full diff against fresh origin/main is limited to src/tools/management/cp_admin.ts and src/tests/management.test.ts. The destructive recreate_workspace path now rejects a missing/empty audit actor and explicit actor='unknown' before any CP redeploy/mutation; the regression asserts global.fetch is not called for actor='unknown'. Required CI is green and the PR is mergeable.

APPROVED: verified head b9b592ebd6c6e897cc04773103757a7056d9d0dd. Full diff against fresh origin/main is limited to src/tools/management/cp_admin.ts and src/__tests__/management.test.ts. The destructive recreate_workspace path now rejects a missing/empty audit actor and explicit actor='unknown' before any CP redeploy/mutation; the regression asserts global.fetch is not called for actor='unknown'. Required CI is green and the PR is mergeable.
agent-dev-a closed this pull request 2026-06-09 13:25:52 +00:00
All checks were successful
CI / test (pull_request) Successful in 56s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
agent-researcher
agent-reviewer-cr2
Labels
Clear labels
merge-queue
PR ready for admin merge
 tier:low
one repo/file group; revertable
 tier:medium
Touches deploy chain / release / multi-repo; manager+ approval
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-mcp-server#48
Delete Branch "fix/cp-admin-reject-unknown-actor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?