molecule-ai/molecule-mcp-server
49
0
Fork 0
Code Issues 3 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

docs(mcp): update KI-007 to reflect SDK KI-009 resolution #17

Closed
sdk-dev wants to merge 2 commits from docs/sync-ki-007-kpi-009-resolution into main
pull from: docs/sync-ki-007-kpi-009-resolution
merge into: molecule-ai:main
Conversation 0 Commits 2 Files Changed 2
+13 -13
2 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CLAUDE.md
+2 -2
View File
@@ -96,7 +96,7 @@ The workflow:
### APIs Connected
The server connects to the Molecule AI platform REST API. See the platform SDK (`../molecule-sdk-python`) for the underlying API client used.
The server connects to the Molecule AI platform REST API via its own TypeScript client (`src/api.ts`). It does not use the Python SDK (`molecule-sdk-python`) — the Python SDK is for remote agents that run outside the platform; this server runs as an MCP bridge *on* the operator side.
### Environment Variables
@@ -110,7 +110,7 @@ For local development, copy `.env.example` → `.env` and fill in values.
### Postgres
Platform data lives in Postgres (source of truth). The server reads data via the platform SDK — it does not connect to Postgres directly.
Platform data lives in Postgres (source of truth). The server reads data via the platform REST API — it does not connect to Postgres directly.
## TypeScript Conventions
known-issues.md
+11 -11
View File
@@ -180,21 +180,21 @@ test documenting the known `optional().nullable()` zod-to-json-schema quirk.
## KI-007 — MCP server heartbeat tools are read-only; actual heartbeat lives in the Python SDK
**File:** `src/tools/remote_agents.ts` (heartbeat tool)
**Status:** Resolved — clarified scope
**Status:** ✅ Resolved
**Severity:** Low
### Clarification
### Resolution
The MCP server's remote-agent tools (`list_remote_agents`, `get_remote_agent_state`,
`check_remote_agent_freshness`, `get_remote_agent_setup_command`) are **read-only
queries** — they do not drive any background heartbeat loop. The actual
`run_heartbeat_loop()` that sends heartbeats from a remote agent lives in the
Python SDK (`molecule_sdk_python/molecule_agent/client.py`).
`run_heartbeat_loop()` lives in the Python SDK's `molecule_agent/client.py`
(standalone `molecule-sdk-python` repo).
The heartbeat cleanup issue (heartbeat loop continues after the controlling MCP
client disconnects) is tracked as **SDK KI-009** in `molecule-sdk-python/known-issues.md`.
### Suggested fix (SDK side)
Expose a `stop_event` parameter or `stop()` method on `RemoteAgentClient` so the
callers (MCP client, shell wrapper) can signal the loop to exit cleanly. The
Python SDK's `run_heartbeat_loop()` should check `threading.Event` or accept a
`stop_on: asyncio.Event` argument. See `molecule-sdk-python/known-issues.md`.
client disconnects) was tracked as **SDK KI-009**. It has been resolved:
`RemoteAgentClient.run_heartbeat_loop()` and `run_agent_loop()` now accept a
`stop_event: threading.Event | None` parameter. Callers signal clean shutdown by
calling `stop_event.set()` from a SIGTERM handler or another thread. The loop
checks the event at the start of each iteration (before `max_iterations`) and
exits with return value `"stopped"`. See `molecule-sdk-python`'s
`known-issues.md` (KI-009 resolved) and `molecule_agent/__init__.py` for usage.