molecule-ai/molecule-dev-department
35
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

cleanup: local-e2e-setup.sh — symlink injection optional via --with-symlink #5

Merged
claude-ceo-assistant merged 1 commits from cleanup/post-prd-setup-script into main 2026-05-08 12:35:40 +00:00
Conversation 0 Commits 1 Files Changed 1 +70 -28
claude-ceo-assistant commented 2026-05-08 12:35:26 +00:00
Owner
Copy Link

Summary

Post-PR-D cleanup: parent template's PR #6 removed the dev-lead symlink. Without this update, running local-e2e-setup.sh errored because it required a symlink the parent no longer ships.

Changes

  • Default mode: clone parent template only. No sibling clone, no symlink. The canonical local-e2e test (TestLocalE2E_ExternalDevDepartment in molecule-core#106) uses the !external resolver to fetch the dev tree at test runtime.
  • --with-symlink flag (opt-in): keeps the legacy sibling-clone + symlink layout for regression tests (TestLocalE2E_DevDepartmentExtraction + TestLocalE2E_FilesDirConsumption). Script INJECTS the symlink since parent no longer ships it post-PR #6.
  • Updated 'Run tests' guidance: !external test is the canonical e2e; symlink tests are opt-in regression coverage for the path the resolver still supports but no production template uses.

Verified locally (2026-05-08)

  • Default mode: clones parent only, layout correct.
  • --with-symlink mode: parent + dev-department + injected symlink, layout correct.
  • Full TestLocalE2E_* test suite passes against --with-symlink fixture (1.7s, all 3 tests including the new external e2e).

Refs

  • internal#77 — extraction RFC
  • molecule-ai-org-template-molecule-dev#6 — PR-D (symlink removal)
  • task #235 follow-up
## Summary Post-PR-D cleanup: parent template's PR #6 removed the `dev-lead` symlink. Without this update, running `local-e2e-setup.sh` errored because it required a symlink the parent no longer ships. ## Changes - **Default mode**: clone parent template only. No sibling clone, no symlink. The canonical local-e2e test (`TestLocalE2E_ExternalDevDepartment` in molecule-core#106) uses the `!external` resolver to fetch the dev tree at test runtime. - **`--with-symlink` flag** (opt-in): keeps the legacy sibling-clone + symlink layout for regression tests (`TestLocalE2E_DevDepartmentExtraction` + `TestLocalE2E_FilesDirConsumption`). Script INJECTS the symlink since parent no longer ships it post-PR #6. - Updated 'Run tests' guidance: `!external` test is the canonical e2e; symlink tests are opt-in regression coverage for the path the resolver still supports but no production template uses. ## Verified locally (2026-05-08) - Default mode: clones parent only, layout correct. - `--with-symlink` mode: parent + dev-department + injected symlink, layout correct. - Full `TestLocalE2E_*` test suite passes against `--with-symlink` fixture (1.7s, all 3 tests including the new external e2e). ## Refs - internal#77 — extraction RFC - molecule-ai-org-template-molecule-dev#6 — PR-D (symlink removal) - task #235 follow-up
claude-ceo-assistant added 1 commit 2026-05-08 12:35:27 +00:00 
Follow-up to molecule-ai-org-template-molecule-dev PR #6 (PR-D in the
internal#77 phasing) which removed the dev-lead symlink from the parent
template. Without this update, running the setup script errored out
because it required a symlink that the parent no longer ships.

Changes:
  - Default mode: clone parent template only. No sibling clone, no
    symlink. The canonical local-e2e test (TestLocalE2E_ExternalDevDepartment)
    uses the !external resolver to fetch the dev tree at test runtime —
    no filesystem fixture needed.
  - --with-symlink flag: keeps the legacy sibling-clone + symlink layout
    for the symlink-based regression tests
    (TestLocalE2E_DevDepartmentExtraction + TestLocalE2E_FilesDirConsumption).
    Script INJECTS the symlink (since parent no longer ships it post-PR #6).
  - Updated 'Run tests' guidance: !external test is the canonical e2e;
    symlink tests are opt-in regression coverage for the path the resolver
    still supports but no production template uses.

VERIFIED LOCALLY 2026-05-08:
  - Default mode: clone parent only, layout correct.
  - --with-symlink mode: parent + dev-department + injected symlink, layout correct.
  - Full TestLocalE2E_* test suite passes against --with-symlink fixture (1.7s).

Refs:
  internal#77 — extraction RFC
  molecule-ai/molecule-ai-org-template-molecule-dev#6 — PR-D (symlink removal)
  task #235 follow-up — finishes the cleanup the PR-D description mentioned
claude-ceo-assistant merged commit d331ef9f62 into main 2026-05-08 12:35:40 +00:00
claude-ceo-assistant deleted branch cleanup/post-prd-setup-script 2026-05-08 12:35:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-dev-department#5
No description provided.
Delete Branch "cleanup/post-prd-setup-script"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?