Molecule AI Dev Engineer B (MiniMax) ff9874e9c3 test(workspace-server): regression tests for core#2125 (http timeout + panic recovery) ...

CTO-mandated regression test for the core#2125 family
("fix(workspace-server): http client timeouts, panic recovery, and
error checks"). The fix landed in main with NO test, despite
introducing 4 production-affecting behavior changes:

  (1) http.DefaultClient → &http.Client{Timeout: 10*time.Second} in
      cmd/server/cp_config.go:refreshEnvFromCP
  (2) inline defer-recover blocks in 6 long-lived background
      goroutines (cache sweepers, rate-limit cleanup, session cache,
      A2A SSE idle watcher, terminal bridges, importer provision
      goroutine)
  (3) ctx propagation in discovery.go's queryPeerMaps (use
      QueryRowContext)
  (4) deferred tx.Rollback in workspace.go's Create handler

The CTO's spec asks for tests of the timeout and panic-recovery
facets. This PR lands:

NEW TestRefreshEnvFromCP_ClientTimeoutFiresOnSlowUpstream — proves
the 10s client.Timeout actually fires on a slow upstream. Spins up
an httptest server that delays 12s (longer than the 10s timeout);
asserts refreshEnvFromCP returns an error within 11s AND the error
mentions timeout/deadline. Without the timeout, the test would
block for 12s+ AND the function would return success — the
elapsed-time bound proves the timeout fired, not the server.
Skipped in -short mode (10s wall cost, acceptable for CI).

NEW TestRecoverPanic_RecoversFromPanicInGoroutine + the
NoopOnNormalReturn companion — proves the canonical #2125
panic-recovery pattern. The inline  blocks (duplicated across 6 call sites) were
refactored into a single  helper in
session_auth.go. The tests assert:
  - a goroutine that defers recoverPanic and then panics does NOT
    crash the test process
  - the recovered value is logged with the caller's prefix (so
    operators can grep for the specific goroutine)
  - the goroutine's deferred epilogue (e.g. close(done)) still
    runs after the panic
  - recoverPanic is a no-op on a normal return (no spurious
    'PANIC' log)

Refactor note: the other 5 goroutines that #2125 wrapped
(terminal.go × 3, a2a_proxy.go × 1, bundle/importer.go × 1,
ratelimit.go × 1, mcp_ratelimit.go × 1) still use the inline
pattern. The refactor to recoverPanic could be applied to those
in a follow-up — kept this PR focused on the test mandate. The
new recoverPanic helper is in session_auth.go (the package that
already had the most inline recover blocks) and the test in
panic_recovery_test.go covers the contract for ALL future call
sites.

Error-path coverage (CTO spec (c)) is already provided by the
existing TestRefreshEnvFromCP_NonOKPropagates (CP 500 propagates
as error) and TestRefreshEnvFromCP_RejectsOversizedValue
(oversized value rejected, no env poisoning) — no new test
needed.

Test results:
  ok  workspace-server/cmd/server                            10.016s
  ok  workspace-server/internal/middleware                    0.100s
  go vet clean.

Refs: molecule-core#2615, core#2125

Co-Authored-By: Claude <noreply@anthropic.com>

2026-06-12 02:35:38 +00:00

..

e2e-names

fix(provisioner): SSOT workspace volume naming + e2e-names CLI (SEV-2499 follow-up)

2026-06-10 15:38:35 +00:00

gen-providers

feat(providers): P2-A internal#718 — bring the provider registry to molecule-core via codegen + verify-CI (additive, zero behavior change)

2026-05-27 17:10:12 -07:00

memory-backfill

chore(go-module): #1760 rename Go module to git.moleculesai.app/molecule-ai/molecule-core/workspace-server (#1816)

2026-05-24 23:37:18 +00:00

memory-plugin-postgres

chore(go-module): #1760 rename Go module to git.moleculesai.app/molecule-ai/molecule-core/workspace-server (#1816)

2026-05-24 23:37:18 +00:00

server

test(workspace-server): regression tests for core#2125 (http timeout + panic recovery)

2026-06-12 02:35:38 +00:00

t4-contract-dump

chore(go-module): #1760 rename Go module to git.moleculesai.app/molecule-ai/molecule-core/workspace-server (#1816)

2026-05-24 23:37:18 +00:00