Files
Molecule AI Dev Engineer B (MiniMax) 33f3374070
CI / Python Lint & Test (pull_request) Successful in 5s
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Harness Replays / detect-changes (pull_request) Successful in 6s
sop-checklist / review-refire (pull_request_target) Has been skipped
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 7s
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 6s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Harness Replays / Harness Replays (pull_request) Successful in 2s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 10s
CI / Detect changes (pull_request) Successful in 14s
reserved-path-review / reserved-path-review (pull_request_target) Successful in 8s
sop-checklist / na-declarations (pull_request) N/A: (none)
E2E API Smoke Test / detect-changes (pull_request) Successful in 16s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
E2E Peer Visibility (literal MCP list_peers) / detect-changes (pull_request) Successful in 15s
sop-checklist / all-items-acked (pull_request_target) Successful in 8s
CI / Canvas (Next.js) (pull_request) Successful in 2s
E2E Chat / detect-changes (pull_request) Successful in 16s
gate-check-v3 / gate-check (pull_request_target) Failing after 12s
CI / Canvas Deploy Status (pull_request) Successful in 1s
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Has been skipped
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 19s
E2E Chat / E2E Chat (pull_request) Successful in 3s
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 5s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 19s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 31s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 36s
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Successful in 28s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m15s
CI / Platform (Go) (pull_request) Successful in 2m32s
CI / all-required (pull_request) Successful in 4s
reserved-path-review / reserved-path-review (pull_request_review) Successful in 6s
security-review / approved (pull_request_target) Approved via pull_request_review trigger
qa-review / approved (pull_request_target) Approved via pull_request_review trigger
security-review / approved (pull_request_review) Successful in 9s
qa-review / approved (pull_request_review) Successful in 10s
audit-force-merge / audit (pull_request_target) Successful in 7s
sop-checklist / all-items-acked (pull_request) Compensated by status-reaper (non-required pull_request/pull_request_review governance shadow overridden by successful pull_request_target status; see .gitea/scripts/status-reaper.py)
test(offered-models): fix tautological AmbiguousModelSkipped test (CR2 #11570)
CR2 #11570 (REQUEST_CHANGES, blocking): the prior
TestListOfferedModels_AmbiguousModelSkipped fixture put
'shared-gpt-4o' in NO provider's ref.Models list, so
ModelsForRuntime() never returned it and the handler never entered
the loop for it — the 'dErr != nil { continue }' branch was
uncovered. The test would pass even if the branch were deleted.

New fixture recipe: a runtime ref whose Name points to a provider
that is NOT in the provider catalog. ModelsForRuntime() does NOT
validate ref.Name against the catalog at runtime (that's a
parseManifest load-time check, not a runtime invariant), so it
returns the ghost-listed model. The handler calls
DeriveProvider(runtime, id, nil); step 3 cannot resolve the
ghost-ref Name to any provider, so the model falls through to
step 4; no other provider's ModelPrefixMatch regex matches; step 6
errors. The handler's 'continue' swallows the error and drops the
model. The sibling real-co-listed model survives via step 3.

Sister test (the existing TestListOfferedModels_BYOKAuthEnv) is
unaffected; the other 5 tests in this file are unaffected.

Load-bearing property: deleting 'if dErr != nil { continue }'
from offered_models.go causes 'ghost-drops' to appear in the
response (with Provider=''), which the assertion catches. The test
is no longer tautological.

Local validation:
- go test -tags=integration -run TestListOfferedModels_ -v ./internal/handlers/ — PASS 7/7 (0.020s)
- go vet -tags=integration ./internal/handlers/ — clean
- go build ./internal/handlers/ — clean

Refs: PR #2815 CR2 review #11570
Refs: PR #2815 Researcher's first round (no RC, approval)
2026-06-14 02:47:50 +00:00
..