molecule-ai/molecule-core
41
0
Fork 2
Code Issues 43 Pull Requests -2 Actions 648 Packages Projects Releases Wiki Activity

fix(handlers): write delegation_id to response_body in activity_logs INSERT #985

Closed
fullstack-engineer wants to merge 2 commits from fix/activity-logs-delegation-id-response-body into staging
pull from: fix/activity-logs-delegation-id-response-body
merge into: molecule-ai:staging
Conversation 3 Commits 2 Files Changed 2 +90 -14

2 Commits

Author SHA1 Message Date
Molecule AI Fullstack Engineer
7e92470e47 test: fix mock arg counts for 7-param delegation INSERT
Some checks failed
CI / Detect changes (pull_request) Successful in 12s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 10s
Details
security-review / approved (pull_request) Successful in 12s
Details
Harness Replays / Harness Replays (pull_request) Successful in 5s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 16s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 18s
Details
qa-review / approved (pull_request) Successful in 11s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 15s
Details
Harness Replays / detect-changes (pull_request) Successful in 5s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 4s
Details
CI / Canvas (Next.js) (pull_request) Successful in 5s
Details
CI / Canvas Deploy Reminder (pull_request) Successful in 2s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 3s
Details
CI / Python Lint & Test (pull_request) Successful in 13s
Details
sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review
Details
gate-check-v3 / gate-check (pull_request) Successful in 8s
Details
sop-checklist / all-items-acked (pull_request) Successful in 9s
Details
sop-tier-check / tier-check (pull_request) Successful in 8s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m7s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 2m8s
Details
CI / Platform (Go) (pull_request) Failing after 2m12s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m16s
Details
CI / all-required (pull_request) Successful in 3s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details 
insertDelegationRow now passes response_body as the 6th bound param and
promotes idempotency_key to 7th. The Record handler now also passes 6
params (added response_body). Several tests still mocked 5 or 6 args:

Updated WithArgs:
- TestDelegate_Success: 6→7 (added response_body AnyArg)
- TestDelegate_DBInsertFails_Still202WithWarning: 6→7 (added response_body AnyArg)
- TestDelegationRecord_InsertsActivityLogRow: 5→6 (added response_body AnyArg)
- TestDelegate_Retry: 6→7 (added response_body AnyArg, idempotency_key preserved)
- TestDelegate_IdempotentRaceUniqueViolationReturnsExisting: 6→7 (added response_body AnyArg)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-14 07:49:46 +00:00
Molecule AI Fullstack Engineer
6f8cf0c2c2 fix: write delegation_id to response_body in insertDelegationRow and Record
Some checks failed
Handlers Postgres Integration / detect-changes (pull_request) Successful in 21s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Failing after 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 22s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 22s
Details
sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m3s
Details
gate-check-v3 / gate-check (pull_request) Successful in 14s
Details
CI / Python Lint & Test (pull_request) Successful in 2s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Failing after 15s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 3s
Details
qa-review / approved (pull_request) Successful in 13s
Details
security-review / approved (pull_request) Successful in 14s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 3s
Details
CI / Canvas Deploy Reminder (pull_request) Successful in 1s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 9s
Details
sop-checklist / all-items-acked (pull_request) Successful in 14s
Details
CI / Platform (Go) (pull_request) Successful in 6s
Details
sop-tier-check / tier-check (pull_request) Successful in 12s
Details
CI / all-required (pull_request) Successful in 1s
Details
CI / Detect changes (pull_request) Successful in 21s
Details 
insertDelegationRow and the Record handler were writing delegation_id only
to request_body. The ListDelegations API query uses COALESCE over both fields
so the API still found it, but agent polling and future code paths that rely
on response_body alone would miss it.

Changes:
- insertDelegationRow: marshal respJSON and bind as $6::jsonb (7 total args)
- Record handler: marshal respJSON and bind as $6::jsonb (6 total args)

Test coverage:
- TestInsertDelegationRow_Success: explicit WithArgs with delegationIDResponseBodyMatcher
- TestInsertDelegationRow_IdempotentConflict: explicit WithArgs with 7 args
- TestInsertDelegationRow_OtherDBError: explicit WithArgs with 7 args
- TestDelegate_Success: 7 args (already had 6)
- TestDelegate_DBInsertFails_Still202WithWarning: 7 args (already had 6)
- TestDelegationRecord_InsertsActivityLogRow: 6 args (already had 5)
- TestDelegate_IdempotentRaceUniqueViolationReturnsExisting: 7 args (already had 6)

Refs: #984

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-14 07:45:00 +00:00