fix(handlers): remove duplicate test declarations — same fixes as PR #971 #983
Merged
devops-engineer
merged 1 commits from 2026-05-14 12:35:44 +00:00
fix/982-expand-posix-identifier-guard into staging
1 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
| 7c61e8315e |
fix(handlers): restore POSIX-identifier guard in expandWithEnv (closes #982)
Some checks failed
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 4s
CI / Canvas Deploy Reminder (pull_request) Successful in 3s
CI / Platform (Go) (pull_request) Failing after 3m22s
CI / all-required (pull_request) Successful in 1s
CI / Python Lint & Test (pull_request) Successful in 12s
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Harness Replays / detect-changes (pull_request) Successful in 7s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 12s
security-review / approved (pull_request) Successful in 12s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m20s
qa-review / approved (pull_request) Successful in 12s
CI / Detect changes (pull_request) Successful in 16s
Harness Replays / Harness Replays (pull_request) Successful in 5s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m31s
E2E API Smoke Test / detect-changes (pull_request) Successful in 19s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 19s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 19s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 3s
CI / Canvas (Next.js) (pull_request) Successful in 3s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m47s
gate-check-v3 / gate-check (pull_request) Successful in 5s
sop-tier-check / tier-check (pull_request) Successful in 6s
sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 7/7 — body-unfilled: root-cause, five-axis-review, no-backwards-compat, +1
audit-force-merge / audit (pull_request) Successful in 15s
PR #978 reverted the identifier-first-char guard from PR #965, causing \$5, \$100, \$1 etc. in org YAML to be replaced with empty strings. Restore the guard in expandWithEnv: non-letter/underscore first char returns the literal "$key" so that dollar-digit strings stay as-is (e.g. "Price: \$5 off" → "Price: \$5 off"). Additionally fix pre-existing duplicate test declarations blocking the build (same fixes as PR #971): - remove 4 duplicate TestHasUnresolvedVarRef_* from org_test.go (kept TestHasUnresolvedVarRef_DollarVarSyntax — unique case) - remove 5 duplicate TestWalkOrgWorkspaceNames_* from org_test.go - remove duplicate TestResolveProvisionConcurrency_Default from org_test.go - remove duplicate TestTarWalk_NestedDirs from plugins_atomic_test.go - add exec.LookPath skip guards to SSH diagnose tests (ssh-keygen/nc not present in container PATH) Closes #982. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> |
