fix(handlers): remove duplicate test declarations; skip SSH tests gracefully #961
Merged
devops-engineer
merged 1 commits from 2026-05-14 05:00:05 +00:00
fix/duplicate-test-declarations into staging
1 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
| 5106552288 |
fix(handlers): remove duplicate test declarations; skip SSH tests gracefully
Some checks failed
sop-checklist / all-items-acked (pull_request) injected
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 17s
Harness Replays / detect-changes (pull_request) Successful in 16s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 23s
gate-check-v3 / gate-check (pull_request) Successful in 24s
qa-review / approved (pull_request) Successful in 21s
security-review / approved (pull_request) Successful in 23s
CI / Detect changes (pull_request) Successful in 1m17s
Harness Replays / Harness Replays (pull_request) Successful in 11s
sop-tier-check / tier-check (pull_request) Successful in 23s
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m8s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m13s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m7s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 7s
CI / Canvas (Next.js) (pull_request) Successful in 8s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m25s
CI / Python Lint & Test (pull_request) Successful in 11s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 9s
CI / Canvas Deploy Reminder (pull_request) Successful in 4s
sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m1s
audit-force-merge / audit (pull_request) Successful in 37s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 4m55s
CI / Platform (Go) (pull_request) Failing after 8m56s
CI / all-required (pull_request) Successful in 3s
- org_test.go: removed 5 duplicate test functions that also existed in org_helpers_pure_test.go (hasUnresolvedVarRef variants) and org_helpers_walk_test.go (walkOrgWorkspaceNames variants) and plugins_atomic_tar_test.go (TestTarWalk_NestedDirs) and org_helpers_walk_test.go (TestResolveProvisionConcurrency_Default). The _pure_test.go and _walk_test.go versions use testify assertions and are more comprehensive; they take precedence. - org_helpers.go: expandWithEnv now skips $VAR keys that don't start with [a-zA-Z_], so that "cost $100" stays as-is (fixes TestExpandWithEnv_LiteralDollar in go1.25 where os.Expand handles $1 as a variable reference differently than older Go versions). - terminal_diagnose_test.go: added t.Skip when ssh-keygen/nc are not in PATH so tests degrade gracefully instead of failing with "exec: not found" in container/CI environments that lack OpenSSH. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> |
