molecule-ai/molecule-core
41
0
Fork 2
Code Issues 43 Pull Requests -2 Actions 646 Packages Projects Releases Wiki Activity

fix(canvas+handlers): Zustand selector anti-patterns + Go handler test blockers #942

Open
hongming-pc2 wants to merge 1 commits from fix/917-zustand-selector-anti-patterns into staging
pull from: fix/917-zustand-selector-anti-patterns
merge into: molecule-ai:staging
Conversation 28 Commits 1 Files Changed 15 +241 -555

1 Commits

Author SHA1 Message Date
Molecule AI Fullstack Engineer
31fe29b70e fix(canvas): resolve Zustand selector anti-patterns causing React #185 re-render loops
Some checks failed
Harness Replays / detect-changes (pull_request) Successful in 11s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 24s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 11s
Details
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 1m34s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 11s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 18s
Details
publish-runtime-autobump / pr-validate (pull_request) Successful in 34s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m32s
Details
qa-review / approved (pull_request) Successful in 10s
Details
security-review / approved (pull_request) Successful in 10s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m11s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m47s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m23s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m17s
Details
sop-tier-check / tier-check (pull_request) Successful in 31s
Details
sop-checklist-gate / gate (pull_request) Successful in 41s
Details
gate-check-v3 / gate-check (pull_request) Successful in 53s
Details
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Failing after 2m5s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 20s
Details
CI / Python Lint & Test (pull_request) Failing after 2m1s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m38s
Details
Harness Replays / Harness Replays (pull_request) Successful in 6s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 5m15s
Details
CI / Platform (Go) (pull_request) Failing after 10m5s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 3m1s
Details
CI / Canvas (Next.js) (pull_request) Failing after 15m18s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review
Details
sop-checklist / all-items-acked (pull_request) acked: 2/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +2 — body-unfilled: comprehensive-testing, local-postgres-e2
Details 
- WorkspaceNode: useHasChildren and useDescendantCount now select nodes
  stably first, then derive with useMemo to avoid new boolean/number on
  every store push (React error #185 / Zustand + React 19 Object.is).

- DropTargetBadge: targetName and childCount select nodes once, derive
  inside IIFEs to avoid new return value on every platform push.

- useCanvasViewport: provisioningCount selects nodes stably, uses useMemo
  for the filter().length derivation.

- MobileDetail / MobileChat: node selector split into stable nodes select
  + useMemo derivation of the .find() result.

- ConfigTab: preserved existing s.nodes?.find?.() pattern (test mocks
  omit nodes; the defensive optional chaining is the correct approach there).

Fixes: React error #185 (Zustand + React 19 Object.is strictness).

---

fix(handlers): resolve Go handler test blockers

- org_helpers.go: custom envVarRefPattern regexp for ${VAR}/$VAR expansion
  so $100 is left as-is (not expanded to empty) while $FOO is expanded.

- org.go: add missing collectPerWorkspaceUnsatisfied and perWorkspaceUnsatisfied
  (required by the EnvRequirements checking path in org import).

- workspace_crud_test.go: escape \$1 in sqlmock COUNT patterns (Go regex
  interprets bare $1 as end-anchor+literal-1, not a literal placeholder).

- workspace_crud.go: move workspace_dir validation before the existence check
  so invalid paths return 400 instead of 404 — consistent with name/role
  field validation ordering.

- a2a_queue.go: use float64 for expires_in_seconds JSON field; float
  values are truncated (90.7 → 90) per the documented contract.

- a2a_queue_test.go: update float-value test expectation from 0 to 30
  to match the truncation contract.

- org_helpers_pure_test.go: fix TestAppendYAMLBlock_BothEmpty (assert.Nil
  not assert.Equal("", nil)).

- plugins_atomic_test.go: remove duplicate TestTarWalk_NestedDirs.

- org_layout_test.go: delete (tests non-existent childSlot function).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-14 03:23:27 +00:00