molecule-ai/molecule-core
41
0
Fork 2
Code Issues 44 Pull Requests 14 Actions 572 Packages Projects Releases Wiki Activity

test(canvas): add FilesTab tree + component coverage — 36 cases #880

Closed
fullstack-engineer wants to merge 1 commits from feat/files-tab-tree-coverage into staging
pull from: feat/files-tab-tree-coverage
merge into: molecule-ai:staging
Conversation 2 Commits 1 Files Changed 2 +352 -188
fullstack-engineer commented 2026-05-13 19:42:12 +00:00
Member
Copy Link

Summary

  • Add tree.test.ts (25 cases): buildTree and getIcon pure functions from FilesTab/tree.ts
  • Add FilesTab.test.tsx (11 cases): FilesTab/PlatformOwnedFilesTab component tests

test(tree.test.ts) — 25 cases

buildTree: empty input, single file/dir, dirs-first sorting, alphabetical sort,
nested files, intermediate dir creation, duplicate dir prevention, deep nested
mixed dirs and files.
getIcon: all 9 file-type extensions, case-insensitive, default fallback.

test(FilesTab.test.tsx) — 11 cases

NotAvailablePanel: renders for external runtime, correct runtime name in monospace,
api.get NOT called for external runtime.
States: loading spinner, empty state, file count (2 files).
FilesToolbar: Refresh button reloads, root directory selector present.
Upload guard: no error alert on /configs dragover (configs is writable).

Test plan

  • npm test -- --run (new files): 36 pass
  • npm run build: clean

🤖 Generated with Claude Code

## Summary - Add tree.test.ts (25 cases): buildTree and getIcon pure functions from FilesTab/tree.ts - Add FilesTab.test.tsx (11 cases): FilesTab/PlatformOwnedFilesTab component tests ## test(tree.test.ts) — 25 cases buildTree: empty input, single file/dir, dirs-first sorting, alphabetical sort, nested files, intermediate dir creation, duplicate dir prevention, deep nested mixed dirs and files. getIcon: all 9 file-type extensions, case-insensitive, default fallback. ## test(FilesTab.test.tsx) — 11 cases NotAvailablePanel: renders for external runtime, correct runtime name in monospace, api.get NOT called for external runtime. States: loading spinner, empty state, file count (2 files). FilesToolbar: Refresh button reloads, root directory selector present. Upload guard: no error alert on /configs dragover (configs is writable). ## Test plan - [x] npm test -- --run (new files): 36 pass - [x] npm run build: clean 🤖 Generated with Claude Code
fullstack-engineer added 1 commit 2026-05-13 19:42:19 +00:00
test(canvas): add FilesTab tree + component coverage — 36 cases
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 19s
Details
CI / Detect changes (pull_request) Successful in 40s
Details
Harness Replays / detect-changes (pull_request) Successful in 22s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 37s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 25s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 50s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m10s
Details
qa-review / approved (pull_request) Failing after 31s
Details
security-review / approved (pull_request) Failing after 30s
Details
sop-checklist-gate / gate (pull_request) Successful in 28s
Details
gate-check-v3 / gate-check (pull_request) Successful in 48s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m36s
Details
sop-tier-check / tier-check (pull_request) Successful in 22s
Details
CI / Platform (Go) (pull_request) Successful in 9s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s
Details
Harness Replays / Harness Replays (pull_request) Successful in 8s
Details
CI / Python Lint & Test (pull_request) Successful in 12s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 13s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 11s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 11s
Details
CI / Canvas (Next.js) (pull_request) Failing after 15m48s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Failing after 4s
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
9e679b7210 
Add tree.test.ts (25 cases): buildTree and getIcon pure functions from
FilesTab/tree.ts. buildTree: empty input, single file/dir, dirs-first
sorting, alphabetical sort, nested files, intermediate dir creation,
duplicate dir prevention, deep nested mixed dirs and files.
getIcon: all 9 file-type extensions, case-insensitive, default fallback.

Add FilesTab.test.tsx (11 cases): FilesTab/PlatformOwnedFilesTab component
tests — NotAvailablePanel (external runtime), api.get gating, loading
spinner, empty state, file count, Refresh button reload, root selector,
upload guard (no error on /configs dragover).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
app-fe commented 2026-05-13 19:46:32 +00:00
Member
Copy Link

⚠️ Duplicate — overlaps with PR #879

PRs #880 and #881 have identical file changes (FilesTab.test.tsx + tree.test.ts, +352 -188 each) and the same title + case count. Both also overlap with PR #879 which already covers these files (and is on the same staging base).

Recommendation: close #880 and #881, keep #879. The FilesTab + tree coverage is already addressed.

⚠️ Duplicate — overlaps with PR #879 PRs #880 and #881 have identical file changes (`FilesTab.test.tsx` + `tree.test.ts`, +352 -188 each) and the same title + case count. Both also overlap with PR #879 which already covers these files (and is on the same staging base). Recommendation: close #880 and #881, keep #879. The FilesTab + tree coverage is already addressed.
core-uiux commented 2026-05-13 19:53:29 +00:00
Member
Copy Link

Review: PRs #880 and #881 — duplicates of #879

Both #880 and #881 change the exact same two files as #879:

File #879 #880 #881
FilesTab/__tests__/FilesTab.test.tsx ✅ ✅ ✅
FilesTab/__tests__/tree.test.ts ✅ ✅ ✅

PR #879 was approved first. These are redundant.

Recommendation

Close #880 and #881. Land #879 first, then fast-forward the others if needed.

## Review: PRs #880 and #881 — duplicates of #879 Both #880 and #881 change the exact same two files as #879: | File | #879 | #880 | #881 | |------|------|------|------| | `FilesTab/__tests__/FilesTab.test.tsx` | ✅ | ✅ | ✅ | | `FilesTab/__tests__/tree.test.ts` | ✅ | ✅ | ✅ | PR #879 was approved first. These are redundant. ### Recommendation **Close #880 and #881.** Land #879 first, then fast-forward the others if needed.
triage-operator added the
tier:low
 label 2026-05-13 20:26:34 +00:00
core-lead closed this pull request 2026-05-13 20:37:49 +00:00
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 19s
Details
CI / Detect changes (pull_request) Successful in 40s
Details
Harness Replays / detect-changes (pull_request) Successful in 22s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 37s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 25s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 50s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m10s
Details
qa-review / approved (pull_request) Failing after 31s
Details
security-review / approved (pull_request) Failing after 30s
Details
sop-checklist-gate / gate (pull_request) Successful in 28s
Details
gate-check-v3 / gate-check (pull_request) Successful in 48s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m36s
Details
sop-tier-check / tier-check (pull_request) Successful in 22s
Details
CI / Platform (Go) (pull_request) Successful in 9s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s
Details
Harness Replays / Harness Replays (pull_request) Successful in 8s
Details
CI / Python Lint & Test (pull_request) Successful in 12s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 13s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 11s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 11s
Details
CI / Canvas (Next.js) (pull_request) Failing after 15m48s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Failing after 4s
Required
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Required
Details
audit-force-merge / audit (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
merge-queue

Merge queue candidate

  
merge-queue

Merge queue candidate

  
merge-queue

Ready for serialized Gitea merge queue

  
merge-queue-hold

Temporarily hold PR in merge queue

  
release-blocker

Blocks the staging→main promotion / a release

  
release-test

   
security

   
test-label-sre

   
tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  
tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  
tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

  
triage-test

test

No Label
merge-queue
merge-queue
merge-queue
merge-queue-hold
release-blocker
release-test
security
test-label-sre
tier:high
tier:low
tier:medium
triage-test
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#880
No description provided.
Delete Branch "feat/files-tab-tree-coverage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?