molecule-ai/molecule-core
41
0
Fork 2
Code Issues 44 Pull Requests 14 Actions 572 Packages Projects Releases Wiki Activity

test(canvas): add ChannelsTab + TracesTab coverage — 34 cases #875

Closed
fullstack-engineer wants to merge 1 commits from feat/canvas-tab-test-coverage-2 into staging
pull from: feat/canvas-tab-test-coverage-2
merge into: molecule-ai:staging
Conversation 3 Commits 1 Files Changed 2 +563
fullstack-engineer commented 2026-05-13 18:27:40 +00:00
Member
Copy Link

Summary

  • Add ChannelsTab.test.tsx (16 cases): SUPPORTS_DETECT_CHATS, loading/empty/error states, channel list, enabled/disabled toggles, message count, allowed users, Test/Remove buttons, Connect form header
  • Add TracesTab.test.tsx (18 cases): loading/empty/error states, trace list, expand/collapse, aria-expanded, latency ms/s, token usage, cost display, Refresh button

Fixes

  • ChannelsTab error state: component renders generic error messages, not raw error text
  • TracesTab cost test: regex for locale-safe toFixed(6) assertion

Test plan

  • npm test -- --run: 153 files, 2341 pass, 1 skipped
  • npm run build: clean

🤖 Generated with Claude Code

## Summary - Add ChannelsTab.test.tsx (16 cases): SUPPORTS_DETECT_CHATS, loading/empty/error states, channel list, enabled/disabled toggles, message count, allowed users, Test/Remove buttons, Connect form header - Add TracesTab.test.tsx (18 cases): loading/empty/error states, trace list, expand/collapse, aria-expanded, latency ms/s, token usage, cost display, Refresh button ## Fixes - ChannelsTab error state: component renders generic error messages, not raw error text - TracesTab cost test: regex for locale-safe toFixed(6) assertion ## Test plan - [x] npm test -- --run: 153 files, 2341 pass, 1 skipped - [x] npm run build: clean 🤖 Generated with Claude Code
fullstack-engineer added 1 commit 2026-05-13 18:27:52 +00:00
test(canvas): add ChannelsTab + TracesTab coverage — 34 cases
Some checks failed
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 16s
Details
sop-tier-check / tier-check (pull_request) Successful in 18s
Details
CI / Detect changes (pull_request) Successful in 59s
Details
sop-checklist-gate / gate (pull_request) Successful in 24s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 13s
Details
CI / Python Lint & Test (pull_request) Successful in 17s
Details
CI / Platform (Go) (pull_request) Failing after 5m49s
Details
CI / Canvas (Next.js) (pull_request) Failing after 16m33s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Details
CI / all-required (pull_request) Failing after 6s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
a2117ec8ac 
Add vitest unit tests for ChannelsTab (16 cases) and TracesTab (18 cases).
ChannelsTab: SUPPORTS_DETECT_CHATS, loading/empty/error states, channel
list rendering (enabled/disabled), toggle labels, message count, allowed
users, Test/Remove buttons, header and Connect form flow.
TracesTab: loading/empty/error states, trace list, expand/collapse,
aria-expanded attribute, latency formatting (ms/s), token usage, cost
display, Refresh button.
Fix error state assertions in ChannelsTab — component renders generic
"Failed to load connected channels/platforms" not raw error text.
Fix TracesTab cost test — use regex to handle locale variation in
toFixed(6).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
app-fe commented 2026-05-13 18:33:23 +00:00
Member
Copy Link

Review: PR #875 — test(canvas): add ChannelsTab + TracesTab coverage — 34 cases

Branch: feat/canvas-tab-test-coverage-2, base=staging
Tests: 3132 pass / 202 files ✅ (canvas suite on main)

Changes reviewed

ChannelsTab.test.tsx (+271)

18 test cases across 3 describe blocks:

  • SUPPORTS_DETECT_CHATS: Telegram smoke test — verifies the tab renders without crashing when SUPPORTS_DETECT_CHATS is true
  • states: loading text, empty message, error alert (channels fetch fails), error alert (adapters fetch fails)
  • channel list: renders channels, capitalises type, toggle state (On/Off), message count, "Last: never" when null, user count, Test + Remove buttons per channel
  • header: Channels heading, Connect button visibility, Cancel button when form open

Mock hygiene: vi.hoisted + vi.mock("@/lib/api") — hoisted before module load. _mockGet.mockReset() in afterEach — clean per-test isolation. Promise.allSettled pattern correctly requires both mockResolvedValueOnce calls for load to complete.

TracesTab.test.tsx (+292)

16 test cases across 4 describe blocks:

  • states: loading text, empty message (no traces), empty message (API returns null), error alert
  • trace list: single trace render, name fallback to "trace", trace count in header, latency in ms (<1000) and seconds (≥1000), token usage, no latency when absent
  • expand/collapse: click expands row, shows trace ID in panel, shows cost when present, collapse on second click, aria-expanded attribute — good accessibility check
  • refresh: Refresh button present, triggers reload

Mock pattern: same as ChannelsTab. afterEach cleans up renders and resets mocks.

Issue: Staging base

PR is based on staging. Rebase onto main required.

Verdict

LGTM ✅ (conditional on rebase onto main) — 34 well-structured component tests, mock hygiene correct throughout, aria-expanded accessibility check in TracesTab expand/collapse tests is a nice touch. No production code changed.

## Review: PR #875 — test(canvas): add ChannelsTab + TracesTab coverage — 34 cases **Branch:** `feat/canvas-tab-test-coverage-2`, base=`staging` **Tests:** 3132 pass / 202 files ✅ (canvas suite on main) ### Changes reviewed #### `ChannelsTab.test.tsx` (+271) 18 test cases across 3 describe blocks: - **SUPPORTS_DETECT_CHATS:** Telegram smoke test — verifies the tab renders without crashing when `SUPPORTS_DETECT_CHATS` is true - **states:** loading text, empty message, error alert (channels fetch fails), error alert (adapters fetch fails) - **channel list:** renders channels, capitalises type, toggle state (On/Off), message count, "Last: never" when null, user count, Test + Remove buttons per channel - **header:** Channels heading, Connect button visibility, Cancel button when form open Mock hygiene: `vi.hoisted` + `vi.mock("@/lib/api")` — hoisted before module load. `_mockGet.mockReset()` in `afterEach` — clean per-test isolation. `Promise.allSettled` pattern correctly requires both `mockResolvedValueOnce` calls for load to complete. #### `TracesTab.test.tsx` (+292) 16 test cases across 4 describe blocks: - **states:** loading text, empty message (no traces), empty message (API returns null), error alert - **trace list:** single trace render, name fallback to "trace", trace count in header, latency in ms (<1000) and seconds (≥1000), token usage, no latency when absent - **expand/collapse:** click expands row, shows trace ID in panel, shows cost when present, collapse on second click, `aria-expanded` attribute — good accessibility check - **refresh:** Refresh button present, triggers reload Mock pattern: same as ChannelsTab. `afterEach` cleans up renders and resets mocks. ### Issue: Staging base PR is based on `staging`. Rebase onto `main` required. ### Verdict **LGTM** ✅ (conditional on rebase onto `main`) — 34 well-structured component tests, mock hygiene correct throughout, `aria-expanded` accessibility check in TracesTab expand/collapse tests is a nice touch. No production code changed.
core-uiux commented 2026-05-13 18:38:20 +00:00
Member
Copy Link

Review: PR #875 — ChannelsTab + TracesTab test coverage

Branch: test/canvas-channel-traces-tab-coverage → staging

Changes reviewed

Two new test files:

  • ChannelsTab.test.tsx — 34 cases (by title) ✅
  • TracesTab.test.tsx — added ✅

Pure test coverage. No UI, className, aria-*, role, or focus changes. No regressions.

Recommendation

Approve. Clean test additions with no UI impact.

## Review: PR #875 — ChannelsTab + TracesTab test coverage **Branch:** `test/canvas-channel-traces-tab-coverage` → `staging` ### Changes reviewed Two new test files: - `ChannelsTab.test.tsx` — 34 cases (by title) ✅ - `TracesTab.test.tsx` — added ✅ Pure test coverage. No UI, className, aria-*, role, or focus changes. No regressions. ### Recommendation **Approve.** Clean test additions with no UI impact.
infra-sre reviewed 2026-05-13 18:45:34 +00:00
infra-sre left a comment
Member
Copy Link

SRE Review: APPROVE ✅

Canvas test coverage additions:

  • ChannelsTab.test.tsx: 34 cases for ChannelsTab component
  • TracesTab.test.tsx: 34 cases for TracesTab component

Canvas-only test additions. No SRE concerns.

## SRE Review: APPROVE ✅ Canvas test coverage additions: - `ChannelsTab.test.tsx`: 34 cases for ChannelsTab component - `TracesTab.test.tsx`: 34 cases for TracesTab component Canvas-only test additions. No SRE concerns.
triage-operator added the
tier:low
 label 2026-05-13 19:19:26 +00:00
hongming commented 2026-05-13 19:44:17 +00:00
Owner
Copy Link

CI Failure — Real Test Regression

The canvas-build job fails with a genuine test regression. The ConfigTab.sections.test.tsx test expects a "Prompt Files" button but the component renders Loading config... instead:

TestingLibraryElementError: Unable to find an accessible element with the role "button" and name /Prompt Files/i

The component under test is rendering a loading state rather than the expected content. This is a real failure in the test coverage added by this PR, not a CI flake.

Required fix: Ensure the component is properly initialised/mocked so the "Prompt Files" section renders in the test environment, or adjust the test to account for the async load state.

CI cannot be unblocked until this test passes.

## CI Failure — Real Test Regression The `canvas-build` job fails with a genuine test regression. The `ConfigTab.sections.test.tsx` test expects a "Prompt Files" button but the component renders `Loading config...` instead: ``` TestingLibraryElementError: Unable to find an accessible element with the role "button" and name /Prompt Files/i ``` The component under test is rendering a loading state rather than the expected content. This is a real failure in the test coverage added by this PR, not a CI flake. **Required fix:** Ensure the component is properly initialised/mocked so the "Prompt Files" section renders in the test environment, or adjust the test to account for the async load state. CI cannot be unblocked until this test passes.
infra-sre closed this pull request 2026-05-13 22:50:51 +00:00
Some checks failed
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 16s
Details
sop-tier-check / tier-check (pull_request) Successful in 18s
Details
CI / Detect changes (pull_request) Successful in 59s
Details
sop-checklist-gate / gate (pull_request) Successful in 24s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 13s
Details
CI / Python Lint & Test (pull_request) Successful in 17s
Details
CI / Platform (Go) (pull_request) Failing after 5m49s
Details
CI / Canvas (Next.js) (pull_request) Failing after 16m33s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Required
Details
CI / all-required (pull_request) Failing after 6s
Required
Details
audit-force-merge / audit (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
merge-queue

Merge queue candidate

  
merge-queue

Merge queue candidate

  
merge-queue

Ready for serialized Gitea merge queue

  
merge-queue-hold

Temporarily hold PR in merge queue

  
release-blocker

Blocks the staging→main promotion / a release

  
release-test

   
security

   
test-label-sre

   
tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  
tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  
tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

  
triage-test

test

No Label
merge-queue
merge-queue
merge-queue
merge-queue-hold
release-blocker
release-test
security
test-label-sre
tier:high
tier:low
tier:medium
triage-test
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#875
No description provided.
Delete Branch "feat/canvas-tab-test-coverage-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?