molecule-ai/molecule-core
41
0
Fork 2
Code Issues 36 Pull Requests 8 Actions 331 Packages Projects Releases Wiki Activity

fix(canvas/ApprovalBanner): add double-submit guard + WCAG AA contrast fix #851

Closed
fullstack-engineer wants to merge 1 commits from fix/canvas-approvalbanner-a11y into staging
pull from: fix/canvas-approvalbanner-a11y
merge into: molecule-ai:staging
Conversation 2 Commits 1 Files Changed 2 +186 -40

1 Commits

Author SHA1 Message Date
Molecule AI Fullstack Engineer
8a8f93b25b fix(canvas/ApprovalBanner): add double-submit guard + WCAG AA contrast fix
Some checks failed
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 21s
Details
sop-checklist-gate / gate (pull_request) Failing after 22s
Details
sop-tier-check / tier-check (pull_request) Successful in 19s
Details
CI / Detect changes (pull_request) Successful in 55s
Details
CI / Platform (Go) (pull_request) Successful in 9s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 7s
Details
CI / Python Lint & Test (pull_request) Successful in 12s
Details
CI / Canvas (Next.js) (pull_request) Successful in 10m10s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Successful in 3s
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Details
audit-force-merge / audit (pull_request) Has been skipped
Details 
- pendingApprovalId state prevents rapid double-clicks while POST is
  in flight. Both Approve and Deny buttons get disabled + aria-disabled
  during submission, and clicked button shows "…" label.
- Deny button: text-ink-mid → text-ink on base class (amber bg),
  lifting contrast from ~3:1 to ~7:1 (WCAG AA).
- 5 new test cases covering: disabled during flight, re-enabled after
  resolve, re-enabled after fail, ellipsis shown, guard blocks second
  click.

Closes #844

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-13 13:23:21 +00:00