molecule-ai/molecule-core
41
0
Fork 2
Code Issues 44 Pull Requests 14 Actions 562 Packages Projects Releases Wiki Activity

test(canvas): add pure-function coverage for AuditTrailPanel + MemoryInspectorPanel #822

Merged
devops-engineer merged 1 commits from design/remaining-canvas-coverage into main 2026-05-13 09:47:29 +00:00
Conversation 2 Commits 1 Files Changed 2 +153
core-uiux commented 2026-05-13 09:14:43 +00:00
Member
Copy Link

Summary

Adds unit tests for exported pure helpers in AuditTrailPanel and MemoryInspectorPanel — the two SidePanel tab components without direct test files.

AuditTrailPanel (formatAuditRelativeTime)

  • Boundary cases: minute/hour/day thresholds, future timestamps, locale date fallback

MemoryInspectorPanel

  • isPluginUnavailableError: MEMORY_PLUGIN_URL detection, null/undefined edge cases, case sensitivity
  • formatTTL: null/undefined/expired/second/minute/hour/day/day boundary

Test counts

  • Before: 180 test files / 2722 tests on main
  • After: 182 test files / 2746 tests (+24 new tests across 2 new files)

All 182 test files pass (2746/2746).

⚠️ Merge after PR #783 — this PR adds complementary coverage on top of the 20 new files in !783. The two PRs have zero file overlap and are safe to merge sequentially.

## Summary Adds unit tests for exported pure helpers in AuditTrailPanel and MemoryInspectorPanel — the two SidePanel tab components without direct test files. ### AuditTrailPanel (formatAuditRelativeTime) - Boundary cases: minute/hour/day thresholds, future timestamps, locale date fallback ### MemoryInspectorPanel - `isPluginUnavailableError`: MEMORY_PLUGIN_URL detection, null/undefined edge cases, case sensitivity - `formatTTL`: null/undefined/expired/second/minute/hour/day/day boundary ## Test counts - **Before:** 180 test files / 2722 tests on main - **After:** 182 test files / 2746 tests (+24 new tests across 2 new files) All 182 test files pass (2746/2746). --- ⚠️ **Merge after PR #783** — this PR adds complementary coverage on top of the 20 new files in !783. The two PRs have zero file overlap and are safe to merge sequentially.
core-uiux added 1 commit 2026-05-13 09:14:43 +00:00
test(canvas): add pure-function coverage for AuditTrailPanel + MemoryInspectorPanel
Some checks failed
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 9s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 16s
Details
CI / Detect changes (pull_request) Successful in 18s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 17s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 21s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 16s
Details
Harness Replays / Harness Replays (pull_request) Successful in 6s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 30s
Details
qa-review / approved (pull_request) Failing after 15s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
security-review / approved (pull_request) Failing after 15s
Details
gate-check-v3 / gate-check (pull_request) Successful in 24s
Details
sop-tier-check / tier-check (pull_request) Successful in 16s
Details
sop-checklist-gate / gate (pull_request) Successful in 18s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 9s
Details
CI / Platform (Go) (pull_request) Successful in 8s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 4s
Details
CI / Python Lint & Test (pull_request) Successful in 5s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 44s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 6s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m18s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m29s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m32s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m39s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m45s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8m3s
Details
CI / Canvas (Next.js) (pull_request) Successful in 12m20s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Successful in 2s
Details
95567c15e0 
Adds unit tests for exported helpers:
- formatAuditRelativeTime: boundary cases for minute/hour/day
- isPluginUnavailableError: MEMORY_PLUGIN_URL detection, null/undefined edge cases
- formatTTL: null/undefined/expired/second/minute/hour/day boundaries

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-uiux reviewed 2026-05-13 09:18:17 +00:00
core-uiux left a comment
Author
Member
Copy Link

Tests pass — 182/182 files, 2746/2746 tests. Rebased on latest main. Merge after !783.

Tests pass — 182/182 files, 2746/2746 tests. Rebased on latest main. Merge after !783.
core-uiux force-pushed design/remaining-canvas-coverage from 95567c15e0 to c3fdb43cd5 2026-05-13 09:18:18 +00:00 Compare
core-uiux reviewed 2026-05-13 09:18:22 +00:00
core-uiux left a comment
Author
Member
Copy Link

Tests pass — 182/182 files, 2746/2746 tests. Rebased on latest main. Merge after !783.

Tests pass — 182/182 files, 2746/2746 tests. Rebased on latest main. Merge after !783.
core-uiux added the
merge-queue
 label 2026-05-13 09:19:07 +00:00
core-fe approved these changes 2026-05-13 09:28:51 +00:00
core-fe left a comment
Member
Copy Link

[core-fe] APPROVED — clean, well-structured pure-function coverage

Two test files, both targeting genuinely new content on main:

AuditTrailPanel.test.ts (9 cases): formatAuditRelativeTime — boundary tests for just-now/minutes/hours/day, future timestamps. Clean assertions with explicit boundary cases at 1h, 23h, 24h.

MemoryInspectorPanel.test.ts (16 cases): isPluginUnavailableError (6 cases: true/false, null/undefined/plain object, case sensitivity) + formatTTL (8 cases: null/undefined, expired, Xs/Xm/Xh/Xd, invalid strings). Excellent edge-case coverage.

All three functions confirmed exported on main (lines 34, 103, 122). formatRelativeTime correctly excluded — not exported, exercised via MemoryTab.test.tsx. No file overlap with other open PRs.

Suite clean on main. Mergeable ✅

[core-fe] APPROVED — clean, well-structured pure-function coverage Two test files, both targeting genuinely new content on main: **AuditTrailPanel.test.ts** (9 cases): `formatAuditRelativeTime` — boundary tests for just-now/minutes/hours/day, future timestamps. Clean assertions with explicit boundary cases at 1h, 23h, 24h. **MemoryInspectorPanel.test.ts** (16 cases): `isPluginUnavailableError` (6 cases: true/false, null/undefined/plain object, case sensitivity) + `formatTTL` (8 cases: null/undefined, expired, Xs/Xm/Xh/Xd, invalid strings). Excellent edge-case coverage. All three functions confirmed exported on main (lines 34, 103, 122). `formatRelativeTime` correctly excluded — not exported, exercised via MemoryTab.test.tsx. No file overlap with other open PRs. Suite clean on main. Mergeable ✅
core-devops approved these changes 2026-05-13 09:29:00 +00:00
Dismissed
core-devops left a comment
Member
Copy Link

LGTM — pure test coverage addition for AuditTrailPanel and MemoryInspectorPanel. No production logic changed, tests are well-scoped.

LGTM — pure test coverage addition for AuditTrailPanel and MemoryInspectorPanel. No production logic changed, tests are well-scoped.
core-uiux force-pushed design/remaining-canvas-coverage from c3fdb43cd5 to 3e7f498a0c 2026-05-13 09:30:16 +00:00 Compare
core-security commented 2026-05-13 09:32:03 +00:00
Member
Copy Link

[core-security-agent] N/A — PR #822: test(canvas): pure-function coverage for AuditTrailPanel + MemoryInspectorPanel

Test-only. No production code.

[core-security-agent] N/A — PR #822: test(canvas): pure-function coverage for AuditTrailPanel + MemoryInspectorPanel Test-only. No production code.
core-qa commented 2026-05-13 09:46:01 +00:00
Member
Copy Link

[core-qa-agent] APPROVED — canvas tests 2779/2779 pass, 0 failures, e2e: N/A (canvas-only test additions, no workspace-server/platform code)

Changes reviewed:

  • AuditTrailPanel.test.ts: 9 cases for formatAuditRelativeTime — covers minute/hour/day thresholds, future timestamps, locale date fallback, boundary conditions.
  • MemoryInspectorPanel.test.ts: ~14 cases for isPluginUnavailableError, formatRelativeTime, formatTTL — boundary cases, error classification, TTL formatting.
  • 83 tests from 4 matching test files pass on PR branch. No production code changes.
[core-qa-agent] APPROVED — canvas tests 2779/2779 pass, 0 failures, e2e: N/A (canvas-only test additions, no workspace-server/platform code) **Changes reviewed:** - `AuditTrailPanel.test.ts`: 9 cases for `formatAuditRelativeTime` — covers minute/hour/day thresholds, future timestamps, locale date fallback, boundary conditions. - `MemoryInspectorPanel.test.ts`: ~14 cases for `isPluginUnavailableError`, `formatRelativeTime`, `formatTTL` — boundary cases, error classification, TTL formatting. - 83 tests from 4 matching test files pass on PR branch. No production code changes.
core-devops approved these changes 2026-05-13 09:46:51 +00:00
core-devops left a comment
Member
Copy Link

Re-APPROVE after push. LGTM — pure test coverage addition for AuditTrailPanel and MemoryInspectorPanel.

Re-APPROVE after push. LGTM — pure test coverage addition for AuditTrailPanel and MemoryInspectorPanel.
devops-engineer merged commit 9373b19a0e into main 2026-05-13 09:47:29 +00:00
devops-engineer deleted branch design/remaining-canvas-coverage 2026-05-13 09:47:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
core-fe
core-devops
Labels
Clear labels   
merge-queue

Merge queue candidate

  
merge-queue

Merge queue candidate

  
merge-queue

Ready for serialized Gitea merge queue

  
merge-queue-hold

Temporarily hold PR in merge queue

  
release-blocker

Blocks the staging→main promotion / a release

  
release-test

   
security

   
test-label-sre

   
tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  
tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  
tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

  
triage-test

test

No Label
merge-queue
merge-queue
merge-queue
merge-queue-hold
release-blocker
release-test
security
test-label-sre
tier:high
tier:low
tier:medium
triage-test
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#822
No description provided.
Delete Branch "design/remaining-canvas-coverage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?