fix(staging): resolve 3 go vet failures #821

Merged
devops-engineer merged 2 commits from fix/staging-vet-failures into staging 2026-05-13 10:39:21 +00:00

2 Commits

Author SHA1 Message Date
bf1b4eb1f2 fix(provisioner test): remove duplicate checkShellDeps field in struct literal (vet)
Some checks failed
CI / Detect changes (pull_request) Successful in 1m26s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 22s
sop-checklist-gate / gate (pull_request) Successful in 22s
sop-tier-check / tier-check (pull_request) Successful in 20s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 7s
CI / Canvas (Next.js) (pull_request) Successful in 9s
CI / Python Lint & Test (pull_request) Successful in 8s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / Platform (Go) (pull_request) Failing after 7m57s
CI / all-required (pull_request) Successful in 5s
sop-checklist / all-items-acked (pull_request) Bootstrap exception: SOP items verified by orchestrator — tier:low test-coverage PR
audit-force-merge / audit (pull_request) Successful in 3s
2026-05-13 09:50:45 +00:00
9e153c2177 fix(staging): resolve 3 go vet failures
Three pre-existing go vet errors introduced by staging-branch divergence from main:

1. internal/bundle/importer_test.go:80 — undefined 'files' variable.
   TestBuildBundleConfigFiles_Skills creates b := &Bundle{...} but never
   calls buildBundleConfigFiles(b), leaving 'files' undefined. Added
   files := buildBundleConfigFiles(b).

2. internal/provisioner/localbuild_test.go — unknown field preflightLocalBuild.
   Struct field was renamed preflightLocalBuild -> checkShellDeps on main
   (checkShellDepsProd introduced as the replacement hook). All 4 occurrences
   of preflightLocalBuild replaced with checkShellDeps in the test file.

3. internal/handlers/org_external.go:349 — append with no values.
   cloneAndConfig := append(gitArgs(...)) is a pointless wrapper; main has
   cloneAndConfig := gitArgs(...) directly. Removed the append().

Fixes issue #820.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-13 09:50:45 +00:00