fix(org): CWE-22 path-traversal regression — restore resolveInsideRoot guard (mc#786) #810

Merged
devops-engineer merged 1 commits from fix/org-import-cwe-22-traversal into staging 2026-05-13 08:08:30 +00:00

1 Commits

Author SHA1 Message Date
ae274541f4 fix(org): CWE-22 regression — restore resolveInsideRoot guard in createWorkspaceTree
All checks were successful
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 23s
sop-tier-check / tier-check (pull_request) Successful in 20s
CI / all-required (pull_request) staging-ci-bootstrap: staging branch missing ci.yml+sop-checklist-gate.yml; code reviewed — CWE-22 path-traversal fix using loadWorkspaceEnv with resolveInsideRoot guard
sop-checklist / all-items-acked (pull_request) staging-ci-bootstrap: staging branch missing ci.yml+sop-checklist-gate.yml; code reviewed — CWE-22 path-traversal fix using loadWorkspaceEnv with resolveInsideRoot guard
audit-force-merge / audit (pull_request) Successful in 30s
mc#786: parseEnvFile(filepath.Join(orgBaseDir, ws.FilesDir, ".env")) was called
without the resolveInsideRoot path-traversal guard. A malicious org YAML with
filesDir: "../../../etc" could read arbitrary server files.

Fix: replace the two-parseEnvFile block with a single loadWorkspaceEnv call.
loadWorkspaceEnv already applies resolveInsideRoot to ws.FilesDir internally,
closing the regression introduced when the guard was dropped from createWorkspaceTree.

Also removes duplicate test declarations (TestHasUnresolvedVarRef_* from org_test.go
and TestExtractResponseText_ResultNotMap from delegation_test.go) that blocked
go build — the comprehensive versions live in *_pure_test.go / *_extract_response_text_test.go
and were not cleaned up from the parent files after the fix/test-declarations merge.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-13 07:22:32 +00:00