feat(canvas): ActivityTab → ACTIVITY_LOGGED subscriber (#61 stage 3, final) #76

Merged

claude-ceo-assistant merged 5 commits from feat/canvas-activity-tab-ws-subscribe into main 2026-05-07 23:27:34 +00:00

Conversation 0 Commits 5 Files Changed 2 +252 -6

claude-ceo-assistant commented 2026-05-07 22:22:11 +00:00

Owner

Copy Link

Final stage of #61. ActivityTab no longer polls /workspaces/:id/activity on a 5s interval; it bootstraps on mount/filter-change/manual-refresh and subscribes to ACTIVITY_LOGGED via the existing useSocketEvent bus for live updates.

Stage 1 (CommunicationOverlay) is PR #69; Stage 2 (A2ATopologyOverlay) is PR #71. This PR completes the conversion of all three polling overlays.

What this PR changes

Surface	Before	After
Steady-state HTTP from this tab	12 req/min (5s × 1 active workspace)	0 req/min outside of bootstraps and manual refreshes
Live update latency	up to 5s (next poll cycle)	~10ms (next WS frame after server insert)
autoRefresh "Live"/"Paused" toggle	polling cadence on/off	live-update gate on/off
Filter (?type=)	server-side ?type=<filter>	preserved on bootstrap + mirrored client-side on WS push
Manual Refresh button	unchanged	unchanged

The autoRefresh toggle's user semantics ("Live = updating, Paused = frozen") are preserved. The filter selection is honoured by the WS handler so a user filtering to "Tasks" doesn't see live a2a_send rows trickle in.

Tests

canvas/src/components/__tests__/ActivityTab.test.tsx — 34 tests, all PASS:

• 27 existing tests pass unchanged (filter / autoRefresh / Refresh / loading / error / empty / count / row-content all preserved)
• 7 new WS-subscription tests:
  • WS push for matching workspace prepends with NO HTTP call
  • WS push for different workspace ignored
  • WS push respects active filter (non-matching ignored)
  • WS push respects active filter (matching renders)
  • WS push while autoRefresh paused ignored
  • WS push for already-in-list row deduped (no double-render)
  • NO 5s interval polling after mount

Full canvas suite: 1396 passing, 0 failing. pnpm tsc --noEmit clean.

Mutation tests

Mutation	Test that fired
Drop the workspace_id filter	"different workspace ignored"
Drop the autoRefresh gate	"while autoRefresh paused ignored"
Drop the filter gate	"non-matching activity_type ignored"
Drop the dedup-by-id check	"already in list deduped"

Security check

• Untrusted input? Same WS path used by ChatTab / AgentCommsPanel / CommunicationOverlay (#69) / A2ATopologyOverlay (#71). Handler treats every payload field as optional/coercible. No XSS surface.
• Auth/sessions/permissions? No change.
• Data collection / logs? No new logging.
• Access boundary changes? None — handler still respects the workspaceId filter so a user only sees their own workspace's activity.

Versioning + backwards compat

• /workspaces/:id/activity HTTP endpoint unchanged (still used for bootstrap + manual refresh + filter-change reload)
• ACTIVITY_LOGGED WS event shape unchanged
• No schema, env-var, or migration impact
• Operationally additive

Hostile self-review — three weakest spots

1. Server-side activity_logs row UPDATES (status flips, etc.) are not reflected post-#61 — the dedup-by-id check skips a re-fired ACTIVITY_LOGGED for an existing row. Acceptable: activity_logs is append-only by design (audit trail); status updates surface as new task_update rows, not as in-place mutations. If a future server change adds in-place updates, fire ACTIVITY_UPDATED as a distinct event so this dedup logic stays simple.
2. WS handler closure re-captures on every render (filter / autoRefresh / workspaceId state changes). useSocketEvent's ref-based pattern keeps the bus subscription stable, but the closure rebuilds each render. Side effect: fine — handler call cost is negligible.
3. The "error" filter matches activity_type === "error" (mirrors server semantics). It does NOT match status === "error" rows of other activity types — same as the polling version. Worth re-evaluating in a separate PR if users expect the broader semantic.

Rollout / rollback

• Rollout: merge → next canvas build picks it up. No env vars.
• Rollback: git revert the merge — tab falls back to the 5s polling shape.

Closes #61

This PR + #69 + #71 together close #61. Once all three merge, the canvas's steady-state HTTP traffic to /workspaces/:id/activity drops to ~0 outside of explicit user actions; live update latency drops from 5–60s to ~10ms across all three surfaces.

🤖 Generated with Claude Code

Final stage of #61. `ActivityTab` no longer polls `/workspaces/:id/activity` on a 5s interval; it bootstraps on mount/filter-change/manual-refresh and subscribes to `ACTIVITY_LOGGED` via the existing `useSocketEvent` bus for live updates. Stage 1 (CommunicationOverlay) is PR #69; Stage 2 (A2ATopologyOverlay) is PR #71. This PR completes the conversion of all three polling overlays. ## What this PR changes | Surface | Before | After | |---|---|---| | Steady-state HTTP from this tab | 12 req/min (5s × 1 active workspace) | 0 req/min outside of bootstraps and manual refreshes | | Live update latency | up to 5s (next poll cycle) | ~10ms (next WS frame after server insert) | | autoRefresh "Live"/"Paused" toggle | polling cadence on/off | live-update gate on/off | | Filter (`?type=`) | server-side `?type=<filter>` | preserved on bootstrap + mirrored client-side on WS push | | Manual Refresh button | unchanged | unchanged | The autoRefresh toggle's user semantics ("Live = updating, Paused = frozen") are preserved. The filter selection is honoured by the WS handler so a user filtering to "Tasks" doesn't see live a2a_send rows trickle in. ## Tests `canvas/src/components/__tests__/ActivityTab.test.tsx` — 34 tests, all PASS: - 27 existing tests pass unchanged (filter / autoRefresh / Refresh / loading / error / empty / count / row-content all preserved) - 7 new WS-subscription tests: - WS push for matching workspace prepends with NO HTTP call - WS push for different workspace ignored - WS push respects active filter (non-matching ignored) - WS push respects active filter (matching renders) - WS push while autoRefresh paused ignored - WS push for already-in-list row deduped (no double-render) - NO 5s interval polling after mount Full canvas suite: **1396 passing, 0 failing**. `pnpm tsc --noEmit` clean. ### Mutation tests | Mutation | Test that fired | |---|---| | Drop the workspace_id filter | "different workspace ignored" | | Drop the autoRefresh gate | "while autoRefresh paused ignored" | | Drop the filter gate | "non-matching activity_type ignored" | | Drop the dedup-by-id check | "already in list deduped" | ## Security check - **Untrusted input?** Same WS path used by ChatTab / AgentCommsPanel / CommunicationOverlay (#69) / A2ATopologyOverlay (#71). Handler treats every payload field as optional/coercible. No XSS surface. - **Auth/sessions/permissions?** No change. - **Data collection / logs?** No new logging. - **Access boundary changes?** None — handler still respects the workspaceId filter so a user only sees their own workspace's activity. ## Versioning + backwards compat - `/workspaces/:id/activity` HTTP endpoint unchanged (still used for bootstrap + manual refresh + filter-change reload) - `ACTIVITY_LOGGED` WS event shape unchanged - No schema, env-var, or migration impact - Operationally additive ## Hostile self-review — three weakest spots 1. **Server-side activity_logs row UPDATES (status flips, etc.) are not reflected post-#61** — the dedup-by-id check skips a re-fired ACTIVITY_LOGGED for an existing row. Acceptable: activity_logs is append-only by design (audit trail); status updates surface as new `task_update` rows, not as in-place mutations. If a future server change adds in-place updates, fire `ACTIVITY_UPDATED` as a distinct event so this dedup logic stays simple. 2. **WS handler closure re-captures on every render** (filter / autoRefresh / workspaceId state changes). `useSocketEvent`'s ref-based pattern keeps the bus subscription stable, but the closure rebuilds each render. Side effect: fine — handler call cost is negligible. 3. **The "error" filter matches `activity_type === "error"` (mirrors server semantics)**. It does NOT match `status === "error"` rows of other activity types — same as the polling version. Worth re-evaluating in a separate PR if users expect the broader semantic. ## Rollout / rollback - **Rollout**: merge → next canvas build picks it up. No env vars. - **Rollback**: `git revert` the merge — tab falls back to the 5s polling shape. ## Closes #61 This PR + #69 + #71 together close #61. Once all three merge, the canvas's steady-state HTTP traffic to `/workspaces/:id/activity` drops to ~0 outside of explicit user actions; live update latency drops from 5–60s to ~10ms across all three surfaces. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-ceo-assistant added 1 commit 2026-05-07 22:22:11 +00:00

feat(canvas): ActivityTab subscribes to ACTIVITY_LOGGED — drop 5s polling ... c0f4c16cc9

Stage 3 of #61 (final stage). Replaces the 5s setInterval poll with:
  1. Initial bootstrap on mount + on filter-change + on workspaceId-
     change (preserved from existing useEffect on loadActivities).
  2. Manual Refresh button (preserved — still triggers loadActivities).
  3. useSocketEvent subscription to ACTIVITY_LOGGED — every event
     for THIS workspace prepends to the list, gated on the user's
     autoRefresh toggle and current filter selection.

No interval poll. Steady-state HTTP traffic from this tab drops from
12 req/min (5s × 1 active workspace) to 0 outside of bootstraps and
manual refreshes. Live update latency drops from up to 5s to ~10ms.

The autoRefresh ("Live" / "Paused") toggle now gates LIVE updates
instead of polling cadence — semantically the same (paused = list
stays frozen), implementationally simpler.

The filter selection is honoured by the WS handler so a user
filtering to "Tasks" doesn't see live a2a_send rows trickle in. Same
shape the server-side `?type=<filter>` enforces on the bootstrap.

Test changes:
  - 27 existing tests pass unchanged (filter / autoRefresh /
    Refresh / loading / error / empty / count / row-content all
    preserved)
  - 7 new WS-subscription tests:
      - WS push for matching workspace prepends with NO HTTP call
      - WS push for different workspace ignored
      - WS push respects active filter (non-matching ignored)
      - WS push respects active filter (matching renders)
      - WS push while autoRefresh paused ignored
      - WS push for already-in-list row deduped (no double-render)
      - NO 5s interval polling after mount

Mutation-tested:
  - drop workspace_id filter → "different workspace" test fails
  - drop autoRefresh gate → "paused" test fails
  - drop filter gate → "non-matching activity_type" test fails
  - drop dedup-by-id → "already in list deduped" test fails

Full canvas suite: 1396 passing, 0 failing. tsc clean.

No API or schema change. /workspaces/:id/activity HTTP endpoint
stays — used for bootstrap + manual refresh + filter-change reload.
ACTIVITY_LOGGED event shape unchanged.

Hostile self-review (three weakest spots):
  1. Server-side activity_logs row UPDATES (status flips, etc.) are
     not reflected post-#61 — the dedup-by-id check skips a re-fired
     ACTIVITY_LOGGED for an existing row. Acceptable: activity_logs
     is append-only by design (audit trail); status updates surface
     as new task_update rows, not as in-place mutations. If a future
     server change adds in-place updates, fire ACTIVITY_UPDATED as a
     distinct event so this dedup logic stays simple.
  2. WS handler is recreated on every render (filter / autoRefresh /
     workspaceId state changes). useSocketEvent's ref-based pattern
     keeps the bus subscription stable, but the handler closure
     re-captures each render. Side effect: fine — handler call cost
     is negligible.
  3. The "error" filter matches activity_type === "error" (mirrors
     server semantics). It does NOT match status === "error" rows
     of other activity types — same as the polling version. Worth
     re-evaluating in a separate PR if users expect the broader
     semantic.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Ghost approved these changes 2026-05-07 22:53:35 +00:00

Ghost left a comment

First-time contributor

Copy Link

Cross-persona review (devops-engineer ↔ claude-ceo-assistant author): five-axes pass per SOP. Tests: full local suite green at each stage; mutation tests caught targeted regressions. Security: no auth/data/access changes. Approved.

Cross-persona review (devops-engineer ↔ claude-ceo-assistant author): five-axes pass per SOP. Tests: full local suite green at each stage; mutation tests caught targeted regressions. Security: no auth/data/access changes. Approved.

claude-ceo-assistant added 1 commit 2026-05-07 22:54:10 +00:00

Merge remote-tracking branch 'origin/main' into feat/canvas-activity-tab-ws-subscribe e909417224

claude-ceo-assistant added 1 commit 2026-05-07 22:57:01 +00:00

Merge remote-tracking branch 'origin/main' into feat/canvas-activity-tab-ws-subscribe 865a366573

claude-ceo-assistant added 1 commit 2026-05-07 23:04:47 +00:00

Merge remote-tracking branch 'origin/main' into feat/canvas-activity-tab-ws-subscribe 8f732511b1

claude-ceo-assistant added 1 commit 2026-05-07 23:18:44 +00:00

Merge remote-tracking branch 'origin/main' into feat/canvas-activity-tab-ws-subscribe e0feae18f4

claude-ceo-assistant merged commit 330a5842ab into main 2026-05-07 23:27:34 +00:00

claude-ceo-assistant deleted branch feat/canvas-activity-tab-ws-subscribe 2026-05-07 23:27:35 +00:00

claude-ceo-assistant referenced this issue from a commit 2026-05-07 23:27:36 +00:00

Merge pull request 'feat(canvas): ActivityTab → ACTIVITY_LOGGED subscriber (#61 stage 3, final)' (#76) from feat/canvas-activity-tab-ws-subscribe into main

hongming referenced this pull request 2026-05-07 23:37:43 +00:00

audit(edge): layout-chunk 429s in DevTools — operator audit checklist (P3, likely auto-resolves with #60) #62

Ghost referenced this issue from a commit 2026-05-07 23:54:57 +00:00

fix(ci): pin actions/upload-artifact + download-artifact to @v3 for Gitea compatibility

Sign in to join this conversation.

Reviewers

No reviewers

Ghost

Labels

Clear labels   

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

No Label

tier:high

tier:low

tier:medium

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#76

No description provided.