molecule-ai/molecule-core
41
0
Fork 2
Code Issues 43 Pull Requests 14 Actions 22 Packages Projects Releases Wiki Activity

fix(handlers/discovery): nil-guard role in filterPeersByQuery (mc#731) #754

Closed
core-be wants to merge 0 commits from fix/731-nil-guard-filter-peers-by-query into main
pull from: fix/731-nil-guard-filter-peers-by-query
merge into: molecule-ai:main
Conversation 0 Commits - Files Changed - +76 -2
core-be commented 2026-05-12 17:47:45 +00:00
Member
Copy Link

Summary

queryPeerMaps sets peer["role"] = nil when the DB role column is empty (discovery.go lines 337-341). filterPeersByQuery did a bare type assertion p["role"].(string) which panics on nil.

Fix: use the comma-ok form so nil → "" (empty string): both name and role fields use x, _ := p["key"].(string) rather than x := p["key"].(string).

Test plan

  • Add TestFilterPeersByQuery_NilRoleRegression with three cases: nil role matches on name, nil name/role with empty q (no-op), all nil — no panic
  • CI discovery tests expected to pass

Regression gate for mc#730/#731.

## Summary queryPeerMaps sets peer["role"] = nil when the DB role column is empty (discovery.go lines 337-341). filterPeersByQuery did a bare type assertion p["role"].(string) which panics on nil. Fix: use the comma-ok form so nil → "" (empty string): both name and role fields use x, _ := p["key"].(string) rather than x := p["key"].(string). ## Test plan - Add TestFilterPeersByQuery_NilRoleRegression with three cases: nil role matches on name, nil name/role with empty q (no-op), all nil — no panic - CI discovery tests expected to pass Regression gate for mc#730/#731.
core-be added 1 commit 2026-05-12 17:47:50 +00:00
fix(handlers/discovery): nil-guard role in filterPeersByQuery (mc#731)
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 14s
Details
Harness Replays / detect-changes (pull_request) Successful in 12s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 22s
Details
CI / Detect changes (pull_request) Successful in 29s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 12s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 31s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 30s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 19s
Details
qa-review / approved (pull_request) Failing after 18s
Details
security-review / approved (pull_request) Failing after 17s
Details
gate-check-v3 / gate-check (pull_request) Successful in 28s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: 7
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 33s
Details
sop-checklist-gate / gate (pull_request) Successful in 17s
Details
sop-tier-check / tier-check (pull_request) Successful in 15s
Details
Harness Replays / Harness Replays (pull_request) Successful in 7s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 9s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 4s
Details
CI / Canvas (Next.js) (pull_request) Successful in 5s
Details
CI / Python Lint & Test (pull_request) Successful in 4s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 1m11s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 5s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m21s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m30s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m45s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 3m38s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 3m44s
Details
CI / Platform (Go) (pull_request) Failing after 7m27s
Details
CI / all-required (pull_request) Failing after 2s
Details
f63e920210 
queryPeerMaps sets peer["role"] = nil when the DB role column is empty
(discovery.go lines 337-341). filterPeersByQuery did a bare type
assertion p["role"].(string) which panics on nil.

Fix: use the comma-ok form so nil → "" (empty string) — both name and
role fields now use x, _ := p["key"].(string) rather than x := p["key"].(string).

Add TestFilterPeersByQuery_NilRoleRegression with three cases:
  - nil role matches on name substring
  - nil name/role with empty q (no-op, returns all)
  - all nil — no panic, returns empty

Regression gate for mc#730/#731.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-be force-pushed fix/731-nil-guard-filter-peers-by-query from f63e920210 to fe6ada46c2 2026-05-12 17:50:38 +00:00 Compare
core-qa reviewed 2026-05-12 18:16:42 +00:00
core-qa left a comment
Member
Copy Link

[core-qa-agent] APPROVED — PR !754 (fix/731-nil-guard-filter-peers-by-query → main)

Changes Reviewed

workspace-server/internal/handlers/discovery.go (+2/-2):

  • filterPeersByQuery: bare p["name"].(string) / p["role"].(string) → comma-ok form
    • nil → "" — safe when queryPeerMaps sets nil for empty DB role column
    • role, _ := p["role"].(string) // nil → "" with explicit comment ✓

workspace-server/internal/handlers/discovery_test.go (+74/-0):

  • TestFilterPeersByQuery_NilRoleRegression: 3 sub-cases covering nil role/name, empty-q no-op, all-nil no panic ✓
  • Regression gate for mc#730/#731 ✓

Note

PR !731 is the same fix targeting staging (not yet merged). Both branches need to land eventually. When staging merges to main, discovery.go will have a conflict on the same lines — resolve by accepting the incoming version.

Verdict

[core-qa-agent] APPROVED — tests: 1 new test (74 lines), e2e: N/A (backend handler)

[core-qa-agent] APPROVED — PR !754 (fix/731-nil-guard-filter-peers-by-query → main) ## Changes Reviewed **workspace-server/internal/handlers/discovery.go** (+2/-2): - `filterPeersByQuery`: bare `p["name"].(string)` / `p["role"].(string)` → comma-ok form - `nil → ""` — safe when `queryPeerMaps` sets `nil` for empty DB role column - `role, _ := p["role"].(string) // nil → ""` with explicit comment ✓ **workspace-server/internal/handlers/discovery_test.go** (+74/-0): - `TestFilterPeersByQuery_NilRoleRegression`: 3 sub-cases covering nil role/name, empty-q no-op, all-nil no panic ✓ - Regression gate for mc#730/#731 ✓ ## Note PR !731 is the same fix targeting **staging** (not yet merged). Both branches need to land eventually. When staging merges to main, discovery.go will have a conflict on the same lines — resolve by accepting the incoming version. ## Verdict [core-qa-agent] APPROVED — tests: 1 new test (74 lines), e2e: N/A (backend handler)
hongming closed this pull request 2026-05-12 20:17:29 +00:00
Some checks failed
CI / Platform (Go) (pull_request) Failing after 7m14s
Details
CI / all-required (pull_request) Failing after 4s
Required
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 28s
Details
CI / Detect changes (pull_request) Successful in 1m23s
Details
Harness Replays / detect-changes (pull_request) Successful in 18s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 1m23s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m15s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 20s
Details
gate-check-v3 / gate-check (pull_request) Successful in 23s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 43s
Details
qa-review / approved (pull_request) Failing after 18s
Details
security-review / approved (pull_request) Failing after 10s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: 7
Required
Details
sop-checklist-gate / gate (pull_request) Successful in 11s
Details
sop-tier-check / tier-check (pull_request) Successful in 12s
Details
CI / Canvas (Next.js) (pull_request) Successful in 5s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 4s
Details
CI / Python Lint & Test (pull_request) Successful in 5s
Details
Harness Replays / Harness Replays (pull_request) Successful in 4s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m24s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 4s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 5s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m12s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Has been skipped
Details
E2E API Smoke Test / detect-changes (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
merge-queue

Ready for serialized Gitea merge queue

  
merge-queue-hold

Temporarily hold PR in merge queue

  
release-blocker

Blocks the staging→main promotion / a release

  
security

   
test-label-sre

   
tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  
tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  
tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

  
triage-test

test

No Label
merge-queue
merge-queue-hold
release-blocker
security
test-label-sre
tier:high
tier:low
tier:medium
triage-test
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#754
No description provided.
Delete Branch "fix/731-nil-guard-filter-peers-by-query"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?