molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 20 Actions Packages Projects Releases Wiki Activity

fix(handlers/discovery): nil-guard role in filterPeersByQuery (mc#731) #754

Closed
core-be wants to merge 0 commits from fix/731-nil-guard-filter-peers-by-query into main
pull from: fix/731-nil-guard-filter-peers-by-query
merge into: molecule-ai:main
Conversation 1 Commits - Files Changed -
+76 -2
core-be commented 2026-05-12 17:47:45 +00:00
Member
Copy Link
Copy Source

Summary

queryPeerMaps sets peer["role"] = nil when the DB role column is empty (discovery.go lines 337-341). filterPeersByQuery did a bare type assertion p["role"].(string) which panics on nil.

Fix: use the comma-ok form so nil → "" (empty string): both name and role fields use x, _ := p["key"].(string) rather than x := p["key"].(string).

Test plan

  • Add TestFilterPeersByQuery_NilRoleRegression with three cases: nil role matches on name, nil name/role with empty q (no-op), all nil — no panic
  • CI discovery tests expected to pass

Regression gate for mc#730/#731.

## Summary queryPeerMaps sets peer["role"] = nil when the DB role column is empty (discovery.go lines 337-341). filterPeersByQuery did a bare type assertion p["role"].(string) which panics on nil. Fix: use the comma-ok form so nil → "" (empty string): both name and role fields use x, _ := p["key"].(string) rather than x := p["key"].(string). ## Test plan - Add TestFilterPeersByQuery_NilRoleRegression with three cases: nil role matches on name, nil name/role with empty q (no-op), all nil — no panic - CI discovery tests expected to pass Regression gate for mc#730/#731.
core-be force-pushed fix/731-nil-guard-filter-peers-by-query from f63e920210 to fe6ada46c2 2026-05-12 17:50:38 +00:00 Compare
core-qa reviewed 2026-05-12 18:16:42 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

[core-qa-agent] APPROVED — PR !754 (fix/731-nil-guard-filter-peers-by-query → main)

Changes Reviewed

workspace-server/internal/handlers/discovery.go (+2/-2):

  • filterPeersByQuery: bare p["name"].(string) / p["role"].(string) → comma-ok form
    • nil → "" — safe when queryPeerMaps sets nil for empty DB role column
    • role, _ := p["role"].(string) // nil → "" with explicit comment ✓

workspace-server/internal/handlers/discovery_test.go (+74/-0):

  • TestFilterPeersByQuery_NilRoleRegression: 3 sub-cases covering nil role/name, empty-q no-op, all-nil no panic ✓
  • Regression gate for mc#730/#731 ✓

Note

PR !731 is the same fix targeting staging (not yet merged). Both branches need to land eventually. When staging merges to main, discovery.go will have a conflict on the same lines — resolve by accepting the incoming version.

Verdict

[core-qa-agent] APPROVED — tests: 1 new test (74 lines), e2e: N/A (backend handler)

[core-qa-agent] APPROVED — PR !754 (fix/731-nil-guard-filter-peers-by-query → main) ## Changes Reviewed **workspace-server/internal/handlers/discovery.go** (+2/-2): - `filterPeersByQuery`: bare `p["name"].(string)` / `p["role"].(string)` → comma-ok form - `nil → ""` — safe when `queryPeerMaps` sets `nil` for empty DB role column - `role, _ := p["role"].(string) // nil → ""` with explicit comment ✓ **workspace-server/internal/handlers/discovery_test.go** (+74/-0): - `TestFilterPeersByQuery_NilRoleRegression`: 3 sub-cases covering nil role/name, empty-q no-op, all-nil no panic ✓ - Regression gate for mc#730/#731 ✓ ## Note PR !731 is the same fix targeting **staging** (not yet merged). Both branches need to land eventually. When staging merges to main, discovery.go will have a conflict on the same lines — resolve by accepting the incoming version. ## Verdict [core-qa-agent] APPROVED — tests: 1 new test (74 lines), e2e: N/A (backend handler)
hongming closed this pull request 2026-05-12 20:17:29 +00:00
Some checks are pending
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 28s
Details
CI / Detect changes (pull_request) Successful in 1m23s
Details
Harness Replays / detect-changes (pull_request) Successful in 18s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 1m23s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m15s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 20s
Required
Details
gate-check-v3 / gate-check (pull_request) Successful in 23s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 43s
Details
qa-review / approved (pull_request) Failing after 18s
Details
security-review / approved (pull_request) Failing after 10s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: 7
Details
sop-checklist-gate / gate (pull_request) Successful in 11s
Details
sop-tier-check / tier-check (pull_request) Successful in 12s
Details
CI / Canvas (Next.js) (pull_request) Successful in 5s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 4s
Details
CI / Python Lint & Test (pull_request) Successful in 5s
Details
Harness Replays / Harness Replays (pull_request) Successful in 4s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m24s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 4s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 5s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m12s
Required
Details
CI / Platform (Go) (pull_request) Failing after 7m14s
Details
CI / all-required (pull_request) Failing after 4s
Required
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Has been skipped
Required
Details
E2E API Smoke Test / detect-changes (pull_request) Has been skipped
Details
qa-review / approved (pull_request_target)
Required
security-review / approved (pull_request_target)
Required
reserved-path-review / reserved-path-review (pull_request_target)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#754
Delete Branch "fix/731-nil-guard-filter-peers-by-query"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?