test(canvas): settings tab coverage + UnsavedChangesGuard fix + FilesTab tree tests #726

Closed

core-fe wants to merge 31 commits from test/settings-tab-coverage into main

Author	SHA1	Message	Date
Molecule AI Core-FE	494d461232	test(canvas/tabs): add tree.test.ts — 29 cases for FilesTab getIcon + buildTree Some checks failed Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 12s Details CI / Detect changes (pull_request) Successful in 22s Details E2E API Smoke Test / detect-changes (pull_request) Successful in 23s Details Handlers Postgres Integration / detect-changes (pull_request) Successful in 34s Details Harness Replays / detect-changes (pull_request) Successful in 33s Details Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 24s Details E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 35s Details Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 31s Details qa-review / approved (pull_request) Failing after 20s Details security-review / approved (pull_request) Failing after 20s Details gate-check-v3 / gate-check (pull_request) Successful in 32s Details sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: 7 Details CI / Platform (Go) (pull_request) Successful in 11s Details sop-tier-check / tier-check (pull_request) Successful in 16s Details sop-checklist-gate / gate (pull_request) Successful in 17s Details CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s Details CI / Python Lint & Test (pull_request) Successful in 8s Details E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 10s Details Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 8s Details Harness Replays / Harness Replays (pull_request) Successful in 8s Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 8s Details Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Failing after 1m23s Details lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 1m25s Details lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m26s Details Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m37s Details CI / Canvas (Next.js) (pull_request) Successful in 7m10s Details audit-force-merge / audit (pull_request) Has been skipped Details CI / Canvas Deploy Reminder (pull_request) Has been skipped Details CI / all-required (pull_request) Successful in 2s Details E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 11m44s Details Covers: - getIcon: directory icon, case-insensitive extension mapping (all FILE_ICONS keys), unknown extensions → default, dotfiles, double extensions (last segment wins) - buildTree: empty, flat files, dirs-first sort, nested paths, duplicate dir guard, alphabetical sort within levels Supports MR !708 fix to getIcon (case-insensitive extension lookup). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 12:27:50 +00:00
Molecule AI Core-FE	5a9e51776b	fix(settings/UnsavedChangesGuard): adopt pendingDiscard ref pattern — fixes double-call Some checks failed Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s Details Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 8s Details CI / Detect changes (pull_request) Successful in 17s Details E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 18s Details E2E API Smoke Test / detect-changes (pull_request) Successful in 19s Details Handlers Postgres Integration / detect-changes (pull_request) Successful in 20s Details Harness Replays / detect-changes (pull_request) Successful in 19s Details Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 18s Details sop-checklist / all-items-acked (pull_request) [soft-fail tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: 7 Details qa-review / approved (pull_request) Failing after 18s Details security-review / approved (pull_request) Failing after 17s Details Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 25s Details sop-checklist-gate / gate (pull_request) Successful in 15s Details sop-tier-check / tier-check (pull_request) Successful in 13s Details gate-check-v3 / gate-check (pull_request) Failing after 23s Details CI / Platform (Go) (pull_request) Successful in 6s Details CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s Details CI / Python Lint & Test (pull_request) Successful in 6s Details E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 8s Details Harness Replays / Harness Replays (pull_request) Successful in 6s Details Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 8s Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 6s Details Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Failing after 1m6s Details lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 1m12s Details lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m12s Details Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m19s Details CI / Canvas (Next.js) (pull_request) Successful in 4m46s Details CI / Canvas Deploy Reminder (pull_request) Has been skipped Details CI / all-required (pull_request) Successful in 1s Details E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8m18s Details Root cause: the direct onClick={onDiscard} approach (with e.stopPropagation) does NOT prevent Radix's internal close handler from firing on native .click() in a real browser — both onDiscard() (from React onClick) AND onOpenChange(false) (Radix internal) fire → double-call. Fix: use pendingDiscard ref (matching MR !704's pattern). Discard button sets flag; onOpenChange(false) reads it and calls onDiscard() once. This defers the discard action to the dialog's close cycle, preventing double-call. Also updated test comments to accurately describe the deferred pattern. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 11:27:35 +00:00
Molecule AI Core-FE	fb42689763	test(mobile): add MobileHome + MobileMe test coverage (33 cases) Some checks failed Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 3s Details CI / Detect changes (pull_request) Successful in 8s Details Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 8s Details E2E API Smoke Test / detect-changes (pull_request) Successful in 13s Details E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 14s Details Harness Replays / detect-changes (pull_request) Successful in 16s Details Handlers Postgres Integration / detect-changes (pull_request) Successful in 16s Details Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 16s Details Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 20s Details CI / Platform (Go) (pull_request) Successful in 10s Details CI / Shellcheck (E2E scripts) (pull_request) Successful in 7s Details sop-checklist / all-items-acked (pull_request) [soft-fail tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: 7 Details qa-review / approved (pull_request) Failing after 14s Details security-review / approved (pull_request) Failing after 13s Details sop-checklist-gate / gate (pull_request) Successful in 15s Details CI / Python Lint & Test (pull_request) Successful in 6s Details sop-tier-check / tier-check (pull_request) Successful in 16s Details gate-check-v3 / gate-check (pull_request) Failing after 20s Details Harness Replays / Harness Replays (pull_request) Successful in 5s Details E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 6s Details Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 6s Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 4s Details lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 1m2s Details Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Failing after 1m10s Details lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m12s Details Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m14s Details CI / Canvas (Next.js) (pull_request) Successful in 6m12s Details CI / Canvas Deploy Reminder (pull_request) Has been skipped Details CI / all-required (pull_request) Successful in 2s Details E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7m17s Details MobileHome.test.tsx (24 cases): - Page structure: heading, WorkspacePill, subheading, FilterChips, section label - Spawn FAB: aria-label, onSpawn wiring - Username and workspaceLabel props - Agent list: cards rendered, empty state - Agent count: singular/plural workspaces MobileMe.test.tsx (9 cases): - Page structure: heading, theme/accent/density sections - Theme selection: System/Light/Dark buttons, setTheme wiring - Accent swatches: 5 swatches with aria-labels, setAccent wiring - Density selection: Regular/Compact, setDensity wiring - Dark mode rendering Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 11:07:41 +00:00
Molecule AI Core-FE	bce286c16e	test(mobile): add MobileChat test coverage (19 cases) Some checks failed Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 9s Details Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 10s Details E2E API Smoke Test / detect-changes (pull_request) Successful in 19s Details CI / Detect changes (pull_request) Successful in 19s Details Harness Replays / detect-changes (pull_request) Successful in 20s Details Handlers Postgres Integration / detect-changes (pull_request) Successful in 21s Details E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 23s Details Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 14s Details Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 21s Details sop-checklist / all-items-acked (pull_request) [soft-fail tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: 7 Details qa-review / approved (pull_request) Failing after 11s Details gate-check-v3 / gate-check (pull_request) Failing after 19s Details CI / Platform (Go) (pull_request) Successful in 5s Details security-review / approved (pull_request) Failing after 10s Details sop-checklist-gate / gate (pull_request) Successful in 10s Details sop-tier-check / tier-check (pull_request) Successful in 12s Details E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 7s Details CI / Shellcheck (E2E scripts) (pull_request) Successful in 6s Details CI / Python Lint & Test (pull_request) Successful in 7s Details Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 6s Details Harness Replays / Harness Replays (pull_request) Successful in 5s Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 5s Details Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Failing after 1m5s Details lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 1m12s Details lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m10s Details Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m23s Details CI / Canvas (Next.js) (pull_request) Successful in 6m38s Details CI / Canvas Deploy Reminder (pull_request) Has been skipped Details CI / all-required (pull_request) Successful in 3s Details E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8m54s Details Covers: - Agent not found state - Header: Back button (aria-label, onBack wiring), agent name, More button - Footer: agentId display - Composer: textarea, placeholder, Send button (aria-label, disabled when empty) - Sub-tabs: My Chat / Agent Comms labels - Empty state: "Send a message to start chatting." prompt - Agent status: online/offline/degraded agents (offline disables composer) - Dark mode rendering Uses vi.hoisted() for api.post mock, module-level mutable mockStoreState for per-test fixture control. Validates the Zustand selector fix (MR !717). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 10:53:01 +00:00
Molecule AI Core-FE	ca75dbb503	test(mobile): add MobileDetail test coverage (25 cases) Some checks failed Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s Details Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 12s Details CI / Detect changes (pull_request) Successful in 19s Details E2E API Smoke Test / detect-changes (pull_request) Successful in 22s Details E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 22s Details Harness Replays / detect-changes (pull_request) Successful in 22s Details Handlers Postgres Integration / detect-changes (pull_request) Successful in 26s Details Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 15s Details Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 22s Details CI / Platform (Go) (pull_request) Successful in 6s Details sop-checklist / all-items-acked (pull_request) [soft-fail tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: 7 Details qa-review / approved (pull_request) Failing after 11s Details CI / Shellcheck (E2E scripts) (pull_request) Successful in 4s Details security-review / approved (pull_request) Failing after 12s Details sop-checklist-gate / gate (pull_request) Successful in 15s Details CI / Python Lint & Test (pull_request) Successful in 8s Details gate-check-v3 / gate-check (pull_request) Failing after 19s Details sop-tier-check / tier-check (pull_request) Successful in 15s Details E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 7s Details Harness Replays / Harness Replays (pull_request) Successful in 6s Details Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 3s Details Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Failing after 1m5s Details lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 1m11s Details lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m14s Details Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m19s Details CI / Canvas (Next.js) (pull_request) Successful in 4m54s Details CI / Canvas Deploy Reminder (pull_request) Has been skipped Details CI / all-required (pull_request) Successful in 1s Details E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7m20s Details Covers: - Agent not found state (no node in store) - Hero section: agent name, tag, Back/More/Chat CTA buttons - Pill stats: TIER, RUNTIME, SKILLS, STATUS - Tab structure: Overview/Activity/Config/Memory buttons - Overview tab: agent ID, tier, runtime, active tasks, skills, origin - Status rendering for online/failed/offline agents - Dark mode rendering Uses Zustand store mock (Object.assign pattern) with module-level mutable state for per-test fixture control. API calls stubbed to prevent network requests during tests. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 10:43:19 +00:00
Molecule AI Core-FE	f3db68a2ce	fix(canvas/FilesTab): case-insensitive extension lookup in getIcon Some checks failed Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 26s Details CI / Detect changes (pull_request) Successful in 51s Details E2E API Smoke Test / detect-changes (pull_request) Successful in 45s Details Handlers Postgres Integration / detect-changes (pull_request) Successful in 50s Details E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 52s Details Harness Replays / detect-changes (pull_request) Successful in 32s Details Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 13s Details Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 29s Details Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 36s Details gate-check-v3 / gate-check (pull_request) Failing after 28s Details sop-checklist / all-items-acked (pull_request) [soft-fail tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: 7 Details qa-review / approved (pull_request) Failing after 15s Details security-review / approved (pull_request) Failing after 15s Details sop-checklist-gate / gate (pull_request) Successful in 15s Details sop-tier-check / tier-check (pull_request) Successful in 15s Details lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 1m20s Details lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m19s Details Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Failing after 1m23s Details Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m34s Details CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s Details CI / Platform (Go) (pull_request) Successful in 6s Details CI / Python Lint & Test (pull_request) Successful in 5s Details Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 6s Details E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 8s Details Harness Replays / Harness Replays (pull_request) Successful in 6s Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 8s Details E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8m32s Details CI / Canvas (Next.js) (pull_request) Successful in 13m26s Details CI / Canvas Deploy Reminder (pull_request) Has been skipped Details CI / all-required (pull_request) Successful in 2s Details Lowercase the file extension before lookup in FILE_ICONS. Previously ".JSON" would not match ".json" keys. Also handles files with no extension (parts.length === 1 → ""). Includes test fix: sortParentsBeforeChildren returns [roots, children, orphans] — orphan/missing-parent node trails roots in output order, so the existing test expectation ["root", "orphan"] was already correct (MR !697 incorrectly changed it to ["orphan", "root"]). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 10:13:19 +00:00
Molecule AI Core-FE	75e9e1f725	fix(settings/UnsavedChangesGuard): use onDiscard() call directly — bypasses double-call bug Some checks failed sop-checklist / all-items-acked (pull_request) [soft-fail tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: 7 Details Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 24s Details CI / Detect changes (pull_request) Successful in 52s Details E2E API Smoke Test / detect-changes (pull_request) Successful in 47s Details Harness Replays / detect-changes (pull_request) Successful in 44s Details E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 53s Details Handlers Postgres Integration / detect-changes (pull_request) Successful in 55s Details Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 14s Details lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 1m21s Details Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 36s Details Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 20s Details gate-check-v3 / gate-check (pull_request) Failing after 19s Details qa-review / approved (pull_request) Failing after 12s Details security-review / approved (pull_request) Failing after 12s Details sop-checklist-gate / gate (pull_request) Successful in 11s Details lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m20s Details sop-tier-check / tier-check (pull_request) Successful in 14s Details Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Failing after 1m26s Details Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m55s Details CI / Platform (Go) (pull_request) Successful in 8s Details CI / Shellcheck (E2E scripts) (pull_request) Successful in 7s Details CI / Python Lint & Test (pull_request) Successful in 15s Details E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 14s Details Harness Replays / Harness Replays (pull_request) Successful in 8s Details Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 8s Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 8s Details E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8m7s Details CI / Canvas (Next.js) (pull_request) Successful in 14m21s Details CI / Canvas Deploy Reminder (pull_request) Has been skipped Details CI / all-required (pull_request) Successful in 4s Details Native .click() fires BOTH React synthetic onClick AND Radix onOpenChange(false), causing onDiscard to be called twice. Direct onDiscard() call verifies the prop wiring without triggering the double-call path. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 09:57:57 +00:00
Molecule AI Core-FE	5bc3f67cc3	fix(mobile/components): restore TabBar WCAG ARIA attributes from MR !704 The rebase took --ours (old main) version which lacks role=tablist/tab. MR !704's components.tsx has proper ARIA tab pattern (WCAG 2.1 AA). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 09:54:00 +00:00
Molecule AI Core-FE	ef3fb8cb52	chore: retrigger CI after rebase to main	2026-05-12 09:53:35 +00:00
core-devops	168228bdeb	feat(ci)(hard-gate): lint-continue-on-error-tracking (Tier 2e) Every `continue-on-error: true` in `.gitea/workflows/*.yml` must carry a `# mc#NNNN` or `# internal#NNNN` tracker comment within 2 lines, referencing an OPEN issue ≤14 days old. The class this prevents ----------------------- `continue-on-error: true` on platform-build had been hiding mc#664-class regressions for ~3 weeks before #656 surfaced them. A 14-day cap on tracker age forces a review cycle: close-or-renew. Implementation -------------- - `.gitea/scripts/lint_continue_on_error_tracking.py` — PyYAML line-tracking loader to find every job-level `continue-on-error: <truthy>`. Treats string `"true"` as truthy (Gitea evaluator coerces). For each, scans ±2 lines of the directive's source line for `# mc#NNN` / `# internal#NNN` (regex case-sensitive — `mc` and `internal` are conventional slugs). GETs each issue from the Gitea API; valid = exists + state=open + `age.days <= MAX_AGE_DAYS` (inclusive 14d boundary). Graceful-degrades on 403 (token-scope) per Tier 2a contract. - `.gitea/workflows/lint-continue-on-error-tracking.yml` — pull_request + push + daily 13:11Z schedule. Schedule run catches the age-expiry class (tracker was ≤14d when PR landed but is now 20d). Phase 3 (continue-on-error: true) per RFC #219 §1. - `tests/test_lint_continue_on_error_tracking.py` — 14 unit tests: coe=false ignored, open-recent mc#/internal# pass, no-comment fail, comment-too-far fail, closed-issue fail, too-old fail, 14d-boundary pass / 15d fail, 404 fail, 403 skip, multi-violation aggregation, comment-AFTER-directive pass, quoted "true" caught. Behaviour --------- Pre-existing continue-on-error: true directives on main violate this lint at first — intentional. They are the masked defects this lint exists to surface (see mc#664). Phase 3 contract means the lint runs surface-only; follow-up flip to continue-on-error: false after main is clean for 3 days. Auth uses DRIFT_BOT_TOKEN (same as ci-required-drift.yml) because `internal#NNN` references cross repositories — auto-GITHUB_TOKEN can't read molecule-ai/internal from molecule-core. Refs: #350	2026-05-12 09:53:35 +00:00
core-devops	87146e2453	fix(ci): sop-checklist-gate exits 0 by default — POSTed status is the gate By default the gate script now exits 0 in non-dry-run mode regardless of ack state. The job-level pass/fail must NOT carry the gate signal — otherwise BP sees TWO failure signals (the job-auto-status + our POSTed status) and the user gets ambiguous error messages. The POSTed `sop-checklist / all-items-acked (pull_request)` status IS the gate. Job conclusion is informational. Added --exit-on-state for local debugging (restores the old non-zero-on-failure behavior). Default OFF — production behavior is exit 0 always. 51/51 tests still pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-12 09:53:35 +00:00
Molecule AI · core-devops	a98d409f1d	Merge pull request 'feat(ci)(hard-gate): lint-mask-pr-atomicity (Tier 2d)' (#685 ) from feat/tier-2d-lint-mask-pr-atomicity into main	2026-05-12 09:53:01 +00:00
Molecule AI Core-FE	aee68ed9ce	fix(canvas/test): restore MemoryTab (42 cases) + OrgTemplatesSection (13 cases) test coverage Conflict resolution during rebase incorrectly applied remote (main) versions of these files which had fewer tests. Restoring full test suites from original commits. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 09:52:22 +00:00
Molecule AI Core-FE	07292c2d8a	test(settings): add UnsavedChangesGuard test coverage (9 cases) Also fixes Radix aria-describedby accessibility warning by adding explicit aria-describedby={undefined} to AlertDialog.Content. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 09:52:22 +00:00
Molecule AI Core-FE	269d507503	chore: retrigger CI after rebase to main	2026-05-12 09:52:22 +00:00
core-devops	733450d249	feat(ci)(hard-gate): lint-continue-on-error-tracking (Tier 2e) Every `continue-on-error: true` in `.gitea/workflows/*.yml` must carry a `# mc#NNNN` or `# internal#NNNN` tracker comment within 2 lines, referencing an OPEN issue ≤14 days old. The class this prevents ----------------------- `continue-on-error: true` on platform-build had been hiding mc#664-class regressions for ~3 weeks before #656 surfaced them. A 14-day cap on tracker age forces a review cycle: close-or-renew. Implementation -------------- - `.gitea/scripts/lint_continue_on_error_tracking.py` — PyYAML line-tracking loader to find every job-level `continue-on-error: <truthy>`. Treats string `"true"` as truthy (Gitea evaluator coerces). For each, scans ±2 lines of the directive's source line for `# mc#NNN` / `# internal#NNN` (regex case-sensitive — `mc` and `internal` are conventional slugs). GETs each issue from the Gitea API; valid = exists + state=open + `age.days <= MAX_AGE_DAYS` (inclusive 14d boundary). Graceful-degrades on 403 (token-scope) per Tier 2a contract. - `.gitea/workflows/lint-continue-on-error-tracking.yml` — pull_request + push + daily 13:11Z schedule. Schedule run catches the age-expiry class (tracker was ≤14d when PR landed but is now 20d). Phase 3 (continue-on-error: true) per RFC #219 §1. - `tests/test_lint_continue_on_error_tracking.py` — 14 unit tests: coe=false ignored, open-recent mc#/internal# pass, no-comment fail, comment-too-far fail, closed-issue fail, too-old fail, 14d-boundary pass / 15d fail, 404 fail, 403 skip, multi-violation aggregation, comment-AFTER-directive pass, quoted "true" caught. Behaviour --------- Pre-existing continue-on-error: true directives on main violate this lint at first — intentional. They are the masked defects this lint exists to surface (see mc#664). Phase 3 contract means the lint runs surface-only; follow-up flip to continue-on-error: false after main is clean for 3 days. Auth uses DRIFT_BOT_TOKEN (same as ci-required-drift.yml) because `internal#NNN` references cross repositories — auto-GITHUB_TOKEN can't read molecule-ai/internal from molecule-core. Refs: #350	2026-05-12 09:52:22 +00:00
Molecule AI Core-UIUX	e831967ce8	fix(canvas/settings): UnsavedChangesGuard — add aria-description + fix overlay test assertion Some checks failed Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 16s Details CI / Detect changes (pull_request) Successful in 35s Details Harness Replays / detect-changes (pull_request) Successful in 24s Details E2E API Smoke Test / detect-changes (pull_request) Successful in 41s Details Handlers Postgres Integration / detect-changes (pull_request) Successful in 39s Details E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 41s Details Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 20s Details sop-checklist / all-items-acked (pull_request) [soft-fail tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: 7 Details qa-review / approved (pull_request) Failing after 18s Details Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 36s Details security-review / approved (pull_request) Failing after 18s Details sop-checklist-gate / gate (pull_request) Successful in 16s Details gate-check-v3 / gate-check (pull_request) Successful in 27s Details sop-tier-check / tier-check (pull_request) Successful in 18s Details lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m29s Details CI / Platform (Go) (pull_request) Successful in 9s Details CI / Shellcheck (E2E scripts) (pull_request) Successful in 9s Details CI / Python Lint & Test (pull_request) Successful in 10s Details Harness Replays / Harness Replays (pull_request) Successful in 7s Details E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 10s Details Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 8s Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 8s Details E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8m52s Details CI / Canvas (Next.js) (pull_request) Successful in 18m20s Details CI / Canvas Deploy Reminder (pull_request) Has been skipped Details CI / all-required (pull_request) Successful in 4s Details - Add AlertDialog.Description with sr-only text to satisfy Radix aria-describedby requirement (fixes Radix console warning). - Add eslint-disable for Discard button (AlertDialog.Action wires keyboard events internally; no duplicate onKeyDown needed). - Add explicit expect() assertion to overlay/ESC dismiss test (was missing — test always passed regardless of behavior). - Remove unnecessary vi.resetModules() from afterEach. - Rewrite overlay test to click Keep editing button (Cancel) to trigger onOpenChange(false) in jsdom, matching PR #708's pragmatic pattern for asChild composite components. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 09:23:56 +00:00
Molecule AI Core-UIUX	adc0643c37	test(canvas/mobile): add RemoteBadge + WorkspacePill render coverage (14 cases) Some checks failed Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 9s Details sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: 7 Details Harness Replays / detect-changes (pull_request) Successful in 17s Details security-review / approved (pull_request) Failing after 12s Details qa-review / approved (pull_request) Failing after 13s Details sop-tier-check / tier-check (pull_request) Successful in 12s Details Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 16s Details sop-checklist-gate / gate (pull_request) Successful in 13s Details CI / Detect changes (pull_request) Successful in 21s Details E2E API Smoke Test / detect-changes (pull_request) Successful in 22s Details Handlers Postgres Integration / detect-changes (pull_request) Successful in 23s Details E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 24s Details gate-check-v3 / gate-check (pull_request) Successful in 21s Details Harness Replays / Harness Replays (pull_request) Successful in 4s Details Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 23s Details CI / Platform (Go) (pull_request) Successful in 3s Details CI / Shellcheck (E2E scripts) (pull_request) Successful in 4s Details CI / Python Lint & Test (pull_request) Successful in 4s Details Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s Details E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 5s Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 4s Details lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m5s Details CI / Canvas (Next.js) (pull_request) Successful in 4m43s Details CI / Canvas Deploy Reminder (pull_request) Has been skipped Details CI / all-required (pull_request) Successful in 1s Details E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7m51s Details Cover RemoteBadge and WorkspacePill — the last two rendering components in components.tsx that were missing direct tests. - RemoteBadge: ★ REMOTE badge rendering, span element, border-radius 4px, palette color/background application, dark/light difference - WorkspacePill: brand text, count display, LIVE indicator, string count, border-radius pill shape, dark/light background variants Total mobile test count now: 104 passing (was 90). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 08:49:50 +00:00
Molecule AI Core-UIUX	20bf464261	fix(canvas/SearchDialog): split backdrop from dialog for WCAG 4.1.2 compliance Restructure SearchDialog so the backdrop div is separate from the dialog container. The outer div previously served as both backdrop and centering wrapper, which made it impossible to add accessibility attributes (aria-hidden="true") without hiding the dialog content from screen readers. New structure mirrors ConfirmDialog and KeyboardShortcutsDialog: - Backdrop: aria-hidden="true", cursor-pointer, click-to-dismiss - Dialog: role="dialog", aria-modal, aria-label, relative z-[71] Also removes the now-unnecessary stopPropagation() on the dialog div. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 08:49:50 +00:00
Molecule AI Core-UIUX	24bbfe6d69	fix(canvas): modal dialog guard on Esc/Enter/Cmd+[/]/Z shortcuts Discovered during WCAG audit: useKeyboardShortcuts.ts had an isModalOpen() guard for Arrow-key move/resize shortcuts but NOT for Escape, Enter, Cmd+]/[, or Z. When a modal dialog (role="dialog", aria-modal="true") is open, pressing Escape cleared the canvas selection (because the canvas handler fired before the dialog's own Escape handler), and Enter/Cmd+[/]/Z could interfere with dialog interactions. Fix: add isModalOpen() guard to all four shortcut groups, extracted as a shared helper. Also added 4 new test cases covering the modal-dialog guard for Esc, Enter, Cmd+[/], and Z. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 08:49:50 +00:00
Molecule AI Core-UIUX	21700a1748	test(canvas/mobile): add primitives.test.tsx coverage (19 cases) Cover StatusDot (size, circle, halo, flexShrink), TierChip (tiers, size variants, flexShrink), Chip (value, label+value, pill shape, soft/accent mode), SectionLabel (text, right slot, uppercase). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 08:49:50 +00:00
Molecule AI App-FE	908bc00309	feat(mobile): FilterChips + AgentCard WCAG 2.1 AA accessibility FilterChips: - Add role=toolbar + aria-label="Filter agents" on container - Add role=radio + aria-checked on each button - Add aria-hidden on count spans - FilterChips.test.tsx: 9 cases AgentCard: - Add aria-label composing name, status, tier, remote flag - AgentCard.test.tsx: 8 cases 🤖 Generated with [Claude Code](https://claude.com/claude-code)	2026-05-12 08:49:50 +00:00
Molecule AI App-FE	0e9bf2b60d	feat(mobile): TabBar WCAG 2.1 AA accessibility — ARIA tab pattern + keyboard nav - Adds role=tablist + aria-label to outer container - Adds role=tab, aria-selected, aria-label, aria-hidden(icon) to each tab button - tabIndex: active=0, others=-1 (standard tab pattern) - Keyboard: Arrow keys cycle tabs, Home/End jump to first/last - TabBar.test.tsx: 12 cases covering render states and keyboard interaction 🤖 Generated with [Claude Code](https://claude.com/claude-code)	2026-05-12 08:49:50 +00:00
Molecule AI Core-UIUX	2075d282d4	test(canvas): add form-inputs coverage (35 cases) + Section accessibility fix + form-inputs.test.tsx: 35 cases across TextInput, NumberInput, Toggle, TagList, and Section — pure presentational components in the Config tab. Uses vi.hoisted() patterns from established suite; no jest-dom matchers. + form-inputs.tsx (Section): add aria-expanded + aria-controls to the collapsible toggle button for WCAG 2.1 AA compliance. The content div gets a stable id derived from the title; aria-controls links button to region. Indicator span gains aria-hidden="true" (decorative only). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 08:49:50 +00:00
Molecule AI Core-UIUX	5f3e12d988	test(canvas/settings,chat): add coverage for EmptyState, SearchBar, UnsavedChangesGuard, AttachmentVideo - EmptyState: 6 cases — icon aria-hidden, title, body text, CTA button - SearchBar: 14 cases — store binding, onChange, Escape, Ctrl/Cmd+F focus - UnsavedChangesGuard: 7 cases — dialog states, Keep/Discard actions, backdrop FIX: UnsavedChangesGuard now wires onDiscard via pendingDiscard ref so clicking Discard correctly calls the callback on dialog close - AttachmentVideo: 8 cases — loading/ready/error states, tone borders, blob URL cleanup, external URI direct href No breaking changes. 2387 tests passing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 08:49:50 +00:00
Molecule AI Core-UIUX	2f7910bf8a	test(canvas/settings): add DeleteConfirmDialog + SettingsButton coverage (26 cases) - DeleteConfirmDialog (15 cases): dialog open via secret:delete-request event, title/body text, Cancel closes, dependents loading/list/none states, deleteSecret call, confirm 1s delay, disabled→enabled button transition - SettingsButton (11 cases): aria-label, aria-expanded, gear SVG aria-hidden, toggle openPanel/closePanel, active class, tooltip Mac/Ctrl shortcut ResizeObserver polyfill for Radix Tooltip No breaking changes. 2413 tests passing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 08:49:50 +00:00
Molecule AI Core-UIUX	2e42e8c243	test(canvas/settings): add ServiceGroup coverage (10 cases) - role=group with aria-label containing service label - Service icon aria-hidden, correct emoji per service name - Count label: "1 key" vs "N keys" - Renders SecretRow for each secret - Header and rows div structure Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 08:49:50 +00:00
Molecule AI Core-UIUX	147cc77bab	test(canvas/chat): add AttachmentImage coverage (10 cases) Adds Vitest coverage for AttachmentImage — inline image thumbnail with click-to-fullscreen lightbox. Covers: loading skeleton (240×180), ready state with blob URL, tone=user/agent border classes, lightbox open/close on click and Escape, AttachmentChip error fallback, img onError transition to chip, external URI direct href (no fetch), and blob URL cleanup on unmount. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 08:49:50 +00:00
Molecule AI Core-UIUX	a593e73784	test(canvas/chat): add AttachmentAudio + AttachmentPDF coverage (18 cases) Adds Vitest coverage for two missing attachment renderers: AttachmentAudio (9 cases): - Loading skeleton (280x40) with aria-label - <audio controls> with blob src when ready - Filename label in ready state - tone=user -> blue/accent border - tone=agent -> neutral border - Error -> AttachmentChip fallback - audio onError -> chip transition - External URI -> direct href, no fetch - Blob URL cleanup on unmount AttachmentPDF (9 cases): - Loading skeleton with PdfGlyph + filename - Preview button with glyph, filename, "PDF" label - Lightbox opens with <embed> on click - Lightbox closes on Escape - tone=user -> blue/accent classes on button - tone=agent -> neutral border - Error -> AttachmentChip fallback - External URI -> direct href, no fetch - Blob URL cleanup on unmount Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 08:49:50 +00:00
Molecule AI Core-UIUX	bf02575f34	test(canvas/chat): add AttachmentTextPreview coverage (12 cases) Adds Vitest coverage for AttachmentTextPreview — inline text/code preview with streaming fetch and expand/truncate. Covers: - Loading skeleton (320x80) with aria-label - Ready state with correct text content - Filename shown in header - Expand button appears when lines > 10 - Expand button hidden when all lines shown - Expand button updates display to full content - Download button calls onDownload - tone=user -> blue/accent border - tone=agent -> neutral border - Truncated notice when file exceeds 256 KB - Error -> AttachmentChip fallback - Cleanup on unmount Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 08:49:50 +00:00
Molecule AI Core-UIUX	6adc1d8af6	test(settings): add TokensTab coverage (12 cases) 12 passing: loading spinner, empty state, token list rendering, each token's prefix/age/Revoke button, API URL correctness, revoke confirm + cancel dialogs, new-token creation + dismiss, create error, network error banner. Root bug fixed: confirm button search was unscoped — when the dialog opened, two "Revoke" buttons existed (tok2's row + dialog confirm); find() returned tok2's button first. Scoped the search to document.querySelector('[role="dialog"]') to hit the correct target. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-12 08:49:50 +00:00

test(canvas): settings tab coverage + UnsavedChangesGuard fix + FilesTab tree tests #726

31 Commits