test(handlers/socket): add socket_test.go — 6 cases for Phase 30.1/30.2 auth gate #699

Open
core-be wants to merge 1 commits from feat/socket-handler-test-coverage into main

1 Commits

Author SHA1 Message Date
a55f8c36c8 test(handlers/socket): add socket_test.go — 6 cases covering Phase 30.1/30.2 auth gate
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 18s
CI / Detect changes (pull_request) Successful in 48s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 47s
E2E API Smoke Test / detect-changes (pull_request) Successful in 37s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 48s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 20s
qa-review / approved (pull_request) Failing after 24s
security-review / approved (pull_request) Failing after 22s
sop-checklist / all-items-acked (pull_request) [soft-fail tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: 7
sop-checklist-gate / gate (pull_request) Successful in 27s
gate-check-v3 / gate-check (pull_request) Successful in 46s
sop-tier-check / tier-check (pull_request) Successful in 22s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m32s
CI / Canvas (Next.js) (pull_request) Successful in 13s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s
CI / Python Lint & Test (pull_request) Successful in 10s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 14s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 6m16s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 7m45s
CI / Platform (Go) (pull_request) Failing after 14m42s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Failing after 8s
HandleConnect has two branches:
1. Canvas clients (no X-Workspace-ID): auth gate bypassed entirely
2. Workspace agents (X-Workspace-ID present): Phase 30.1/30.2 bearer
   token enforcement — HasAnyLiveToken gates ValidateToken.

6 cases:
- DB error on HasAnyLiveToken → 500
- hasLive=true, no Bearer header → 401
- hasLive=true, invalid Bearer → 401
- hasLive=true, empty Bearer → 401 (ValidateToken ErrInvalidToken)
- hasLive=true, valid Bearer → auth passed (upgrade fails in httptest;
  verified by absence of 401/500)
- canvas client (no X-Workspace-ID) → auth bypassed

WebSocket upgrade itself not testable in httptest; covered by the
auth-pass cases which verify the upgrade is reached without returning
an auth error.
2026-05-12 09:24:07 +00:00