molecule-ai/molecule-core
41
0
Fork 2
Code Issues 51 Pull Requests 21 Actions 10 Packages Projects Releases Wiki Activity

feat(scripts): harden JSON parameter construction in ssm_refresh_ecr_auth (mc#676) #678

Closed
core-devops wants to merge 1 commits from infra/676-ssm-auth-json-hardening into main
pull from: infra/676-ssm-auth-json-hardening
merge into: molecule-ai:main
Conversation 4 Commits 1 Files Changed 2 +799

1 Commits

Author SHA1 Message Date
Molecule AI Core-DevOps
6a08eaa9c2 feat(scripts): harden JSON parameter construction in ssm_refresh_ecr_auth (mc#676)
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 5s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 9s
Details
sop-checklist / all-items-acked (pull_request) [soft-fail tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: 7
Details
CI / Detect changes (pull_request) Successful in 15s
Details
sop-checklist-gate / gate (pull_request) Successful in 10s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 18s
Details
qa-review / approved (pull_request) Failing after 15s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 18s
Details
security-review / approved (pull_request) Failing after 15s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 19s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 22s
Details
sop-tier-check / tier-check (pull_request) Successful in 16s
Details
gate-check-v3 / gate-check (pull_request) Failing after 23s
Details
CI / Platform (Go) (pull_request) Successful in 7s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6s
Details
CI / Python Lint & Test (pull_request) Successful in 5s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 5s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 7s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 8s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 11s
Details
CI / all-required (pull_request) Successful in 1s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 35s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m6s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details 
Five-Axis review of #672 flagged that REGION and ECR_ACCOUNT_ID are
interpolated into a JSON payload for SSM send-command without validation.
A malicious value (e.g. containing " or \) could break JSON well-formedness
or — in the authenticated-operator threat model — introduce a command-injection
seam in the embedded shell command.

Changes:
- promote-tenant-image.sh: add validation after argument parsing:
    * REGION must match ^[a-z0-9-]+$ (exit 64)
    * ECR_ACCOUNT_ID (if set) must match ^[0-9]{12}$ (exit 64)
- test-promote-tenant-image.sh: add 3 test cases to Test 8:
    * exit 64 on JSON-injection region ("x";rm -rf /)
    * exit 64 on non-12-digit ECR_ACCOUNT_ID
    * valid region + ECR_ACCOUNT_ID passes validation

All 43 tests pass. Tier: low — defense-in-depth on authenticated-operator-only
threat model. Closes mc#676.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-12 08:52:21 +00:00