fix(ci): strip JSON5 comments from manifest.json before clone-manifest.sh (internal#561) #586
Merged
infra-runtime-be
merged 1 commits from 2026-05-11 22:33:31 +00:00
fix/publish-workspace-server-image-json5-comments into main
1 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
| 1688c1a991 |
fix(ci): strip JSON5 comments from manifest.json before clone-manifest.sh
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 16s
CI / Detect changes (pull_request) Successful in 50s
E2E API Smoke Test / detect-changes (pull_request) Successful in 53s
Harness Replays / detect-changes (pull_request) Successful in 22s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 23s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m11s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 1m17s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 24s
qa-review / approved (pull_request) Failing after 21s
security-review / approved (pull_request) Failing after 20s
gate-check-v3 / gate-check (pull_request) Successful in 30s
sop-tier-check / tier-check (pull_request) Successful in 25s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m9s
CI / Platform (Go) (pull_request) Successful in 9s
CI / Canvas (Next.js) (pull_request) Successful in 7s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 6s
CI / Python Lint & Test (pull_request) Successful in 9s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 10s
Harness Replays / Harness Replays (pull_request) Successful in 8s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 8s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 17s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 6s
audit-force-merge / audit (pull_request) Successful in 23s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 7s
Integration Tester appends a trailing `// Triggered by ...` comment to manifest.json on each run. This is valid JSON5 but breaks `jq` which clone-manifest.sh uses to parse the file — causing publish-workspace-server-image and harness-replays to fail on every run. Fix: pipe manifest.json through `sed '/^[[:space:]]*\/\//d'` before passing to clone-manifest.sh, producing a clean JSON file for jq. harness-replays.yml: also downgrade the missing-token check from `exit 1` to a warning, consistent with publish-workspace-server-image.yml. All repos are public per the manifest.json OSS surface contract — token is only needed for private repos. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> |
