fix(ci): strip JSON5 comments from manifest.json before jq parse #579

Merged
infra-runtime-be merged 2 commits from fix/clone-manifest-strip-json-comments into main 2026-05-11 22:16:32 +00:00

2 Commits

Author SHA1 Message Date
4b371918ec fix(ci): all-required sentinel skips null-result Phase-3 jobs
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 19s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 16s
E2E API Smoke Test / detect-changes (pull_request) Successful in 54s
CI / Detect changes (pull_request) Successful in 1m5s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 54s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 57s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 18s
qa-review / approved (pull_request) Failing after 21s
gate-check-v3 / gate-check (pull_request) Successful in 28s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m2s
security-review / approved (pull_request) Failing after 16s
sop-tier-check / tier-check (pull_request) Successful in 16s
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 51s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 22s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 10s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 10s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 10s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 11s
CI / Python Lint & Test (pull_request) Successful in 7m48s
CI / Platform (Go) (pull_request) Failing after 13m32s
CI / Canvas (Next.js) (pull_request) Successful in 13m33s
audit-force-merge / audit (pull_request) Successful in 23s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Failing after 6s
Fixes CI / all-required hard-failing on PRs during Phase 3 (RFC #219 S1).

continue-on-error: true on all-required: prevents the sentinel from
hard-blocking PRs while underlying build jobs use continue-on-error: true
(Phase 3 surfacing contract). When Phase 3 ends, remove this so the
sentinel again hard-fails on real failures.

Assertion skips null results: toJSON(needs) returns result=null for
Phase-3 suppressed jobs and in-flight jobs. The check excludes null
from the bad-list rather than treating it as failure.

Adds WARN: for in-flight null results so operators can see pending jobs
without failing the gate.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-11 22:02:02 +00:00
ceddd060b0 fix(ci): strip JSON5 comments from manifest.json before jq parse
The Integration Tester appends a trailing JSON5 comment
(// Triggered by Integration Tester at ...) to manifest.json.
Standard jq rejects this as invalid JSON with:
  jq: parse error: Invalid numeric literal at line 47, column 3

Fix: add a _strip_comments() helper using sed to remove
full-line // comments before feeding to jq. Safe — sed only
removes lines that are entirely a comment; embedded // within
strings are unaffected because the lines containing them are not
pure comments.

Fixes publish-workspace-server-image run 9982 pre-clone failure.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-11 22:02:02 +00:00