test(ci): add bats integration tests for review-check.sh (#540) #552

Merged
app-fe merged 2 commits from ci/540-review-check-bats-tests into main 2026-05-11 20:58:13 +00:00

2 Commits

Author SHA1 Message Date
b575ab8266 Merge branch 'main' into ci/540-review-check-bats-tests
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 26s
CI / Detect changes (pull_request) Successful in 1m42s
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m42s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 1m39s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 24s
qa-review / approved (pull_request) Failing after 26s
gate-check-v3 / gate-check (pull_request) Failing after 41s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m21s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m15s
security-review / approved (pull_request) Failing after 20s
CI / Platform (Go) (pull_request) Successful in 17s
CI / Canvas (Next.js) (pull_request) Successful in 10s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s
sop-tier-check / tier-check (pull_request) Successful in 25s
CI / Python Lint & Test (pull_request) Successful in 13s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 15s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 19s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 13s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 12s
CI / all-required (pull_request) Successful in 7s
audit-force-merge / audit (pull_request) Successful in 23s
2026-05-11 20:45:21 +00:00
43cc27ade5 test(ci): add bats-style integration tests for review-check.sh (#540)
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 23s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 13s
CI / Detect changes (pull_request) Successful in 1m6s
gate-check-v3 / gate-check (pull_request) Successful in 26s
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m6s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 1m2s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m3s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m0s
qa-review / approved (pull_request) Failing after 20s
security-review / approved (pull_request) Failing after 17s
sop-tier-check / tier-check (pull_request) Successful in 23s
CI / Canvas (Next.js) (pull_request) Successful in 9s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 6s
CI / Python Lint & Test (pull_request) Successful in 6s
CI / Platform (Go) (pull_request) Successful in 7s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 15s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 11s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 10s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 8s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 5s
Add 13 test cases (22 assertions) covering all key paths:
- open/closed PR handling
- non-author APPROVED review detection
- dismissed review exclusion
- team membership probe (204 member, 404 not-member, 403 fail-closed)
- missing GITEA_TOKEN exits 1
- CURL_AUTH_FILE mode 600 and header format
- jq filter correctness

Uses a Python HTTP fixture server that reads scenario from a temp
state dir, with a curl shim rewriting https://fixture.local/* to
http://127.0.0.1:{port}/*.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-11 20:33:14 +00:00