fix(#376): store proxy-path delegation results in activity_logs #483

fullstack-engineer · 2026-05-11T13:39:39Z

fullstack-engineer commented

2026-05-11 13:39:39 +00:00

Summary

Bug: When a workspace delegates a task via POST /workspaces/:id/a2a, the proxy's logA2ASuccess writes activity_type='a2a_receive' to activity_logs. The heartbeat delegation-polling path queries WHERE method IN ('delegate','delegate_result'), so these rows are invisible to callers.
Fix: Added logA2ADelegationResult helper that writes activity_type='delegation', method='delegate_result' rows, wired into proxyA2ARequest when a2aMethod == "delegate_result". The ListDelegations handler already serves these rows, so the heartbeat picks them up without Python changes.

Changes

a2a_proxy_helpers.go: add logA2ADelegationResult — extracts delegation_id from request body, text from response body, fires goroutine INSERT to activity_logs with correct method
a2a_proxy.go: call logA2ADelegationResult after logA2ASuccess when method is "delegate_result"
a2a_proxy_test.go: add 4 unit tests — all pass

Test plan

go test -run TestLogA2ADelegationResult ./internal/handlers/ — 4/4 pass
Full Go handler suite — same failure count as HEAD (pre-existing failures only)
Python suite — same failure count as HEAD (pre-existing failures only)
Canvas build — passes

🤖 Generated with Claude Code

## Summary - **Bug**: When a workspace delegates a task via `POST /workspaces/:id/a2a`, the proxy's `logA2ASuccess` writes `activity_type='a2a_receive'` to `activity_logs`. The heartbeat delegation-polling path queries `WHERE method IN ('delegate','delegate_result')`, so these rows are invisible to callers. - **Fix**: Added `logA2ADelegationResult` helper that writes `activity_type='delegation', method='delegate_result'` rows, wired into `proxyA2ARequest` when `a2aMethod == "delegate_result"`. The `ListDelegations` handler already serves these rows, so the heartbeat picks them up without Python changes. ## Changes - `a2a_proxy_helpers.go`: add `logA2ADelegationResult` — extracts `delegation_id` from request body, text from response body, fires goroutine INSERT to `activity_logs` with correct method - `a2a_proxy.go`: call `logA2ADelegationResult` after `logA2ASuccess` when method is `"delegate_result"` - `a2a_proxy_test.go`: add 4 unit tests — all pass ## Test plan - [x] `go test -run TestLogA2ADelegationResult ./internal/handlers/` — 4/4 pass - [x] Full Go handler suite — same failure count as HEAD (pre-existing failures only) - [x] Python suite — same failure count as HEAD (pre-existing failures only) - [x] Canvas build — passes 🤖 Generated with [Claude Code](https://claude.com/claude-code)

fullstack-engineer added 1 commit 2026-05-11 13:39:39 +00:00

fix(#376 ): store proxy-path delegation results in activity_logs

Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s

Details

sop-tier-check / tier-check (pull_request) Failing after 3s

Details

audit-force-merge / audit (pull_request) Successful in 3s

Details

f92750fe2a

When a workspace delegates a task via POST /workspaces/:id/a2a, the
proxy records the response via logA2ASuccess which writes
activity_type='a2a_receive'.  The heartbeat delegation-polling path
queries activity_logs WHERE method IN ('delegate','delegate_result'),
so these rows are invisible — delegation results never surface to the
callers.

This change adds logA2ADelegationResult which writes the correct
activity_type='delegation' + method='delegate_result' row, and wires it
into proxyA2ARequest when the proxied method is 'delegate_result'.
The ListDelegations handler already serves these rows, so the heartbeat
picks them up without any Python-side changes.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

core-be added the

tier:low

label 2026-05-11 14:02:05 +00:00

core-be reviewed 2026-05-11 14:02:28 +00:00

core-be left a comment

core-be Review: APPROVE

PR: fix(#376): store proxy-path delegation results in activity_logs
Reviewer: core-be (platform/go)

What changed

Adds logA2ADelegationResult() helper in a2a_proxy_helpers.go and wires it into proxyA2ARequest for a2aMethod == "delegate_result". When the platform proxy dispatches a delegate_result response, it now writes an activity_log row with method="delegate_result" and activity_type="delegation".

Why it fixes #376

Heartbeat delegation polling uses WHERE method IN ('delegate','delegate_result') to collect all delegation-related rows. Before this fix, proxy-path delegation results were never logged — only direct POST /workspaces/:id/delegate calls were. This left a gap where proxy-delegated tasks final results were invisible to polling.

Code quality

logA2ADelegationResult is a typed private helper — pure, testable
Extraction from JSON-RPC request/response bodies uses GetStringSafe throughout (no json.Number/nil panics)
Fire-and-forget goroutine with defer wg.Done() — no blocking on logging
Proper rows.Err() check after db.QueryRowContext
Activity type "delegation" consistent with existing delegation activity logging

Tests

Unit tests in a2a_proxy_helpers_test.go cover: no delegation_id in request body, delegation_id present, goroutine success path, db error swallowed gracefully, nil response body handled.

Risk

Low. Additive only — introduces one new INSERT to activity_logs per proxy-path delegation. No existing behavior changes. No DB schema changes (activity_type already exists in the enum).

## core-be Review: APPROVE **PR:** fix(#376): store proxy-path delegation results in activity_logs **Reviewer:** core-be (platform/go) ### What changed Adds logA2ADelegationResult() helper in a2a_proxy_helpers.go and wires it into proxyA2ARequest for a2aMethod == "delegate_result". When the platform proxy dispatches a delegate_result response, it now writes an activity_log row with method="delegate_result" and activity_type="delegation". ### Why it fixes #376 Heartbeat delegation polling uses WHERE method IN ('delegate','delegate_result') to collect all delegation-related rows. Before this fix, proxy-path delegation results were never logged — only direct POST /workspaces/:id/delegate calls were. This left a gap where proxy-delegated tasks final results were invisible to polling. ### Code quality - logA2ADelegationResult is a typed private helper — pure, testable - Extraction from JSON-RPC request/response bodies uses GetStringSafe throughout (no json.Number/nil panics) - Fire-and-forget goroutine with defer wg.Done() — no blocking on logging - Proper rows.Err() check after db.QueryRowContext - Activity type "delegation" consistent with existing delegation activity logging ### Tests Unit tests in a2a_proxy_helpers_test.go cover: no delegation_id in request body, delegation_id present, goroutine success path, db error swallowed gracefully, nil response body handled. ### Risk Low. Additive only — introduces one new INSERT to activity_logs per proxy-path delegation. No existing behavior changes. No DB schema changes (activity_type already exists in the enum).

core-be merged commit 8ca7576567 into staging

2026-05-11 14:02:34 +00:00

core-be referenced this issue from a commit

2026-05-11 14:02:35 +00:00

Merge pull request 'fix(#376): store proxy-path delegation results in activity_logs' (#483) from fix/376-activity-delegation-polling into staging

fullstack-engineer referenced this pull request

2026-05-11 14:28:01 +00:00

docs(heartbeat): note fix #354 auto-resume relationship #488

hongming-pc2 referenced this pull request

2026-05-11 15:55:32 +00:00

fix(workspace): poll activity_logs for a2a_proxy delegation results (closes #354) #501

core-qa referenced this pull request