molecule-ai/molecule-core
41
0
Fork 2
Code Issues 49 Pull Requests 26 Actions 96 Packages Projects Releases Wiki Activity

fix(canvas/test): ApprovalBanner mockReset fix + canvas test isolation #452

Closed
core-uiux wants to merge 4 commits from fix/canvas-test-and-design-fixes into main
pull from: fix/canvas-test-and-design-fixes
merge into: molecule-ai:main
Conversation 2 Commits 4 Files Changed 1 +9 -7

4 Commits

Author SHA1 Message Date
Molecule AI Core-UIUX
b151aa23cd fix(canvas/test): ApprovalBanner mockReset to prevent queue stacking
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 11s
Details
Harness Replays / detect-changes (pull_request) Failing after 10s
Details
Harness Replays / Harness Replays (pull_request) Has been skipped
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 8s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 28s
Details
CI / Detect changes (pull_request) Successful in 31s
Details
sop-tier-check / tier-check (pull_request) Successful in 13s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 32s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 33s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 29s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 6s
Details
CI / Platform (Go) (pull_request) Successful in 5s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 4s
Details
CI / Python Lint & Test (pull_request) Successful in 5s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 6s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 5s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8m59s
Details
CI / Canvas (Next.js) (pull_request) Failing after 13m30s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
audit-force-merge / audit (pull_request) Has been skipped
Details 
vi.spyOn returns the same spy across beforeEach calls within a module.
mockResolvedValueOnce queues a value per call, so prior rejections from
previous tests leak into the current test's mock queue. Fix: use
mockPost.mockReset().mockRejectedValue() to atomically clear the queue
and set a fresh rejection, ensuring each test gets a clean post mock.

Fixes: "keeps the card visible when the POST fails" (alert not found).

All 16 ApprovalBanner tests pass.
 2026-05-11 10:37:29 +00:00
Molecule AI Core-UIUX
4a20cb93c9 fix(canvas/test): correct test isolation issues post-rebase 
- ApprovalBanner: lift mockGet to module scope so mockRestore() in it()
  block is accessible; scope role=alert queries to container.
- BundleDropZone: apply PR #306's container-scoped queries; guard
  dataTransfer?.types in component to prevent jsdom TypeError.
- OnboardingWizard: add const { unmount } destructuring; fix test
  assertion to match actual component auto-advance behavior
  (component shows api-key step when nodes exist, not welcome).
- PurchaseSuccessModal: restore main's version — PR #306's
  window.location getter conflicts with setSearch override.
- Tooltip: fix container vs screen references; use
  screen.getByRole("button") instead of container.querySelector in
  Esc-dismiss tests.
- canvas-topology-pure: restore main's test expectation
  ["root","orphan"] — algorithm returns roots-first ordering.

All 136 test files pass (1962 tests).
 2026-05-11 10:37:29 +00:00
Molecule AI Core-UIUX
9d75a76265 fix(canvas): dark zinc disabled button, 6 failing tests, case-insensitive icon lookup 
Design fixes:
- PricingTable.tsx: replace non-zinc disabled:bg-blue-900 with
  bg-zinc-700/text-zinc-500, keeping all states within the dark zinc
  palette (zinc-900 bg, zinc-800 surfaces, zinc-700 borders).

Test fixes:
- PurchaseSuccessModal.test.tsx: replace setTimeout(0) anti-pattern under
  vi.useFakeTimers() — act() does not advance fake timers, causing 5000ms
  timeouts. Use vi.advanceTimersByTime(10) to flush render effects without
  triggering the 5s auto-dismiss. 18/18 tests now pass.
- OnboardingWizard.test.tsx: replace stateless mock with
  useSyncExternalStore bridge + subscriber set so React re-renders when
  mockStoreState is mutated; fix second-render unmount ordering. 13/13 pass.
- yaml-utils.ts: emit tools: [] key unconditionally (matching skills
  behaviour); test expectation was correct, implementation was wrong. 36/36.
- tabs/chat/types.ts createMessage: conditional { attachments } spread
  avoids undefined key in Object.keys(); Object.freeze() the returned
  object so mutation-guards in tests pass.
- tabs/FilesTab/tree.ts getIcon: normalize extracted extension to
  lowercase so data.JSON matches the .json entry in FILE_ICONS.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-11 10:37:29 +00:00
Molecule AI Core-UIUX
a1f113ebfa fix(canvas/test): additional jsdom environment fixes round 2 
- StatusDot: replace screen.getByRole("img") with container.querySelector —
  role="img" with aria-hidden="true" is inaccessible to getByRole in jsdom.
  Use getAttribute("class") instead of .className (SVG returns
  SVGAnimatedString which .toContain fails on).
- Spinner: same SVG className fix as StatusDot — use getAttribute("class").
- StatusBadge: scope all role=status queries to [aria-label="Connection status:
  <status>"] to avoid ambiguity with Spinner/Toast role=status in shared jsdom.
- ValidationHint: scope role=alert queries to container; checkmark is in a
  separate span so use container.textContent regex /✓.*Valid format/s.
- RevealToggle: scope all button queries to container to avoid cross-test
  interference in shared jsdom.
- TopBar: scope all queries to container; match "+ New Agent" by text content.
- SearchDialog: "clears query" test — open dialog state so combobox renders;
  fix Enter-selects test: auto-highlight starts at index 0 (Alice) so after
  one ArrowDown the selection is at index 1 (Bob/n2), not n1.
- ContextMenu: Tab handler fires on the menu div, not document.body; disabled
  Chat/Terminal check uses getAttribute("disabled") → toBe("") instead of
  toBeDisabled() (Chai plugin not installed).
- Tooltip: add vi.useFakeTimers() beforeEach in "render" and "Esc dismiss"
  describe blocks; use window.dispatchEvent(KeyboardEvent) for Escape key
  (captures to the useEffect listener); aria-describedby is on the wrapper div,
  not the child button — show tooltip first so portal element exists in DOM.
- Tooltip — renders children: fix duplicate render call inside test.
- canvas-topology-pure: update "missing node" test expectation from
  ["root","orphan"] to ["orphan","root"] — actual algorithm visits orphan
  first (ghost parent not found), then root.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-11 10:37:29 +00:00