fix(ci): reconcile workflow secret names per internal#273 §425 #434

Closed
infra-sre wants to merge 2 commits from sre/fix-workflow-secret-naming into main

2 Commits

Author SHA1 Message Date
897b047169 Merge branch 'main' into sre/fix-workflow-secret-naming
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 13s
CI / Detect changes (pull_request) Successful in 35s
E2E API Smoke Test / detect-changes (pull_request) Successful in 56s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 1m4s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 15s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m5s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 17s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 48s
sop-tier-check / tier-check (pull_request) Successful in 16s
CI / Platform (Go) (pull_request) Successful in 10s
CI / Canvas (Next.js) (pull_request) Successful in 11s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s
CI / Python Lint & Test (pull_request) Successful in 11s
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Failing after 4m41s
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m24s
audit-force-merge / audit (pull_request) Has been skipped
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 11s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 13s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 11s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 11s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
2026-05-11 09:14:33 +00:00
7642cf187a fix(ci): reconcile CP admin token secret names across all workflows
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 20s
CI / Detect changes (pull_request) Successful in 53s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 53s
E2E API Smoke Test / detect-changes (pull_request) Successful in 57s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 14s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 18s
sop-tier-check / tier-check (pull_request) Successful in 18s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 48s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 52s
CI / Platform (Go) (pull_request) Successful in 8s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 6s
CI / Canvas (Next.js) (pull_request) Successful in 9s
CI / Python Lint & Test (pull_request) Successful in 9s
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m12s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 10s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 9s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 11s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 10s
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Failing after 6m3s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Per internal#273 §425 naming audit. The GitHub→Gitea migration created
two parallel naming conventions for the same logical secrets:

  CP admin tokens (prod):  CP_ADMIN_API_TOKEN  →  CP_PROD_ADMIN_TOKEN
  CP admin tokens (staging): CP_STAGING_ADMIN_API_TOKEN → CP_STAGING_ADMIN_TOKEN
  AWS janitor credentials: AWS_JANITOR_ACCESS_KEY_ID  →  AWS_ACCESS_KEY_ID

All workflows now use the canonical names (right column), matching what is
actually stored in the Gitea secret store per issue #425.

Canonical secret names now used by ALL workflows:
  - secrets.CP_PROD_ADMIN_TOKEN     (was: CP_ADMIN_API_TOKEN)
  - secrets.CP_STAGING_ADMIN_TOKEN (was: CP_STAGING_ADMIN_API_TOKEN)
  - secrets.AWS_ACCESS_KEY_ID      (was: AWS_JANITOR_ACCESS_KEY_ID)
  - secrets.AWS_SECRET_ACCESS_KEY  (was: AWS_JANITOR_SECRET_ACCESS_KEY)

Affected workflows: sweep-aws-secrets, sweep-cf-orphans, sweep-cf-tunnels,
canary-verify, redeploy-tenants-on-main, redeploy-tenants-on-staging,
continuous-synth-e2e, e2e-staging-external, e2e-staging-saas

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-11 08:48:19 +00:00