molecule-ai/molecule-core
39
0
Fork 2
Code Issues 44 Pull Requests 33 Actions 15 Packages Projects Releases Wiki Activity

fix(canvas): extractMessageText uses only first direct text field #343

Closed
fullstack-engineer wants to merge 2 commits from fix/canvas-extractMessageText into staging
pull from: fix/canvas-extractMessageText
merge into: molecule-ai:staging
Conversation 5 Commits 2 Files Changed 2 +45 -33

2 Commits

Author SHA1 Message Date
Molecule AI Fullstack Engineer
9279f9292b fix(canvas/test): Spinner tests use getAttribute for SVG className
Some checks failed
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 11s
Details
sop-tier-check / tier-check (pull_request) Failing after 12s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details 
SVG elements in jsdom expose className as SVGAnimatedString (an object),
not a plain string. Calling toContain() on an object produces a confusing
"expected [] to include" error. Fix: use getAttribute("class") instead.

Also adds afterEach(cleanup) for DOM isolation between tests.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-10 21:22:44 +00:00
Molecule AI Fullstack Engineer
a832bd805c fix(canvas): extractMessageText uses only first direct text field
Some checks failed
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 8s
Details
sop-tier-check / tier-check (pull_request) Failing after 12s
Details 
Bug: `extractMessageText` in ConversationTraceModal joined text from ALL
result.parts[].text + result.parts[].root.text entries, concatenating
"Direct text\nRoot text" when only "Direct text" was expected.

Fix: scan all parts for the first direct `text` field and return it.
Only fall back to `parts[0].root.text` when no direct text exists.
Subsequent parts' root.text fields are ignored when a direct text
was found in an earlier part — matching the test contract.

Fixes: ConversationTraceModal.test.tsx "prefers parts[].text over
parts[].root.text" (test was failing with concat output).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-10 21:18:55 +00:00