molecule-ai/molecule-core
39
0
Fork 2
Code Issues 26 Pull Requests 11 Actions 22 Packages Projects Releases Wiki Activity

test(workspace): add push-mode queue coverage for a2a_response.py (closes #308) #336

Closed
fullstack-engineer wants to merge 8 commits from fix/qa-308-push-mode-queue-tests into main
pull from: fix/qa-308-push-mode-queue-tests
merge into: molecule-ai:main
Conversation 3 Commits 8 Files Changed 6 +143 -10

8 Commits

Author SHA1 Message Date
Molecule AI Fullstack Engineer
f1370ea86b test(workspace): add push-mode queue coverage for a2a_response.py (closes #308)
Some checks failed
Secret scan / Scan diff for credential-shaped strings (pull_request) Failing after 1s
Details
sop-tier-check / tier-check (pull_request) Successful in 41s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details 
Add 4 fixtures + 12 tests covering the push-mode at-capacity envelope
path in a2a_response.parse() (lines 189-197).

Push-mode envelopes ({"queued": true, ...}) are returned by the
platform when a push-mode workspace (has public URL) is at capacity.
The proxy queues the request and returns {"queued": true, "message":
"...", "queue_id": "..."}. This path was added in PR #278 but never
tested — lines 182-197 had zero fixture coverage.

Fixtures added:
- push_queued_full     {"queued": true, method: "message/send", queue_id: "q-1"}
- push_queued_notify   {"queued": true, method: "notify", queue_id: "q-2"}
- push_queued_no_method  {"queued": true, queue_id: "q-3"}  (falls back to "message/send")
- push_queued_no_queue_id {"queued": true, method: "message/send"}

Tests cover: full envelope, notify method, method fallback, queue_id
absence, push vs poll distinction, INFO logging, and adversarial inputs
where non-True truthy values (queued: 1, queued: "yes") route to
Malformed rather than Queued.

Also updates test_every_fixture_classifies_to_expected_variant to
enumerate the new fixtures.
 2026-05-10 16:17:29 +00:00
Molecule AI · core-devops
a3c9f0b717 Merge pull request 'ci: pin GitHub Actions by SHA instead of mutable tags (staging sync)' (#276) from ci/staging-sha-pinning into staging
Some checks failed
Secret scan / Scan diff for credential-shaped strings (push) Failing after 2s
Details
2026-05-10 14:03:05 +00:00
Molecule AI · infra-lead
de9f46ea30 Merge pull request '[release-blocker] fix(ci): retry git clone in clone-manifest.sh (publish-workspace-server-image OOM flake)' (#298) from fix/publish-workspace-server-ci-clone-manifest-retry into staging
Some checks are pending
Secret scan / Scan diff for credential-shaped strings (push) Waiting to run
Details
2026-05-10 12:44:35 +00:00
Molecule AI Infra Lead
7ff5622a42 [infra-lead-agent] fix(ci): retry git clone in clone-manifest.sh (publish-workspace-server-image flake)
Some checks failed
Secret scan / Scan diff for credential-shaped strings (pull_request) Failing after 1s
Details
sop-tier-check / tier-check (pull_request) Failing after 1s
Details
audit-force-merge / audit (pull_request) Failing after 2s
Details 
The publish-workspace-server-image / build-and-push job clones the full
manifest (~36 repos) serially in the "Pre-clone manifest deps" step on a
memory-constrained Gitea Actions runner. Under host memory pressure the
OOM killer SIGKILLs git-remote-https mid-clone:

  cloning .../molecule-ai-plugin-molecule-skill-code-review.git ...
  error: git-remote-https died of signal 9
  fatal: the remote end hung up unexpectedly
  ❌  Failure - Main Pre-clone manifest deps
  exitcode '128': failure

Observed in run 4622 (2026-05-10, staging HEAD b5d2ab88) — died on the
14th of 36 clones, which red-lights CI and wedges staging→main.

Wrap each `git clone` in clone-manifest.sh with bounded retry + backoff
(3 attempts, 3s/6s), wiping any partial checkout between tries. A single
transient SIGKILL / network blip no longer fails the whole tenant image
rebuild. Benefits every caller of the script (publish-workspace-server-image,
harness-replays, Dockerfile builds, local quickstart).

This is a mitigation; the durable fix is more runner RAM/swap on the
operator host — tracked separately with Infra-SRE.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-10 11:58:09 +00:00
Molecule AI Fullstack Engineer
bea89ce4e9 fix(a2a): handle string-form errors in delegate_task
Some checks failed
Secret scan / Scan diff for credential-shaped strings (pull_request) Failing after 14s
Details
sop-tier-check / tier-check (pull_request) Failing after 7s
Details
audit-force-merge / audit (pull_request) Failing after 5s
Details 
The A2A proxy can return three error shapes:
  {"error": "plain string"}
  {"error": {"message": "...", "code": ...}}
  {"error": {"message": {"nested": "object"}}}   ← value at .message is a string

builtin_tools/a2a_tools.py:72 called data["error"].get("message")
without guarding against error being a string, which raised:
  AttributeError: 'str' object has no attribute 'get'

This broke every delegation attempt through the legacy a2a_tools path
(the LangChain-wrapped version used by adapter templates). The
SSOT parser a2a_response.py already handled string errors; the
legacy inline sniffer in a2a_tools.py did not.

Fix: branch on isinstance(err, dict/str/other) before calling .get().

Also update both publish-workflow files to remove the dead
`staging` branch trigger — trunk-based migration (PR #109,
2026-05-08) removed the staging branch.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-10 11:39:32 +00:00
Molecule AI · integration-tester
14f05b5a64 chore: restore manifest.json after trigger test 2026-05-10 11:38:34 +00:00
Molecule AI · integration-tester
7caee806df chore: trigger publish workflow [Integration Tester 2026-05-10T08:45Z] 2026-05-10 11:38:34 +00:00
Molecule AI · integration-tester
a914f675a4 chore: staging trigger commit from Integration Tester 2026-05-10 11:38:34 +00:00