test(ssot): derive concierge degraded-gate tool id from the delivery contract #3115

Merged

devops-engineer merged 1 commits from fix/ssot-degrade-gate-tool-from-contract into main 2026-06-21 09:44:13 +00:00

Conversation 2 Commits 1 Files Changed 2

+33

hongming commented 2026-06-21 09:23:31 +00:00

Owner

Copy Link

Copy Source

SSOT enforcement (molecule-core side) for the platform MCP server name. Pairs with molecule-ai-workspace-template-platform-agent#6.

The online/degraded gate hard-coded conciergePlatformMCPCreateWorkspaceTool = mcp__molecule-platform__create_workspace independently of the delivery contract. That let the platform-agent template drift its server name to platform (runtime emitted mcp__platform__create_workspace) while the gate looked for molecule-platform — so the concierge read as degraded even with all platform tools loaded.

This pins the contract as the SSOT and ties the gate to it:

• Add MCPServerName to MCPPluginDeliveryContract (already present in the contract JSON as mcp_server_name).
• Pin mcp_server_name = molecule-platform in TestMCPPluginDeliveryContract_MatchesSSOT.
• TestSSOT_DegradeGateToolDerivesFromContract asserts the gate tool id == mcp__ + contract.mcp_server_name + __create_workspace, so the gate and the contract can never silently diverge again.

Verified locally: both SSOT tests PASS. (The pre-existing TestMCPPluginDeliveryContract_MCPServerAdaptorWritesMcpServers fails ONLY on my Windows box — it needs the molecule-ai-workspace-runtime checkout + python; it fails identically on clean main here and runs green in CI.)

Generated with Claude Code.

SSOT enforcement (molecule-core side) for the platform MCP server name. Pairs with molecule-ai-workspace-template-platform-agent#6. The online/degraded gate hard-coded conciergePlatformMCPCreateWorkspaceTool = `mcp__molecule-platform__create_workspace` independently of the delivery contract. That let the platform-agent template drift its server name to `platform` (runtime emitted `mcp__platform__create_workspace`) while the gate looked for `molecule-platform` — so the concierge read as `degraded` even with all platform tools loaded. This pins the contract as the SSOT and ties the gate to it: - Add `MCPServerName` to MCPPluginDeliveryContract (already present in the contract JSON as mcp_server_name). - Pin mcp_server_name = `molecule-platform` in TestMCPPluginDeliveryContract_MatchesSSOT. - TestSSOT_DegradeGateToolDerivesFromContract asserts the gate tool id == `mcp__` + contract.mcp_server_name + `__create_workspace`, so the gate and the contract can never silently diverge again. Verified locally: both SSOT tests PASS. (The pre-existing TestMCPPluginDeliveryContract_MCPServerAdaptorWritesMcpServers fails ONLY on my Windows box — it needs the molecule-ai-workspace-runtime checkout + python; it fails identically on clean main here and runs green in CI.) Generated with Claude Code.

hongming added 1 commit 2026-06-21 09:23:32 +00:00

test(ssot): derive concierge degraded-gate tool id from the delivery contract ... 20252250c3

The online/degraded gate hard-coded
conciergePlatformMCPCreateWorkspaceTool = "mcp__molecule-platform__create_workspace"
independently of the delivery contract's mcp_server_name. That let the
platform-agent template drift its MCP server name to "platform" (so the runtime
emitted mcp__platform__create_workspace) while the gate kept looking for
"molecule-platform" — marking every concierge degraded even with all platform
tools loaded.

Enforce the SSOT (contract mcp_server_name = "molecule-platform"):
- Add MCPServerName to MCPPluginDeliveryContract (already in the contract JSON).
- Pin mcp_server_name in TestMCPPluginDeliveryContract_MatchesSSOT.
- TestSSOT_DegradeGateToolDerivesFromContract asserts the gate's tool id ==
  "mcp__" + contract.mcp_server_name + "__create_workspace", so the gate and the
  contract can never silently diverge again.

Paired with molecule-ai-workspace-template-platform-agent#6, which aligns the
runtime mcp_servers.yaml server name to molecule-platform.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

agent-reviewer-cr2 approved these changes 2026-06-21 09:41:29 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on current head 20252250.

5-axis: correctness: adds mcp_server_name to the delivery contract model and a regression test that derives the degraded-gate create_workspace tool id from that contract value, preventing drift between the platform MCP server name and the concierge gate. Robustness: the test fails closed on empty contract value or constant drift, which is the right guard for this SSOT contract. Security: no runtime behavior or secret surface change. Performance: test-only/struct-field change, no runtime cost. Readability: comments explain the contract relationship and prior failure mode clearly.

Not merge-ready from this review alone: this is CR2's first current-head approval; needs the second genuine approval and normal gates before merge.

APPROVED on current head 20252250. 5-axis: correctness: adds `mcp_server_name` to the delivery contract model and a regression test that derives the degraded-gate `create_workspace` tool id from that contract value, preventing drift between the platform MCP server name and the concierge gate. Robustness: the test fails closed on empty contract value or constant drift, which is the right guard for this SSOT contract. Security: no runtime behavior or secret surface change. Performance: test-only/struct-field change, no runtime cost. Readability: comments explain the contract relationship and prior failure mode clearly. Not merge-ready from this review alone: this is CR2's first current-head approval; needs the second genuine approval and normal gates before merge.

agent-researcher approved these changes 2026-06-21 09:43:32 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVED on current head 20252250.

5-axis: correctness: the code adds mcp_server_name to the typed delivery contract and pins it to molecule-platform, then derives the degraded-gate expected tool id as mcp__<contract.mcp_server_name>__create_workspace. That directly guards the SSOT drift class where the runtime emits one MCP server name while the concierge gate looks for another. Robustness: the test fails on either an empty contract server name or a future constant/contract divergence, so silent drift is caught. Security: no new secrets or runtime permissions. Performance: test-only assertion plus JSON field decode, no meaningful runtime cost. Readability: comments clearly explain the contract/gate/tool-id relationship.

Merge note: CR2 approval 12972 is present. I will only merge after the live required-check/branch-protection state confirms it is merge-safe; advisory staging failures alone are not a code-review blocker.

APPROVED on current head 20252250. 5-axis: correctness: the code adds `mcp_server_name` to the typed delivery contract and pins it to `molecule-platform`, then derives the degraded-gate expected tool id as `mcp__<contract.mcp_server_name>__create_workspace`. That directly guards the SSOT drift class where the runtime emits one MCP server name while the concierge gate looks for another. Robustness: the test fails on either an empty contract server name or a future constant/contract divergence, so silent drift is caught. Security: no new secrets or runtime permissions. Performance: test-only assertion plus JSON field decode, no meaningful runtime cost. Readability: comments clearly explain the contract/gate/tool-id relationship. Merge note: CR2 approval 12972 is present. I will only merge after the live required-check/branch-protection state confirms it is merge-safe; advisory staging failures alone are not a code-review blocker.

devops-engineer merged commit b2cc4855ce into main 2026-06-21 09:44:13 +00:00

hongming referenced this issue from a commit 2026-06-21 10:20:32 +00:00

chore(manifest): bump platform-agent pin to include the SSOT server-name fix

hongming referenced this pull request 2026-06-21 10:20:45 +00:00

chore(manifest): bump platform-agent pin to include SSOT server-name fix #3119

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

agent-researcher

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3115