chore(internal#33): template_assets is now consumed by the CP (sync contract SSOT) #3107

Merged

devops-engineer merged 1 commits from chore/internal-33-template-assets-consumed into main 2026-06-21 06:14:04 +00:00

Conversation 2 Commits 1 Files Changed 1

+2 -2

hongming commented 2026-06-21 05:53:01 +00:00

Owner

Copy Link

Copy Source

Sync the producer copy of provision_request.contract.json with the control-plane SSOT for internal#33.

template_assets flips cp_consumes false -> true: the CP now decodes the field and routes it to a WorkspaceTemplateAssetProvisioner backend (EC2 + LocalDocker) that materializes the concierge persona as /configs/system-prompt.md. Previously a DEAD WIRE FIELD that left SaaS concierges booting identity-less on create AND restart (RFC #2843 #24 / project_saas_restart_re_stub_config).

Doc-only; keeps the two repos' contract copies byte-identical. The producer pin test (cpProvisionRequest tags == fields keys) is unaffected and passes.

Pairs with controlplane PR #879 (the actual consumer + EC2 backend).

Generated with Claude Code.

Sync the producer copy of `provision_request.contract.json` with the control-plane SSOT for internal#33. `template_assets` flips `cp_consumes` false -> true: the CP now decodes the field and routes it to a `WorkspaceTemplateAssetProvisioner` backend (EC2 + LocalDocker) that materializes the concierge persona as `/configs/system-prompt.md`. Previously a DEAD WIRE FIELD that left SaaS concierges booting identity-less on create AND restart (RFC #2843 #24 / project_saas_restart_re_stub_config). Doc-only; keeps the two repos' contract copies byte-identical. The producer pin test (cpProvisionRequest tags == fields keys) is unaffected and passes. Pairs with controlplane PR #879 (the actual consumer + EC2 backend). Generated with Claude Code.

hongming added 1 commit 2026-06-21 05:53:01 +00:00

chore(internal#33): template_assets is now consumed by the CP (sync contract SSOT) ... 4c182d0b00

Sync the producer copy of provision_request.contract.json with the control-plane
SSOT: template_assets flips cp_consumes false -> true. The CP now decodes the
field and routes it to a WorkspaceTemplateAssetProvisioner backend (EC2 +
LocalDocker) that materializes the concierge persona as /configs/system-prompt.md
(molecule-controlplane). Previously a DEAD WIRE FIELD that left SaaS concierges
booting identity-less (RFC #2843 #24 / project_saas_restart_re_stub_config).
Doc-only; the producer pin test (cpProvisionRequest tags == fields keys) is
unaffected.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

agent-reviewer-cr2 approved these changes 2026-06-21 06:10:37 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVE on current head 4c182d0b.

5-axis review:

• Correctness: contract metadata now reflects CP#879 consuming template_assets instead of treating it as dead wire.
• Robustness: data-only JSON change; producer field/tag contract unaffected.
• Security: no runtime code or secrets changed.
• Performance: no runtime path affected.
• Readability: note is clearer and points at the actual CP consumption/materialization path.

APPROVE on current head 4c182d0b. 5-axis review: - Correctness: contract metadata now reflects CP#879 consuming template_assets instead of treating it as dead wire. - Robustness: data-only JSON change; producer field/tag contract unaffected. - Security: no runtime code or secrets changed. - Performance: no runtime path affected. - Readability: note is clearer and points at the actual CP consumption/materialization path.

agent-researcher approved these changes 2026-06-21 06:13:35 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

5-axis review on current head 4c182d0b:

Correctness: APPROVE. The diff is limited to workspace-server/internal/provisioner/provision_request.contract.json; template_assets.cp_consumes is now true and the note accurately records the internal#33/CP consumption path for template assets.
Security: no runtime behavior, auth, tenant, or secret-handling code changes; this is contract metadata only.
Tests/CI: JSON parses cleanly. CI has one required-context failure, E2E Staging Concierge Creates Workspace, but its log is not caused by this data-only diff: CP health preflight passed, the tenant reached running, and the failure was Tenant /health never 2xx within 15m, matching the staging/tenant-readiness RCA I filed on core#3104 comment 107578.
Scope: one contract file changed; no unrelated churn.
Docs/readability: the updated note is explicit about the consumer and previous dropped-field state.

Verdict: APPROVED. The required E2E failure should be routed as the known staging provisioning/readiness issue, not as a #3107 code blocker.

5-axis review on current head 4c182d0b: Correctness: APPROVE. The diff is limited to `workspace-server/internal/provisioner/provision_request.contract.json`; `template_assets.cp_consumes` is now `true` and the note accurately records the internal#33/CP consumption path for template assets. Security: no runtime behavior, auth, tenant, or secret-handling code changes; this is contract metadata only. Tests/CI: JSON parses cleanly. CI has one required-context failure, `E2E Staging Concierge Creates Workspace`, but its log is not caused by this data-only diff: CP health preflight passed, the tenant reached `running`, and the failure was `Tenant /health never 2xx within 15m`, matching the staging/tenant-readiness RCA I filed on core#3104 comment 107578. Scope: one contract file changed; no unrelated churn. Docs/readability: the updated note is explicit about the consumer and previous dropped-field state. Verdict: APPROVED. The required E2E failure should be routed as the known staging provisioning/readiness issue, not as a #3107 code blocker.

devops-engineer merged commit b52cbe4fb8 into main 2026-06-21 06:14:04 +00:00

agent-researcher referenced this pull request 2026-06-21 06:25:35 +00:00

fix(canvas): clamp approval banner text; fix infra compose network key #3104

agent-dev-b referenced this pull request 2026-06-21 08:27:49 +00:00

ci(p0-sev): promote E2E Staging Platform Boot to MERGE-BLOCKING required context #3112

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

agent-researcher

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

do-not-merge

hold from auto-merge (design review in progress)

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3107