fix(handlers): main build red — undefined conciergePlatformMCPPlugin #3075

Merged

core-devops merged 1 commits from devops/fix-concierge-mcp-undefined-symbol into main 2026-06-19 11:22:52 +00:00

Conversation 4 Commits 1 Files Changed 2

+4 -4

core-devops commented 2026-06-19 10:55:25 +00:00

Member

Copy Link

Copy Source

URGENT: core main is RED (does not compile) — blocks all deploys.

Serialized merge-queue semantic conflict (PR #3050 + the concierge-MCP const rename): recordWorkspacePluginInstall's entitlement gate + its tests reference conciergePlatformMCPPlugin, but the const is conciergePlatformMCPName (platform_agent.go:457; line 133 of the same file already uses it). Each PR passed CI alone; combined main does NOT compile:

internal/handlers/plugins_tracking.go:77:19: undefined: conciergePlatformMCPPlugin

This broke go build ./cmd/server → every platform/tenant image build failed → all core deploys blocked → prod platform-tenant :latest could not promote.

Fix: unify the 1 prod ref + 3 test refs to conciergePlatformMCPName.

---

SOP checklist

Comprehensive testing performed: go build ./cmd/server now succeeds (was the failing image-build target); go test ./internal/handlers/ -run Plugin passes (the entitlement-gate tests now reference the defined const). No new behavior — pure symbol unification.

Local-postgres E2E run: N/A — no DB schema or query change; this is a compile-time symbol rename. The handlers unit tests (sqlmock) covering recordWorkspacePluginInstall pass.

Staging-smoke verified or pending: Pending/post-merge — this fix UNBLOCKS the deploy pipeline (main was red so no image could build). Staging smoke runs on the next green deploy.

Root-cause not symptom: Root cause = an undefined identifier (conciergePlatformMCPPlugin) left by a serialized-merge semantic conflict; fixed by using the actually-defined const conciergePlatformMCPName (not by deleting the gate or suppressing the error).

Five-Axis review walked: Correctness (uses the defined const, matches line 133); readability (consistent naming); architecture (no change); security (entitlement gate behavior unchanged — still refuses the privileged MCP on non-platform workspaces); performance (none).

No backwards-compat shim / dead code added: No — pure rename to the existing correct symbol; no shim, no dead code, no compat layer.

Memory consulted: Consulted feedback_no_such_thing_as_flakes (named the mechanism: serialized-merge semantic conflict, not a flake) and the concierge-plugin work memory (project_saas_restart_re_stub_config).

SOP checklist

• comprehensive-testing: rename verified by build+tests
• local-postgres-e2e: N/A symbol-only change
• staging-smoke: post-merge
• root-cause: undefined symbol conciergePlatformMCPPlugin replaced with existing conciergePlatformMCPName
• five-axis: done
• no-backwards-compat: pure rename, no shim
• memory-consulted: internal entitlement-gate

SOP checklist (slug markers)

• comprehensive-testing: rename verified by build+tests
• local-postgres-e2e: N/A symbol-only change
• staging-smoke: post-merge
• root-cause: undefined symbol conciergePlatformMCPPlugin replaced with existing conciergePlatformMCPName
• five-axis: done
• no-backwards-compat: pure rename, no shim
• memory-consulted: internal entitlement-gate

SOP checklist

• comprehensive-testing: rename verified by build+tests
• local-postgres-e2e: N/A symbol-only change
• staging-smoke: post-merge
• root-cause: undefined symbol conciergePlatformMCPPlugin replaced with existing conciergePlatformMCPName
• five-axis: done
• no-backwards-compat: pure rename, no shim
• memory-consulted: internal entitlement-gate

**URGENT: core main is RED (does not compile) — blocks all deploys.** Serialized merge-queue semantic conflict (PR #3050 + the concierge-MCP const rename): `recordWorkspacePluginInstall`'s entitlement gate + its tests reference `conciergePlatformMCPPlugin`, but the const is `conciergePlatformMCPName` (platform_agent.go:457; line 133 of the same file already uses it). Each PR passed CI alone; combined main does NOT compile: internal/handlers/plugins_tracking.go:77:19: undefined: conciergePlatformMCPPlugin This broke `go build ./cmd/server` → every platform/tenant image build failed → all core deploys blocked → prod platform-tenant :latest could not promote. Fix: unify the 1 prod ref + 3 test refs to `conciergePlatformMCPName`. --- ## SOP checklist **Comprehensive testing performed:** `go build ./cmd/server` now succeeds (was the failing image-build target); `go test ./internal/handlers/ -run Plugin` passes (the entitlement-gate tests now reference the defined const). No new behavior — pure symbol unification. **Local-postgres E2E run:** N/A — no DB schema or query change; this is a compile-time symbol rename. The handlers unit tests (sqlmock) covering `recordWorkspacePluginInstall` pass. **Staging-smoke verified or pending:** Pending/post-merge — this fix UNBLOCKS the deploy pipeline (main was red so no image could build). Staging smoke runs on the next green deploy. **Root-cause not symptom:** Root cause = an undefined identifier (`conciergePlatformMCPPlugin`) left by a serialized-merge semantic conflict; fixed by using the actually-defined const `conciergePlatformMCPName` (not by deleting the gate or suppressing the error). **Five-Axis review walked:** Correctness (uses the defined const, matches line 133); readability (consistent naming); architecture (no change); security (entitlement gate behavior unchanged — still refuses the privileged MCP on non-platform workspaces); performance (none). **No backwards-compat shim / dead code added:** No — pure rename to the existing correct symbol; no shim, no dead code, no compat layer. **Memory consulted:** Consulted `feedback_no_such_thing_as_flakes` (named the mechanism: serialized-merge semantic conflict, not a flake) and the concierge-plugin work memory (`project_saas_restart_re_stub_config`). ## SOP checklist - comprehensive-testing: rename verified by build+tests - local-postgres-e2e: N/A symbol-only change - staging-smoke: post-merge - root-cause: undefined symbol conciergePlatformMCPPlugin replaced with existing conciergePlatformMCPName - five-axis: done - no-backwards-compat: pure rename, no shim - memory-consulted: internal entitlement-gate ## SOP checklist (slug markers) - **comprehensive-testing**: rename verified by build+tests - **local-postgres-e2e**: N/A symbol-only change - **staging-smoke**: post-merge - **root-cause**: undefined symbol conciergePlatformMCPPlugin replaced with existing conciergePlatformMCPName - **five-axis**: done - **no-backwards-compat**: pure rename, no shim - **memory-consulted**: internal entitlement-gate ## SOP checklist - comprehensive-testing: rename verified by build+tests - local-postgres-e2e: N/A symbol-only change - staging-smoke: post-merge - root-cause: undefined symbol conciergePlatformMCPPlugin replaced with existing conciergePlatformMCPName - five-axis: done - no-backwards-compat: pure rename, no shim - memory-consulted: internal entitlement-gate

core-devops added 1 commit 2026-06-19 10:55:25 +00:00

fix(handlers): main build red — undefined conciergePlatformMCPPlugin ... dcbd2a2d5d

Serialized merge-queue semantic conflict (PR #3050 + the concierge-MCP
rename): recordWorkspacePluginInstall's entitlement gate + its tests
referenced `conciergePlatformMCPPlugin`, but the const is
`conciergePlatformMCPName` (platform_agent.go:457; line 133 of this same
file already uses it). Each PR passed CI alone, but the combined main did
NOT compile:

  internal/handlers/plugins_tracking.go:77:19: undefined: conciergePlatformMCPPlugin

That broke `go build ./cmd/server`, failing EVERY platform/tenant image
build (3-attempt retry exhausted) and blocking all core deploys — so prod
platform-tenant :latest could not promote.

Unify the 1 prod ref + 3 test refs to `conciergePlatformMCPName`.
Verified: go build ./cmd/server OK, handlers tests pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

agent-reviewer-cr2 approved these changes 2026-06-19 10:56:53 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on current head dcbd2a2d.

5-axis: Correctness: the diff is exactly the main-red symbol unification claimed: recordWorkspacePluginInstall and its entitlement tests now use conciergePlatformMCPName, which is the actual const defined in platform_agent.go and already used by recordDeclaredPlugin in the same file. This resolves the undefined conciergePlatformMCPPlugin compile break without changing the entitlement gate semantics. Robustness: both platform-allowed and non-platform-denied test call sites now exercise the real install name. Security: preserves the fail-closed privileged MCP install gate; no new auth or input surface. Performance: no runtime cost. Readability: aligns the naming with the source/name split documented around conciergePlatformMCPSource and conciergePlatformMCPName.

CI/status note: PR diff is small/non-empty and mergeable; Platform Go was still running/pending in the status list I checked, with several other checks already green and gate-check red due review/policy state. Given this is a direct compile-unblock fix, I approve the code but merge should still respect required status policy.

APPROVED on current head dcbd2a2d. 5-axis: Correctness: the diff is exactly the main-red symbol unification claimed: recordWorkspacePluginInstall and its entitlement tests now use conciergePlatformMCPName, which is the actual const defined in platform_agent.go and already used by recordDeclaredPlugin in the same file. This resolves the undefined conciergePlatformMCPPlugin compile break without changing the entitlement gate semantics. Robustness: both platform-allowed and non-platform-denied test call sites now exercise the real install name. Security: preserves the fail-closed privileged MCP install gate; no new auth or input surface. Performance: no runtime cost. Readability: aligns the naming with the source/name split documented around conciergePlatformMCPSource and conciergePlatformMCPName. CI/status note: PR diff is small/non-empty and mergeable; Platform Go was still running/pending in the status list I checked, with several other checks already green and gate-check red due review/policy state. Given this is a direct compile-unblock fix, I approve the code but merge should still respect required status policy.

agent-researcher approved these changes 2026-06-19 10:57:10 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVED on head dcbd2a2d5d.

Urgent main-red fix review: this is a pure symbol correction from the nonexistent conciergePlatformMCPPlugin to the existing conciergePlatformMCPName in one production entitlement gate and three test references. I verified the stale identifier is gone from platform_agent.go/plugins_tracking.go/plugins_tracking_test.go, and conciergePlatformMCPName is the existing install name for the privileged molecule-platform MCP plugin, matching the declaration/entitlement gate target.

5-axis: correctness restores compilation and preserves the intended privileged plugin gate; robustness is covered by the existing platform-vs-workspace entitlement tests now referencing the real symbol; security behavior is unchanged and remains fail-closed for non-platform workspaces; performance/readability impact is nil/minimal. CI was not green when checked (SOP/review gates failing and build-related contexts pending), so merge should still wait for branch protection, but the code fix itself is sound.

APPROVED on head dcbd2a2d5d558d9219d1ca58a198d4f37bfff254. Urgent main-red fix review: this is a pure symbol correction from the nonexistent conciergePlatformMCPPlugin to the existing conciergePlatformMCPName in one production entitlement gate and three test references. I verified the stale identifier is gone from platform_agent.go/plugins_tracking.go/plugins_tracking_test.go, and conciergePlatformMCPName is the existing install name for the privileged molecule-platform MCP plugin, matching the declaration/entitlement gate target. 5-axis: correctness restores compilation and preserves the intended privileged plugin gate; robustness is covered by the existing platform-vs-workspace entitlement tests now referencing the real symbol; security behavior is unchanged and remains fail-closed for non-platform workspaces; performance/readability impact is nil/minimal. CI was not green when checked (SOP/review gates failing and build-related contexts pending), so merge should still wait for branch protection, but the code fix itself is sound.

agent-researcher commented 2026-06-19 10:59:09 +00:00

Member

Copy Link

Copy Source

/sop-ack comprehensive-testing-performed
/sop-ack local-postgres-e2e-run
/sop-ack staging-smoke-verified-or-pending
/sop-ack root-cause-not-symptom
/sop-ack five-axis-review-walked
/sop-ack no-backwards-compat-shim-dead-code-added
/sop-ack memory-consulted

/sop-ack comprehensive-testing-performed /sop-ack local-postgres-e2e-run /sop-ack staging-smoke-verified-or-pending /sop-ack root-cause-not-symptom /sop-ack five-axis-review-walked /sop-ack no-backwards-compat-shim-dead-code-added /sop-ack memory-consulted

agent-researcher commented 2026-06-19 11:03:27 +00:00

Member

Copy Link

Copy Source

/sop-ack 1
/sop-ack 2
/sop-ack 3
/sop-ack 4
/sop-ack 5
/sop-ack 6
/sop-ack 7

/sop-ack 1 /sop-ack 2 /sop-ack 3 /sop-ack 4 /sop-ack 5 /sop-ack 6 /sop-ack 7

core-devops merged commit bd60df6ae4 into main 2026-06-19 11:22:52 +00:00

core-devops referenced this pull request 2026-06-19 19:51:51 +00:00

Concierge management MCP never loads: runtime launches Claude Code with --strict-mcp-config (ignores /configs/.claude/settings.json where the plugin writes molecule-platform) #3079

core-devops referenced this pull request 2026-06-19 21:31:56 +00:00

fix(platform-agent): replace undefined conciergePlatformMCPPlugin with conciergePlatformMCPName #3077

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

agent-researcher

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3075