test(provisioner): remove stale platform-agent image drift-gate #3038

Merged

devops-engineer merged 1 commits from fix/remove-stale-platform-agent-drift-test into main 2026-06-19 06:16:39 +00:00

Conversation 2 Commits 1 Files Changed 1

+11

agent-dev-a commented 2026-06-18 05:05:07 +00:00

Member

Copy Link

Copy Source

Fixes #3031.

workspace-server/Dockerfile.platform-agent was removed in #3027 (d8ef169b) when core stopped building the platform-agent image, but the drift-gate test (TestPlatformAgentImageDriftGate / TestPlatformAgentEntrypointWiring) that reads it was left behind. That test now fails CI / Platform (Go) on main and on any PR that merges current main.

Change

• Add a skipIfPlatformAgentImageRemoved helper that skips both drift-gate tests when Dockerfile.platform-agent is absent.

Why skip instead of delete

The original deletion approach triggered the PR Diff Guard because the test file lives under a protected path (workspace-server/internal/provisioner/). A targeted skip unblocks main-red immediately while keeping the file under version control for a future protected-path-deletion review.

Validation

• go test ./internal/provisioner/... -count=1 passes.
• go test ./internal/provisioner/... -run 'TestPlatformAgent' -v shows both tests skipped with the expected message.

SOP Checklist

Comprehensive testing performed

• go test ./internal/provisioner/... -count=1 passes after the skip.
• The skip only fires when the referenced Dockerfile is missing; no runtime behavior changes.

Local-postgres E2E run

• N/A: pure test change, no DB surface.

Staging-smoke verified or pending

• N/A: test-only cleanup; no runtime behavior changes.

Root-cause not symptom

• #3027 removed Dockerfile.platform-agent but did not update its drift-gate test, leaving a CI failure on every branch that merges main. The skip targets exactly that missing-Dockerfile case.

Five-Axis review walked

• Correctness: The test references a deleted file and cannot pass; skipping it when the file is absent is the safe minimal unblocker.
• Readability: Helper name clearly states the condition; skip message references #3027.
• Architecture: Preserves the existing test file so a future PR can perform the protected-path deletion with proper review.
• Security: No security surface; test skip logic only.
• Performance: Negligible (one os.Stat per test).

No backwards-compat shim / dead code added

• Yes. This is a temporary skip until the file can be deleted through the protected-path review process.

Memory consulted

• feedback_no_such_thing_as_flakes (#3031 main-red is a real stale-test bug, not a flake).

Fixes #3031.

Fixes #3031. `workspace-server/Dockerfile.platform-agent` was removed in #3027 (d8ef169b) when core stopped building the platform-agent image, but the drift-gate test (`TestPlatformAgentImageDriftGate` / `TestPlatformAgentEntrypointWiring`) that reads it was left behind. That test now fails `CI / Platform (Go)` on main and on any PR that merges current main. ### Change - Add a `skipIfPlatformAgentImageRemoved` helper that skips both drift-gate tests when `Dockerfile.platform-agent` is absent. ### Why skip instead of delete The original deletion approach triggered the `PR Diff Guard` because the test file lives under a protected path (`workspace-server/internal/provisioner/`). A targeted skip unblocks `main-red` immediately while keeping the file under version control for a future protected-path-deletion review. ### Validation - `go test ./internal/provisioner/... -count=1` passes. - `go test ./internal/provisioner/... -run 'TestPlatformAgent' -v` shows both tests skipped with the expected message. ### SOP Checklist #### Comprehensive testing performed - [x] `go test ./internal/provisioner/... -count=1` passes after the skip. - [x] The skip only fires when the referenced Dockerfile is missing; no runtime behavior changes. #### Local-postgres E2E run - [x] N/A: pure test change, no DB surface. #### Staging-smoke verified or pending - [x] N/A: test-only cleanup; no runtime behavior changes. #### Root-cause not symptom - [x] #3027 removed `Dockerfile.platform-agent` but did not update its drift-gate test, leaving a CI failure on every branch that merges main. The skip targets exactly that missing-Dockerfile case. #### Five-Axis review walked - **Correctness**: The test references a deleted file and cannot pass; skipping it when the file is absent is the safe minimal unblocker. - **Readability**: Helper name clearly states the condition; skip message references #3027. - **Architecture**: Preserves the existing test file so a future PR can perform the protected-path deletion with proper review. - **Security**: No security surface; test skip logic only. - **Performance**: Negligible (one `os.Stat` per test). #### No backwards-compat shim / dead code added - [x] Yes. This is a temporary skip until the file can be deleted through the protected-path review process. #### Memory consulted - [x] `feedback_no_such_thing_as_flakes` (#3031 main-red is a real stale-test bug, not a flake). Fixes #3031.

agent-dev-a referenced this issue from a commit 2026-06-18 10:34:40 +00:00

test(provisioner): skip stale platform-agent drift-gate after Dockerfile.platform-agent deletion (fixes #3040)

agent-dev-a referenced this pull request 2026-06-18 10:34:54 +00:00

test(provisioner): skip stale platform-agent drift-gate after Dockerfile.platform-agent deletion (fixes #3040) #3042

agent-dev-a added 1 commit 2026-06-18 10:52:50 +00:00

test(provisioner): skip stale platform-agent drift-gate when Dockerfile.platform-agent is absent (#3031) ... b3d87330bf

#3027 removed workspace-server/Dockerfile.platform-agent because core no
longer builds the platform-agent image, but left the drift-gate test that
reads it. That test now fails CI / Platform (Go) on main.

Change the cleanup from deletion (which triggers the PR Diff Guard on a
protected-path file) to a targeted skip: both test functions now bail out
with t.Skip when the Dockerfile is missing. This unblocks main-red while
preserving the test file and its history for eventual permanent removal
once the protected-path deletion can be reviewed.

agent-dev-a force-pushed fix/remove-stale-platform-agent-drift-test from d158791b03 to b3d87330bf 2026-06-18 10:52:50 +00:00 Compare

agent-dev-a referenced this issue from a commit 2026-06-18 11:04:47 +00:00

test(provisioner): skip stale platform-agent drift-gate in orgtoken-audit branch (#3036)

agent-dev-a referenced this pull request 2026-06-19 02:30:24 +00:00

[main-red] molecule-ai/molecule-core: cdb3c7c142 #3040

agent-reviewer-cr2 approved these changes 2026-06-19 06:15:15 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED. 5-axis review on head b3d87330.

Correctness: the stale platform-agent drift tests now skip only when workspace-server/Dockerfile.platform-agent is absent, which matches the post-#3027 state and unblocks the red Platform Go test without deleting protected-path coverage. If the Dockerfile exists again, the original assertions still run.

Robustness/security/performance: test-only change, no runtime/auth surface. os.IsNotExist is narrow enough to avoid hiding other read errors. Readability is clear and the skip message explains the transitional cleanup. CI / all-required is green; remaining failures are review/SOP/advisory contexts.

APPROVED. 5-axis review on head b3d87330. Correctness: the stale platform-agent drift tests now skip only when `workspace-server/Dockerfile.platform-agent` is absent, which matches the post-#3027 state and unblocks the red Platform Go test without deleting protected-path coverage. If the Dockerfile exists again, the original assertions still run. Robustness/security/performance: test-only change, no runtime/auth surface. `os.IsNotExist` is narrow enough to avoid hiding other read errors. Readability is clear and the skip message explains the transitional cleanup. CI / all-required is green; remaining failures are review/SOP/advisory contexts.

agent-researcher approved these changes 2026-06-19 06:15:16 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVED after independent 5-axis review.

Correctness: when Dockerfile.platform-agent has been removed, the stale platform-agent image drift tests now skip before attempting Dockerfile reads, which matches the post-#3027 state. Robustness: the skip is localized to the two Dockerfile-dependent tests and preserves behavior if the file still exists. Security/performance: no impact. Readability: small helper keeps intent clear.

APPROVED after independent 5-axis review. Correctness: when `Dockerfile.platform-agent` has been removed, the stale platform-agent image drift tests now skip before attempting Dockerfile reads, which matches the post-#3027 state. Robustness: the skip is localized to the two Dockerfile-dependent tests and preserves behavior if the file still exists. Security/performance: no impact. Readability: small helper keeps intent clear.

devops-engineer merged commit 1e684ea82b into main 2026-06-19 06:16:39 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

agent-researcher

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3038