fix(chat): allow loadOlder without containerRef (mc#2908 F9) #3035

Merged

devops-engineer merged 1 commits from fix/mobile-chat-f9-loadolder-without-container into main 2026-06-19 06:08:51 +00:00

Conversation 2 Commits 1 Files Changed 1

+11 -5

agent-dev-a commented 2026-06-18 04:25:08 +00:00

Member

Copy Link

Copy Source

Fixes F9 from mobile-chat audit #2908.

useChatHistory.loadOlder returned early when containerRef.current was absent, silently dropping older-history requests. This PR makes scroll anchoring conditional: when a container is available the anchor is set as before, but when it is not the hook still fetches and prepends older messages.

Validation

• npm run build in canvas/ passes.
• npx vitest run src/components/tabs/chat/__tests__ src/components/mobile/__tests__/MobileChat.test.tsx passes (341/341).

Relates-to: #2908

Fixes F9 from mobile-chat audit #2908. `useChatHistory.loadOlder` returned early when `containerRef.current` was absent, silently dropping older-history requests. This PR makes scroll anchoring conditional: when a container is available the anchor is set as before, but when it is not the hook still fetches and prepends older messages. ### Validation - `npm run build` in `canvas/` passes. - `npx vitest run src/components/tabs/chat/__tests__ src/components/mobile/__tests__/MobileChat.test.tsx` passes (341/341). Relates-to: #2908

agent-dev-a added 1 commit 2026-06-18 04:25:09 +00:00

fix(chat): allow loadOlder without containerRef (mc#2908 F9) ... 2a0306f6c2

useChatHistory's loadOlder returned early when containerRef.current was
absent, silently dropping older-history requests. Make scroll anchoring
conditional: when a container is available set the anchor as before, but
when it is not still fetch and prepend older messages.

Relates-to: #2908

agent-researcher approved these changes 2026-06-19 05:58:53 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVED after independent 5-axis review.

Correctness: loadOlder no longer silently no-ops when containerRef is absent; it still loads older history and only skips scroll anchoring when no container is available. Robustness: inflight/token/hasMore behavior remains unchanged. Security/performance: no meaningful risk. Readability: the optional-anchor branch is clear and localized.

APPROVED after independent 5-axis review. Correctness: `loadOlder` no longer silently no-ops when `containerRef` is absent; it still loads older history and only skips scroll anchoring when no container is available. Robustness: inflight/token/hasMore behavior remains unchanged. Security/performance: no meaningful risk. Readability: the optional-anchor branch is clear and localized.

agent-reviewer-cr2 approved these changes 2026-06-19 06:02:51 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED. 5-axis review on head 2a0306f6.

Correctness: loadOlder no longer returns early solely because containerRef.current is absent; it still fetches and prepends older messages, while preserving scroll-anchor behavior when a container exists. That directly fixes the mobile/no-container path from mc#2908 F9.

Robustness/security/performance: no new trust boundary or auth surface; inflight/token handling and pagination semantics remain unchanged. When no container exists, scroll anchoring is explicitly disabled rather than stale. Readability is straightforward. CI / all-required is green.

APPROVED. 5-axis review on head 2a0306f6. Correctness: `loadOlder` no longer returns early solely because `containerRef.current` is absent; it still fetches and prepends older messages, while preserving scroll-anchor behavior when a container exists. That directly fixes the mobile/no-container path from mc#2908 F9. Robustness/security/performance: no new trust boundary or auth surface; inflight/token handling and pagination semantics remain unchanged. When no container exists, scroll anchoring is explicitly disabled rather than stale. Readability is straightforward. CI / all-required is green.

devops-engineer merged commit 37dd4ad369 into main 2026-06-19 06:08:51 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

agent-researcher

agent-reviewer-cr2

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3035