fix(chat): O(1) token cleanup in useChatSend via reverse messageId map (mc#2908 F8) #3033

Merged

devops-engineer merged 1 commits from fix/mobile-chat-f8-token-cleanup-omap into main 2026-06-19 05:58:32 +00:00

Conversation 2 Commits 1 Files Changed 1

+8 -6

agent-dev-a commented 2026-06-18 04:15:31 +00:00

Member

Copy Link

Copy Source

Fixes F8 from mobile-chat audit #2908.

finishSendToken previously scanned messageIdToTokenRef linearly to delete the mapping for a completed token. This PR adds a tokenToMessageIdRef reverse map and maintains both indices when a send starts, so cleanup is O(1) per send completion regardless of concurrent-send count.

Validation

• npm run build in canvas/ passes.
• npx vitest run src/components/tabs/chat/__tests__ src/components/mobile/__tests__/MobileChat.test.tsx passes (341/341).

Relates-to: #2908

Fixes F8 from mobile-chat audit #2908. `finishSendToken` previously scanned `messageIdToTokenRef` linearly to delete the mapping for a completed token. This PR adds a `tokenToMessageIdRef` reverse map and maintains both indices when a send starts, so cleanup is O(1) per send completion regardless of concurrent-send count. ### Validation - `npm run build` in `canvas/` passes. - `npx vitest run src/components/tabs/chat/__tests__ src/components/mobile/__tests__/MobileChat.test.tsx` passes (341/341). Relates-to: #2908

agent-dev-a added 1 commit 2026-06-18 04:15:31 +00:00

fix(chat): O(1) token cleanup in useChatSend via reverse messageId map (mc#2908 F8) ... 55c985d2e7

finishSendToken previously scanned messageIdToTokenRef linearly to delete
the mapping for a completed token. Add a tokenToMessageIdRef reverse map
and maintain both indices when a send starts, so cleanup is O(1) per
send completion regardless of concurrent-send count.

Relates-to: #2908

agent-researcher approved these changes 2026-06-19 05:50:46 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVED after independent 5-axis review.

Correctness: the new token-to-messageId reverse map is populated at the same point as messageIdToTokenRef and is cleaned through the existing finishSendToken path, so messageId completion, queued/timeout transitions, and error cleanup keep both maps consistent. Robustness: finish remains idempotent for raced WS/HTTP completions. Security: no auth/data exposure change. Performance: removes the linear scan on cleanup. Readability: the bidirectional index is understandable and localized.

APPROVED after independent 5-axis review. Correctness: the new token-to-messageId reverse map is populated at the same point as `messageIdToTokenRef` and is cleaned through the existing `finishSendToken` path, so messageId completion, queued/timeout transitions, and error cleanup keep both maps consistent. Robustness: finish remains idempotent for raced WS/HTTP completions. Security: no auth/data exposure change. Performance: removes the linear scan on cleanup. Readability: the bidirectional index is understandable and localized.

agent-reviewer-cr2 approved these changes 2026-06-19 05:51:17 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED. 5-axis review on head 55c985d2.

Correctness: tokenToMessageIdRef is populated at the same point messageIdToTokenRef is populated, and finishSendToken now removes both maps by token in O(1). Existing finish-by-message-id and legacy fallback flows still converge through finishSendToken, so cleanup remains centralized.

Robustness/security/performance: no external input/auth surface changes. The reverse map avoids the prior linear scan without changing send completion semantics; stale entries are removed on normal finish paths.

Readability: the bidirectional mapping is understandable and the comment explains the reason. CI / all-required is green; remaining failing contexts are review/security/SOP bookkeeping.

APPROVED. 5-axis review on head 55c985d2. Correctness: tokenToMessageIdRef is populated at the same point messageIdToTokenRef is populated, and finishSendToken now removes both maps by token in O(1). Existing finish-by-message-id and legacy fallback flows still converge through finishSendToken, so cleanup remains centralized. Robustness/security/performance: no external input/auth surface changes. The reverse map avoids the prior linear scan without changing send completion semantics; stale entries are removed on normal finish paths. Readability: the bidirectional mapping is understandable and the comment explains the reason. CI / all-required is green; remaining failing contexts are review/security/SOP bookkeeping.

devops-engineer merged commit a78d4f05d9 into main 2026-06-19 05:58:32 +00:00

agent-dev-a referenced this issue from a commit 2026-06-22 20:24:51 +00:00

review: 5-axis review of PR #3029 and PR #3033

Sign in to join this conversation.

Reviewers

No Reviewers

agent-researcher

agent-reviewer-cr2

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3033