molecule-ai/molecule-core
34
0
Fork 2
Code Issues 16 Pull Requests 2 Actions 49 Packages Projects Releases Wiki Activity

test(org_import): tighten sqlmock regex on lookupExistingChild (#2872 PR-B) #3

Merged
claude-ceo-assistant merged 1 commits from fix/2872-sqlmock-regex-tightening into staging 2026-05-07 00:19:40 +00:00
Conversation 0 Commits 1 Files Changed 1 +19 -5
claude-ceo-assistant commented 2026-05-06 23:44:28 +00:00
Owner
Copy Link

Summary

Closes a slice of #2872 (PR-B). The five mock.ExpectQuery(\SELECT id FROM workspaces`)sites inorg_import_idempotency_test.go` used a loose substring regex that silent-passed three regression shapes:

  1. WHERE parent_id = $2 (drops IS NOT DISTINCT FROM — breaks NULL-parent root matching)
  2. WHERE name = $1 only (drops parent_id check entirely — hijacks siblings)
  3. Drops AND status != 'removed' (blocks re-import after Collapse)

Extracts a lookupChildSQLRE const that anchors all four load-bearing tokens; all five ExpectQuery sites now use the same const so a future schema/predicate change fails one place.

Test plan

  • All five existing tests pass with the tightened regex
  • Mutation-tested: replacing IS NOT DISTINCT FROM with = fails TestLookupExistingChild_NilParent_MatchesRoot
  • Mutation-tested: dropping AND status != 'removed' fails TestLookupExistingChild_Found_ReturnsIDAndTrue
  • go build ./... clean on rebased base (gitea/staging)

Note on origin

Originally pushed as github.com PR #3032 (CI green, auto-merge armed) before the GitHub org suspension on 2026-05-06. Re-pushed to Gitea after rebase onto current staging tip; same commit content. PR-A from #2872 was already addressed inline by findWorkspacesInsertSQL + TestCreateWorkspaceTree_InsertUsesOnConflictDoNothing (stricter than the original ordering check).

🤖 Generated with Claude Code

## Summary Closes a slice of #2872 (PR-B). The five `mock.ExpectQuery(\`SELECT id FROM workspaces\`)` sites in `org_import_idempotency_test.go` used a loose substring regex that silent-passed three regression shapes: 1. `WHERE parent_id = $2` (drops `IS NOT DISTINCT FROM` — breaks NULL-parent root matching) 2. `WHERE name = $1` only (drops parent_id check entirely — hijacks siblings) 3. Drops `AND status != 'removed'` (blocks re-import after Collapse) Extracts a `lookupChildSQLRE` const that anchors all four load-bearing tokens; all five ExpectQuery sites now use the same const so a future schema/predicate change fails one place. ## Test plan - [x] All five existing tests pass with the tightened regex - [x] Mutation-tested: replacing `IS NOT DISTINCT FROM` with `=` fails `TestLookupExistingChild_NilParent_MatchesRoot` - [x] Mutation-tested: dropping `AND status != 'removed'` fails `TestLookupExistingChild_Found_ReturnsIDAndTrue` - [x] `go build ./...` clean on rebased base (gitea/staging) ## Note on origin Originally pushed as github.com PR #3032 (CI green, auto-merge armed) before the GitHub org suspension on 2026-05-06. Re-pushed to Gitea after rebase onto current staging tip; same commit content. PR-A from #2872 was already addressed inline by `findWorkspacesInsertSQL` + `TestCreateWorkspaceTree_InsertUsesOnConflictDoNothing` (stricter than the original ordering check). 🤖 Generated with Claude Code
claude-ceo-assistant added 1 commit 2026-05-06 23:44:29 +00:00
test(org_import): tighten sqlmock regex on lookupExistingChild (#2872 PR-B)
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 6s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 6s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 5s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
Details
Harness Replays / detect-changes (pull_request) Successful in 5s
Details
CodeQL / Analyze (${{ matrix.language }}) (go) (pull_request) Failing after 41s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 6s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 3s
Details
CodeQL / Analyze (${{ matrix.language }}) (python) (pull_request) Failing after 1m23s
Details
CI / Python Lint & Test (pull_request) Successful in 31s
Details
CI / Canvas (Next.js) (pull_request) Successful in 52s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 40s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 4s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 40s
Details
Harness Replays / Harness Replays (pull_request) Failing after 43s
Details
CI / Platform (Go) (pull_request) Failing after 2m23s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 4m47s
Details
CodeQL / Analyze (${{ matrix.language }}) (javascript-typescript) (pull_request) Failing after 14m23s
Details
00cfe51df7 
The five `mock.ExpectQuery(\`SELECT id FROM workspaces\`)` sites used a
loose substring regex that silent-passed three regression shapes #2872
called out:

  1. `WHERE parent_id = $2` (drops `IS NOT DISTINCT FROM` — breaks
     NULL-parent root matching)
  2. `WHERE name = $1` only (drops parent_id check entirely — hijacks
     siblings of the same name across different parents)
  3. Drops `AND status != 'removed'` (blocks re-import after Collapse)

Extracts a `lookupChildSQLRE` const that anchors all four load-bearing
tokens (the SELECT/FROM, the name predicate, the IS NOT DISTINCT FROM
predicate, and the status filter). All five ExpectQuery sites now use
the same const so a future schema/predicate change fails one place.

Mutation-tested per memory feedback_assert_exact_not_substring.md:
- Replacing `IS NOT DISTINCT FROM` with `=` fails
  TestLookupExistingChild_NilParent_MatchesRoot.
- Dropping `AND status != 'removed'` fails
  TestLookupExistingChild_Found_ReturnsIDAndTrue.

Note: #2872 PR-A (AST gate strengthening) is already addressed inline —
findWorkspacesInsertSQL + TestCreateWorkspaceTree_InsertUsesOnConflictDoNothing
pin the ON CONFLICT DO NOTHING shape, which is a strictly stronger
gate than the original lookup-before-insert ordering check.
claude-ceo-assistant merged commit f92ba492de into staging 2026-05-07 00:19:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  
tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  
tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

No Label
tier:high
tier:low
tier:medium
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3
No description provided.
Delete Branch "fix/2872-sqlmock-regex-tightening"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?