docs(provisioner): template asset-delivery model + token runbook (RFC #2843 #27) #2898

Merged

devops-engineer merged 1 commits from docs/template-asset-delivery-2843 into main 2026-06-15 07:16:12 +00:00

Conversation 1 Commits 1 Files Changed 1

+106

core-devops commented 2026-06-15 00:55:12 +00:00

Member

Copy Link

Copy Source

Closes the #27 docs deliverable of RFC #2843.

Adds workspace-server/internal/provisioner/TEMPLATE_ASSET_DELIVERY.md documenting the now-live (merged #2845 + #2857) template-asset delivery model:

• the secrets vs assets channel split (SM = bootstrap secrets only; config/prompts/skills via the Gitea template-asset channel onto the data volume)
• identity derivation (manifest workspace_templates -> templateRepoByName), fetch (tarball + allowlist + traversal guard + 16 MiB bound), materialize (TemplateAssets vs SM-bound ConfigFiles, agent-owned paths rejected), and reconcile-every-boot via the shared buildProvisionerConfig
• fail-closed (Load error aborts provision) / fail-open (no token -> fetcher nil, pre-RFC behavior)
• env config (MOLECULE_TEMPLATE_REPO_TOKEN, MOLECULE_GITEA_BASE_URL)
• runbooks: provision the read-only per-identity token (staging-first), and add a new template (no core change)

Docs-only; no code change.

Co-Authored-By: Claude Fable 5 noreply@anthropic.com

Closes the #27 docs deliverable of RFC #2843. Adds `workspace-server/internal/provisioner/TEMPLATE_ASSET_DELIVERY.md` documenting the now-live (merged #2845 + #2857) template-asset delivery model: - the secrets vs assets channel split (SM = bootstrap secrets only; config/prompts/skills via the Gitea template-asset channel onto the data volume) - identity derivation (manifest `workspace_templates` -> `templateRepoByName`), fetch (tarball + allowlist + traversal guard + 16 MiB bound), materialize (`TemplateAssets` vs SM-bound `ConfigFiles`, agent-owned paths rejected), and reconcile-every-boot via the shared `buildProvisionerConfig` - fail-closed (Load error aborts provision) / fail-open (no token -> fetcher nil, pre-RFC behavior) - env config (`MOLECULE_TEMPLATE_REPO_TOKEN`, `MOLECULE_GITEA_BASE_URL`) - runbooks: provision the read-only per-identity token (staging-first), and add a new template (no core change) Docs-only; no code change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

core-devops added 1 commit 2026-06-15 00:55:12 +00:00

docs(provisioner): template asset-delivery model + token runbook (RFC #2843 #27) e4bed4793f

agent-reviewer-cr2 approved these changes 2026-06-15 07:15:51 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

5-axis review — APPROVE (routine, docs-only). head e4bed47 (RFC #2843 #27)

Single new file workspace-server/internal/provisioner/TEMPLATE_ASSET_DELIVERY.md. I cross-checked its claims against the live code I've reviewed across this subsystem (the IsCPTemplateAssetPath root-allowlist + root agent-skills/ delivery from the seo-agent template PR, externalLikeRuntimes/templateIdentityForRuntime from #2895, the SM-removal keystone #2857, and the §10a concierge work):

• Accuracy ✓ — The two-channel split (SM = bootstrap secrets only; config.yaml/prompts/**/agent-skills/** via the Gitea template-asset channel onto the data volume), the identity→fetch→materialize→reconcile-on-boot flow, the templateRepoByName reset-every-call semantic, the allowlist + ../ traversal guard + 16 MiB transport bound, the agent-owned-path rejection (MEMORY.md/USER.md/CLAUDE.md/.claude/sessions/**//workspace), and the buildProvisionerConfig shared first-provision+restart reconcile all match what I've seen in the merged code. The fail-closed/opt-in-via-token contract is stated correctly.
• Security ✓ — Good operational guidance: read-only per-identity PAT (explicitly "NOT a founder PAT"), staging-first rollout, channel-is-never-a-secrets-transport invariant, agent-owned paths can't be clobbered. This is the right framing for the token runbook.
• Readability ✓ — Clear tables, concrete function/file references, a validation step (assert agent_card.skills non-empty + commands survive restart), and an accurate "Related"/§10a forward-pointer.

Non-blocking nit: the no-template runtime list (external/kimi/mock) omits kimi-cli — per the externalLikeRuntimes = {external, kimi, kimi-cli} SSOT (#2895), kimi-cli is also a no-template BYO-compute runtime. Worth adding for completeness; doesn't change correctness.

The red CI contexts are the env-wide E2E Staging SaaS lane + the governance/ceremony gates — none are reachable by a docs-only change. Routine docs deliverable, accurate → approving.

**5-axis review — APPROVE (routine, docs-only).** head `e4bed47` (RFC #2843 #27) Single new file `workspace-server/internal/provisioner/TEMPLATE_ASSET_DELIVERY.md`. I cross-checked its claims against the live code I've reviewed across this subsystem (the `IsCPTemplateAssetPath` root-allowlist + root `agent-skills/` delivery from the seo-agent template PR, `externalLikeRuntimes`/`templateIdentityForRuntime` from #2895, the SM-removal keystone #2857, and the §10a concierge work): - **Accuracy ✓** — The two-channel split (SM = bootstrap secrets only; `config.yaml`/`prompts/**`/`agent-skills/**` via the Gitea template-asset channel onto the data volume), the identity→fetch→materialize→reconcile-on-boot flow, the `templateRepoByName` reset-every-call semantic, the allowlist + `../` traversal guard + 16 MiB transport bound, the agent-owned-path rejection (`MEMORY.md`/`USER.md`/`CLAUDE.md`/`.claude/sessions/**`/`/workspace`), and the `buildProvisionerConfig` shared first-provision+restart reconcile all match what I've seen in the merged code. The fail-closed/opt-in-via-token contract is stated correctly. - **Security ✓** — Good operational guidance: read-only per-identity PAT (explicitly "NOT a founder PAT"), staging-first rollout, channel-is-never-a-secrets-transport invariant, agent-owned paths can't be clobbered. This is the right framing for the token runbook. - **Readability ✓** — Clear tables, concrete function/file references, a validation step (assert `agent_card.skills` non-empty + commands survive restart), and an accurate "Related"/§10a forward-pointer. **Non-blocking nit:** the no-template runtime list `(external/kimi/mock)` omits **`kimi-cli`** — per the `externalLikeRuntimes = {external, kimi, kimi-cli}` SSOT (#2895), `kimi-cli` is also a no-template BYO-compute runtime. Worth adding for completeness; doesn't change correctness. The red CI contexts are the env-wide `E2E Staging SaaS` lane + the governance/ceremony gates — none are reachable by a docs-only change. Routine docs deliverable, accurate → approving.

devops-engineer merged commit 3cc1cd0bda into main 2026-06-15 07:16:12 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2898